Skip to content

Commit b177e32

Browse files
committed
fix: run tests natively by default
Tests like lint and vet used to be ran within a container engine by default if an engine was detected, both locally and in CI. Up until now no container engine was detected in CI, so tests would run natively there. Now that the base image we use in CI has now started shipping `podman`, a container engine is detected by default and tests are run within podman by default. But creating nested containers doesn't work in CI at the moment and thus results in a test failure. As such we are switching the default behaviour for tests (both locally and in CI), where now by default no container engine is used to run tests, even if one is detected, but instead tests are run natively unless otherwise specified.
1 parent a8a3164 commit b177e32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export GOPROXY
4545
GOARCH ?= $(shell go env GOARCH)
4646
GOOS ?= $(shell go env GOOS)
4747

48-
NO_DOCKER ?= 0
48+
NO_DOCKER ?= 1
4949

5050
ifeq ($(shell command -v podman > /dev/null 2>&1 ; echo $$? ), 0)
5151
ENGINE=podman

0 commit comments

Comments
 (0)