Removed webhook validation

Signed-off-by: anirudhAgniRedhat <[email protected]>

Author: anirudhAgniRedhat

pkg/cloud/azure/actuators/machine/reconciler.go

@@ -47,7 +47,6 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/klog/v2"
 	"k8s.io/utils/ptr"
-	azureutils "sigs.k8s.io/cluster-api-provider-azure/util/azure"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
@@ -682,9 +681,6 @@ func (s *Reconciler) createVirtualMachine(ctx context.Context, nicName, asName s
 		}
 
 		if s.scope.MachineConfig.CapacityReservationGroupID != "" {
-			if err = validateCapacityReservationGroupID(s.scope.MachineConfig.CapacityReservationGroupID); err != nil {
-				return fmt.Errorf("invalid capacityReservationGroupID : %w", err)
-			}
 			vmSpec.CapacityReservationGroupID = s.scope.MachineConfig.CapacityReservationGroupID
 		}
 
@@ -864,10 +860,3 @@ func createDiagnosticsConfig(config *machinev1.AzureMachineProviderSpec) (*compu
 		)
 	}
 }
-
-func validateCapacityReservationGroupID(capacityReservationGroupID string) error {
-	if _, err := azureutils.ParseResourceID(capacityReservationGroupID); err != nil {
-		return err
-	}
-	return nil
-}

pkg/cloud/azure/actuators/machine/reconciler_test.go

@@ -620,44 +620,3 @@ func TestCreateDiagnosticsConfig(t *testing.T) {
 		})
 	}
 }
-
-func TestValidateCapacityReservationGroupID(t *testing.T) {
-	testCases := []struct {
-		name          string
-		inputID       string
-		expectedError error
-	}{
-		{
-			name:          "validation for capacityReservationGroupID should return nil error if field input is valid",
-			inputID:       "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup",
-			expectedError: nil,
-		},
-		{
-			name:          "validation for capacityReservationGroupID should return error if field input does not start with '/'",
-			inputID:       "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup",
-			expectedError: errors.New("invalid resource ID: resource id 'subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup' must start with '/'"),
-		},
-		{
-			name:          "validation for capacityReservationGroupID should return error if field input does not have field name subscriptions",
-			inputID:       "/subscripti/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup",
-			expectedError: errors.New("invalid resource ID: /subscripti/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/capacityReservationGroups/myCapacityReservationGroup"),
-		},
-		{
-			name:          "validation for capacityReservationGroupID should return error if field input is empty",
-			inputID:       "",
-			expectedError: errors.New("invalid resource ID: id cannot be empty"),
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			g := NewWithT(t)
-			err := validateCapacityReservationGroupID(tc.inputID)
-			if tc.expectedError != nil {
-				g.Expect(err).To(MatchError(tc.expectedError))
-			} else {
-				g.Expect(err).ToNot(HaveOccurred())
-			}
-		})
-	}
-}