Skip to content

OCPBUGS-56169: [release-4.16] Update virtualmachines service to armcompute/v5 SDK #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

OCPBUGS-56169: [release-4.16] Update virtualmachines service to armcompute/v5 SDK #147

wants to merge 2 commits into from

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented May 14, 2025

This replaces use of the legacy /services SDK for compute only in the virtualmachines service, with a minimal set of supporting changes. This allows using Azure APIs beyond those available via the legacy SDK.

(cherry picked from commit f76ad07)

Conflicts:

  • pkg/cloud/azure/actuators/machine/reconciler.go
    • getPlatformFaultDomain is not present
  • pkg/cloud/azure/actuators/machine/reconciler_test.go
    • No test for getPlatformFaultDomain
  • pkg/cloud/azure/decode/virtualmachine.go
    • We deleted it anyway

(cherry picked from commit 51fbd9a)

Conflicts:

  • go.mod
    • Trivial difference in grouping

(cherry picked from commit 0f4b6f1)

Conflicts:

  • go.mod
    • Bump azcore to v1.12.0
    • Bump azidentity to v1.6.0
    • Dependencies of the above
  • pkg/cloud/azure/services/virtualmachines/virtualmachines.go pkg/cloud/azure/services/virtualmachines/virtualmachines_test.go
    • Use VirtualMachineEvictionPolicyTypesDeallocate instead of VirtualMachineEvictionPolicyTypesDelete for spot VMs

Merge first:

/hold

mdbooth added 2 commits May 14, 2025 12:05
@mdbooth
Update virtualmachines service to armcompute/v5 SDK
04ba80e 
This replaces use of the legacy /services SDK for compute only in the
virtualmachines service, with a minimal set of supporting changes. This
allows using Azure APIs beyond those available via the legacy SDK.

(cherry picked from commit f76ad07)

Conflicts:
* pkg/cloud/azure/actuators/machine/reconciler.go
  - getPlatformFaultDomain is not present
* pkg/cloud/azure/actuators/machine/reconciler_test.go
  - No test for getPlatformFaultDomain
* pkg/cloud/azure/decode/virtualmachine.go
  - We deleted it anyway

(cherry picked from commit 51fbd9a)

Conflicts:
* go.mod
  - Trivial difference in grouping

(cherry picked from commit 0f4b6f1)

Conflicts:
* go.mod
  - Bump azcore to v1.12.0
  - Bump azidentity to v1.6.0
  - Dependencies of the above
* pkg/cloud/azure/services/virtualmachines/virtualmachines.go pkg/cloud/azure/services/virtualmachines/virtualmachines_test.go
  - Use VirtualMachineEvictionPolicyTypesDeallocate instead of VirtualMachineEvictionPolicyTypesDelete for spot VMs
@mdbooth
go mod
73b1ae4
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 14, 2025
@openshift-ci-robot
Copy link

@mdbooth: This pull request references Jira Issue OCPBUGS-56169, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-56168 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This replaces use of the legacy /services SDK for compute only in the virtualmachines service, with a minimal set of supporting changes. This allows using Azure APIs beyond those available via the legacy SDK.

(cherry picked from commit f76ad07)

Conflicts:

  • pkg/cloud/azure/actuators/machine/reconciler.go
  • getPlatformFaultDomain is not present
  • pkg/cloud/azure/actuators/machine/reconciler_test.go
  • No test for getPlatformFaultDomain
  • pkg/cloud/azure/decode/virtualmachine.go
  • We deleted it anyway

(cherry picked from commit 51fbd9a)

Conflicts:

  • go.mod
  • Trivial difference in grouping

(cherry picked from commit 0f4b6f1)

Conflicts:

  • go.mod
  • Bump azcore to v1.12.0
  • Bump azidentity to v1.6.0
  • Dependencies of the above
  • pkg/cloud/azure/services/virtualmachines/virtualmachines.go pkg/cloud/azure/services/virtualmachines/virtualmachines_test.go
  • Use VirtualMachineEvictionPolicyTypesDeallocate instead of VirtualMachineEvictionPolicyTypesDelete for spot VMs

Merge first:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and racheljpg May 14, 2025 11:15
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2025

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2025
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@racheljpg racheljpg Awaiting requested review from racheljpg

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdbooth @openshift-ci-robot @openshift-merge-robot @openshift-bot