Always render latest Service Object, not oldObject (OSD-21590)

abyrne55 · abyrne55 · commit 05531bb40615 · 2024-05-08T13:58:36.000-04:00
diff --git a/pkg/webhooks/service/service.go b/pkg/webhooks/service/service.go
@@ -151,11 +151,7 @@ func (s *ServiceWebhook) renderService(req admissionctl.Request) (*corev1.Servic
 	}
 	service := &corev1.Service{}
 
-	if len(req.OldObject.Raw) > 0 {
-		err = decoder.DecodeRaw(req.OldObject, service)
-	} else {
-		err = decoder.Decode(req, service)
-	}
+	err = decoder.Decode(req, service)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -151,11 +151,7 @@ func (s ServiceWebhook) renderService(req admissionctl.Request) (corev1.Servic`
`151`	`151`	`}`
`152`	`152`	`service := &corev1.Service{}`
`153`	`153`
`154`		`- if len(req.OldObject.Raw) > 0 {`
`155`		`- err = decoder.DecodeRaw(req.OldObject, service)`
`156`		`- } else {`
`157`		`- err = decoder.Decode(req, service)`
`158`		`- }`
	`154`	`+ err = decoder.Decode(req, service)`
`159`	`155`	`if err != nil {`
`160`	`156`	`return nil, err`
`161`	`157`	`}`