Skip to content

Commit bc505b1

Browse files
committed
feat(RHINENG-20424): update the ui according to the mocks
1 parent 73db6cb commit bc505b1

File tree

1 file changed

+86
-73
lines changed

1 file changed

+86
-73
lines changed

web/src/components/Incidents/IncidentsPage.tsx

Lines changed: 86 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ import {
1717
PageSection,
1818
Stack,
1919
StackItem,
20+
ToolbarGroup,
21+
Flex,
22+
FlexItem,
2023
} from '@patternfly/react-core';
2124
import { Helmet } from 'react-helmet';
2225
import { IncidentsTable } from './IncidentsTable';
@@ -331,71 +334,77 @@ const IncidentsPage = () => {
331334
}
332335
>
333336
<ToolbarContent>
334-
<ToolbarItem>
335-
<Select
336-
aria-label="Filter type selection"
337-
isOpen={filterTypeIsExpanded}
338-
role="menu"
339-
selected={incidentPageFilterTypeSelected}
340-
onOpenChange={(isOpen) => setFilterTypeIsExpanded(isOpen)}
341-
onSelect={(event, selection) =>
342-
dispatch(setIncidentPageFilterType({ incidentPageFilterType: selection }))
343-
}
344-
shouldFocusToggleOnSelect
345-
toggle={(toggleRef) => (
346-
<MenuToggle
347-
ref={toggleRef}
348-
onClick={onFilterTypeToggle}
349-
isExpanded={filterTypeIsExpanded}
350-
icon={<FilterIcon />}
351-
>
352-
{incidentPageFilterTypeSelected}
353-
</MenuToggle>
354-
)}
355-
>
356-
<SelectOption
357-
value="Severity"
358-
isSelected={incidentPageFilterTypeSelected?.includes('Severity')}
337+
<ToolbarGroup>
338+
<ToolbarItem>
339+
<Select
340+
aria-label="Filter type selection"
341+
isOpen={filterTypeIsExpanded}
342+
role="menu"
343+
selected={incidentPageFilterTypeSelected}
344+
onOpenChange={(isOpen) => setFilterTypeIsExpanded(isOpen)}
345+
onSelect={(event, selection) =>
346+
dispatch(setIncidentPageFilterType({ incidentPageFilterType: selection }))
347+
}
348+
shouldFocusToggleOnSelect
349+
toggle={(toggleRef) => (
350+
<MenuToggle
351+
ref={toggleRef}
352+
onClick={onFilterTypeToggle}
353+
isExpanded={filterTypeIsExpanded}
354+
icon={<FilterIcon />}
355+
>
356+
{incidentPageFilterTypeSelected}
357+
</MenuToggle>
358+
)}
359359
>
360-
Severity
361-
</SelectOption>
362-
<SelectOption
363-
value="State"
364-
isSelected={incidentPageFilterTypeSelected?.includes('State')}
365-
>
366-
State
367-
</SelectOption>
368-
</Select>
369-
</ToolbarItem>
370-
<IncidentFilterToolbarItem
371-
categoryName="Severity"
372-
toggleLabel="Severity filters"
373-
options={severityOptions}
374-
incidentsActiveFilters={incidentsActiveFilters}
375-
onDeleteIncidentFilterChip={onDeleteIncidentFilterChip}
376-
onDeleteGroupIncidentFilterChip={onDeleteGroupIncidentFilterChip}
377-
incidentFilterIsExpanded={severityFilterExpanded}
378-
onIncidentFiltersSelect={onIncidentFiltersSelect}
379-
setIncidentIsExpanded={setSeverityFilterExpanded}
380-
onIncidentFilterToggle={onSeverityFilterToggle}
381-
dispatch={dispatch}
382-
showToolbarItem={incidentPageFilterTypeSelected?.includes('Severity')}
383-
/>
384-
<IncidentFilterToolbarItem
385-
categoryName="State"
386-
toggleLabel="State filters"
387-
options={stateOptions}
388-
incidentsActiveFilters={incidentsActiveFilters}
389-
onDeleteIncidentFilterChip={onDeleteIncidentFilterChip}
390-
onDeleteGroupIncidentFilterChip={onDeleteGroupIncidentFilterChip}
391-
incidentFilterIsExpanded={stateFilterExpanded}
392-
onIncidentFiltersSelect={onIncidentFiltersSelect}
393-
setIncidentIsExpanded={setStateFilterExpanded}
394-
onIncidentFilterToggle={onStateFilterToggle}
395-
dispatch={dispatch}
396-
showToolbarItem={incidentPageFilterTypeSelected?.includes('State')}
397-
/>
398-
<ToolbarItem>
360+
<SelectOption
361+
value="Severity"
362+
isSelected={incidentPageFilterTypeSelected?.includes('Severity')}
363+
>
364+
Severity
365+
</SelectOption>
366+
<SelectOption
367+
value="State"
368+
isSelected={incidentPageFilterTypeSelected?.includes('State')}
369+
>
370+
State
371+
</SelectOption>
372+
</Select>
373+
</ToolbarItem>
374+
<ToolbarItem>
375+
<IncidentFilterToolbarItem
376+
categoryName="Severity"
377+
toggleLabel="Severity filters"
378+
options={severityOptions}
379+
incidentsActiveFilters={incidentsActiveFilters}
380+
onDeleteIncidentFilterChip={onDeleteIncidentFilterChip}
381+
onDeleteGroupIncidentFilterChip={onDeleteGroupIncidentFilterChip}
382+
incidentFilterIsExpanded={severityFilterExpanded}
383+
onIncidentFiltersSelect={onIncidentFiltersSelect}
384+
setIncidentIsExpanded={setSeverityFilterExpanded}
385+
onIncidentFilterToggle={onSeverityFilterToggle}
386+
dispatch={dispatch}
387+
showToolbarItem={incidentPageFilterTypeSelected?.includes('Severity')}
388+
/>
389+
</ToolbarItem>
390+
<ToolbarItem>
391+
<IncidentFilterToolbarItem
392+
categoryName="State"
393+
toggleLabel="State filters"
394+
options={stateOptions}
395+
incidentsActiveFilters={incidentsActiveFilters}
396+
onDeleteIncidentFilterChip={onDeleteIncidentFilterChip}
397+
onDeleteGroupIncidentFilterChip={onDeleteGroupIncidentFilterChip}
398+
incidentFilterIsExpanded={stateFilterExpanded}
399+
onIncidentFiltersSelect={onIncidentFiltersSelect}
400+
setIncidentIsExpanded={setStateFilterExpanded}
401+
onIncidentFilterToggle={onStateFilterToggle}
402+
dispatch={dispatch}
403+
showToolbarItem={incidentPageFilterTypeSelected?.includes('State')}
404+
/>
405+
</ToolbarItem>
406+
</ToolbarGroup>
407+
<ToolbarItem align={{ default: 'alignEnd' }}>
399408
<Select
400409
id="time-range-select"
401410
isOpen={daysFilterIsExpanded}
@@ -421,18 +430,22 @@ const IncidentsPage = () => {
421430
</SelectList>
422431
</Select>
423432
</ToolbarItem>
424-
<ToolbarItem align={{ default: 'alignEnd' }}>
425-
<Button
426-
variant="link"
427-
icon={hideCharts ? <CompressArrowsAltIcon /> : <CompressIcon />}
428-
onClick={() => setHideCharts(!hideCharts)}
429-
>
430-
<span>{hideCharts ? t('Show graph') : t('Hide graph')}</span>
431-
</Button>
432-
</ToolbarItem>
433433
</ToolbarContent>
434434
</Toolbar>
435435
<Stack hasGutter>
436+
<StackItem>
437+
<Flex justifyContent={{ default: 'justifyContentFlexEnd' }}>
438+
<FlexItem>
439+
<Button
440+
variant="link"
441+
icon={hideCharts ? <CompressArrowsAltIcon /> : <CompressIcon />}
442+
onClick={() => setHideCharts(!hideCharts)}
443+
>
444+
<span>{hideCharts ? t('Show graph') : t('Hide graph')}</span>
445+
</Button>
446+
</FlexItem>
447+
</Flex>
448+
</StackItem>
436449
{!hideCharts && (
437450
<>
438451
<StackItem>

0 commit comments

Comments
 (0)