fix: remove signatures as they aren't generated in the code

Signed-off-by: Paul Bastide <[email protected]>

Author: prb112

internal/pkg/archive/archive.go

@@ -144,15 +144,9 @@ func (o *MirrorArchive) addImagesDiff(ctx context.Context, collectedImages []v2a
 			return nil, fmt.Errorf("unable to find blobs corresponding to %s: %w", img.Destination, err)
 		}
 
-		// Handle signature errors - only return error if it's a fatal signature error
-		if sigHandleErr := handleSignatureErrors(img, err); sigHandleErr != nil {
+		if err := handleSignatureErrors(img, err); err != nil {
 			var archiveErr *ArchiveError
-			if errors.As(sigHandleErr, &archiveErr) && archiveErr.ReleaseErr != nil {
-				// For release images, signature errors should not be fatal
-				// Log the error but continue processing
-				o.logger.Warn("signature error for release image %s: %v", img.Destination, archiveErr.ReleaseErr)
-			} else if errors.As(sigHandleErr, &archiveErr) {
-				// For other image types, return the error
+			if errors.As(err, &archiveErr) && archiveErr.ReleaseErr != nil {
 				return nil, archiveErr
 			}
 		}

internal/pkg/cli/release_integration_test.go

@@ -169,7 +169,7 @@ func (suite *TestEnvironmentRelease) runMirror2Disk(t *testing.T) {
 	err := os.MkdirAll(resultFolder, 0755)
 	assert.NoError(t, err, "should not fail creating a temp folder for results")
 
-	ocmirror.SetArgs([]string{"-c", suite.tempFolder + "/isc.yaml", "--v2", "-p", "56001", "--src-tls-verify=false", "--dest-tls-verify=false", "file://" + resultFolder})
+	ocmirror.SetArgs([]string{"-c", suite.tempFolder + "/isc.yaml", "--v2", "-p", "56001", "--src-tls-verify=false", "--dest-tls-verify=false", "--remove-signatures", "file://" + resultFolder})
 	err = ocmirror.Execute()
 	assert.NoError(t, err, "should not fail executing oc-mirror")