Increase default volume-percentage value to 50%

ardaguclu · ardaguclu · commit 1e410d6a4798 · 2025-05-28T11:55:48.000+03:00
Since we are calculating incorrectly, previous value 30% makes sense.
However, after the correction of the behavior, it is likely that there are
many nodes filled with some data. So that, we need to increase the default behavior
to not hurt the usability.
diff --git a/pkg/cli/admin/mustgather/mustgather.go b/pkg/cli/admin/mustgather/mustgather.go
@@ -141,7 +141,7 @@ func NewMustGatherOptions(streams genericiooptions.IOStreams) *MustGatherOptions
 		SourceDir:        "/must-gather/",
 		IOStreams:        streams,
 		Timeout:          10 * time.Minute,
-		VolumePercentage: 30,
+		VolumePercentage: 50,
 	}
 	opts.LogOut = opts.newPrefixWriter(streams.Out, "[must-gather      ] OUT", false, true)
 	opts.RawOut = opts.newPrefixWriter(streams.Out, "", false, false)

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ func NewMustGatherOptions(streams genericiooptions.IOStreams) *MustGatherOptions`
`141`	`141`	`SourceDir: "/must-gather/",`
`142`	`142`	`IOStreams: streams,`
`143`	`143`	`Timeout: 10 * time.Minute,`
`144`		`- VolumePercentage: 30,`
	`144`	`+ VolumePercentage: 50,`
`145`	`145`	`}`
`146`	`146`	`opts.LogOut = opts.newPrefixWriter(streams.Out, "[must-gather ] OUT", false, true)`
`147`	`147`	`opts.RawOut = opts.newPrefixWriter(streams.Out, "", false, false)`