must-gather: Call queue.Done at the right time

Currently defer queue.Done(pod) is called in a worker thread loop,
which means that the pod is marked as done when the whole worker thread
exits and not in that pod processing loop iteration.

This is now fixed and the pod is marked as processed as soon as it is
actually processed.

Author: tchap

pkg/cli/admin/mustgather/mustgather.go

@@ -695,10 +695,14 @@ func (o *MustGatherOptions) Run() error {
 				if quit {
 					return
 				}
-				defer queue.Done(pod)
-				if err := o.processNextWorkItem(ns.Name, pod.(*corev1.Pod)); err != nil {
-					errCh <- err
-				}
+				func() {
+					// Make sure queue.Done is called inside the current iteration,
+					// not just when the whole worker thread exits.
+					defer queue.Done(pod)
+					if err := o.processNextWorkItem(ctx, ns.Name, pod); err != nil {
+						errCh <- err
+					}
+				}()
 			}
 		}()
 	}