oc adm groups sync: Use client.Unbind

This is a bit nicer than client.Close, it's a polite quit.

Author: tchap

pkg/cli/admin/groups/sync/prune.go

@@ -168,7 +168,13 @@ func (o *PruneOptions) Run() error {
 	if err != nil {
 		return err
 	}
-	defer ldapClient.Close()
+	defer func() {
+		// Unbind does polite quit and closes the connection.
+		// But when it fails, we need to ensure the connection is closed for sure.
+		if err := ldapClient.Unbind(); err != nil {
+			_ = ldapClient.Close()
+		}
+	}()
 
 	pruneBuilder, err := buildPruneBuilder(ldapClient, o.Config)
 	if err != nil {

pkg/cli/admin/groups/sync/sync.go

@@ -366,7 +366,13 @@ func (o *SyncOptions) Run() error {
 	if err != nil {
 		return err
 	}
-	defer ldapClient.Close()
+	defer func() {
+		// Unbind does polite quit and closes the connection.
+		// But when it fails, we need to ensure the connection is closed for sure.
+		if err := ldapClient.Unbind(); err != nil {
+			_ = ldapClient.Close()
+		}
+	}()
 
 	errorHandler := o.CreateErrorHandler()