OTA-1581: Promote oc adm upgrade status to general availability (#2063)

* OTA-1581: Promote `oc adm upgrade status` to general availability

- Stop gating the command on an env variable presence
- Hide the mock input flag

* Update pkg/cli/admin/upgrade/status/status.go

Co-authored-by: Hongkai Liu <[email protected]>

---------

Co-authored-by: Hongkai Liu <[email protected]>

Author: petr-muller

pkg/cli/admin/upgrade/status/status.go

@@ -59,11 +59,9 @@ func New(f kcmdutil.Factory, streams genericiooptions.IOStreams) *cobra.Command
 	}
 
 	flags := cmd.Flags()
-	// TODO: We can remove these flags once the idea about `oc adm upgrade status` stabilizes and the command
-	//       is promoted out of the OC_ENABLE_CMD_UPGRADE_STATUS feature gate
-	flags.StringVar(&o.mockData.cvPath, "mock-clusterversion", "", "Path to a YAML ClusterVersion object to use for testing (will be removed later). Files in the same directory with the same name and suffixes -co.yaml, -mcp.yaml, -mc.yaml, and -node.yaml are required.")
+	flags.StringVar(&o.mockData.cvPath, "mock-clusterversion", "", "Path to a YAML ClusterVersion object to use for testing. Files in the same directory with the same name and suffixes -co.yaml, -mcp.yaml, -mc.yaml, and -node.yaml are required.")
 	flags.StringVar(&o.detailedOutput, "details", "none", fmt.Sprintf("Show detailed output in selected section. One of: %s", strings.Join(detailedOutputAllValues, ", ")))
-
+	flags.MarkHidden("mock-clusterversion")
 	return cmd
 }
 

pkg/cli/admin/upgrade/upgrade.go

@@ -115,10 +115,8 @@ func New(f kcmdutil.Factory, streams genericiooptions.IOStreams) *cobra.Command
 	flags.BoolVar(&o.AllowNotRecommended, "allow-not-recommended", o.AllowNotRecommended, "Allows upgrade to a version when it is supported but not recommended for updates.")
 
 	cmd.AddCommand(channel.New(f, streams))
+	cmd.AddCommand(status.New(f, streams))
 
-	if kcmdutil.FeatureGate("OC_ENABLE_CMD_UPGRADE_STATUS").IsEnabled() {
-		cmd.AddCommand(status.New(f, streams))
-	}
 	if kcmdutil.FeatureGate("OC_ENABLE_CMD_UPGRADE_ROLLBACK").IsEnabled() {
 		cmd.AddCommand(rollback.New(f, streams))
 	}