Skip to content

[release-4.17] OCPBUGS-42182: Fixing -o flag in command example #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-42182: Fixing -o flag in command example #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cli/admin/nodeimage/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ var (
cluster release.

A nodes-config.yaml config file must be created to provide the required
initial configuration for the selected nodes.
initial configuration for the selected nodes.
Alternatively, to support simpler configurations for adding just a single
node, it's also possible to use a set of flags to configure the host. In
such case the '--mac-address' is the only mandatory flag - while all the
others will be optional (note: any eventual configuration file present
others will be optional (note: any eventual configuration file present
will be ignored).
`)

Expand All @@ -87,7 +87,7 @@ var (
oc adm node-image create --dir=/tmp/assets

# Specify a custom image name
oc adm node-image create --o=my-node.iso
oc adm node-image create -o=my-node.iso

# Create an ISO to add a single node without using the configuration file
oc adm node-image create --mac-address=00:d8:e7:c7:4b:bb
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/admin/nodeimage/nodeimage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
func NewCmdNodeImage(f kcmdutil.Factory, streams genericiooptions.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Use: "node-image",
Short: "Add nodes to an existing cluster.",
Short: "Add nodes to an existing cluster",
Long: templates.LongDesc(`
The subcommands allow you to create an ISO image to be used for adding the desired
nodes to an OpenShift cluster, and also to monitor the process.
Expand Down