Skip to content

[release-4.20] OCPBUGS-65481: pkg/cli/admin/upgrade: Tighten force warnings #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

[release-4.20] OCPBUGS-65481: pkg/cli/admin/upgrade: Tighten force warnings #2140

merged 1 commit into from
Nov 18, 2025
+12 −6

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 11, 2025

This is an automated cherry-pick of #2125

/assign sdodson

/cherrypick release-4.19 release-4.18

@wking
pkg/cli/admin/upgrade: Tighten force warnings
c792deb 
Catching the --help and stderr warnings for --force up with the recent
openshift/api@b618d5bd8c (config/v1/types_cluster_version: Tighten
force and rollback warnings, 2025-10-18, openshift/api#2539) wording.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2025
Merged
@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-63311 has been cloned as Jira Issue OCPBUGS-65481. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-65481: pkg/cli/admin/upgrade: Tighten force warnings

In response to this:

This is an automated cherry-pick of #2125

/assign sdodson

/cherrypick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-63311: pkg/cli/admin/upgrade: Tighten force warnings [release-4.20] OCPBUGS-65481: pkg/cli/admin/upgrade: Tighten force warnings Nov 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-65481, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-63311 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-63311 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2125

/assign sdodson

/cherrypick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Nov 11, 2025

/lgtm
/approve
/label backport-risk-assessed
/assign @wking

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 11, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security c792deb link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Nov 18, 2025

/approved
/verified by @sdodson

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@sdodson: This PR has been marked as verified by @sdodson.

In response to this:

/approved
/verified by @sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson merged commit 0963a01 into openshift:release-4.20 Nov 18, 2025
14 of 16 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65481: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-65481 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

In response to this:

This is an automated cherry-pick of #2125

/assign sdodson

/cherrypick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 18, 2025

@openshift-cherrypick-robot: new pull request created: #2146

In response to this:

This is an automated cherry-pick of #2125

/assign sdodson

/cherrypick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2025
Open
@sdodson
Copy link
Member

sdodson commented Nov 18, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@sdodson: Jira Issue Verification Checks: Jira Issue OCPBUGS-65481
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65481 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 19, 2025

Fix included in accepted release 4.20.0-0.nightly-2025-11-19-072441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiajliu jiajliu Awaiting requested review from jiajliu

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sdodson sdodson

@wking wking

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@pamoedom pamoedom

@wangke19 wangke19

@mhanss mhanss

@bmanzari bmanzari

Labels

backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.