You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+15-10Lines changed: 15 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -15,7 +15,11 @@ Issue:
15
15
<!--- Add a link to the Bugzilla, Jira, or GitHub issue, if applicable. --->
16
16
17
17
Link to docs preview:
18
-
<!--- Add direct link(s) to the exact page(s) with updated content from the preview build. -->
18
+
<!--- Add direct link(s) to the exact page(s) with updated content from the preview build. --->
19
+
20
+
QE review:
21
+
-[ ] QE has approved this change.
22
+
<!--- QE approval is required to merge a PR except for changes that do not impact the meaning of the docs. --->
19
23
20
24
<!-- NOTE:
21
25
Automatic preview functionality is currently only available for some branches. For PRs that update the rendered build in any way against branches that do not create an automated preview:
@@ -25,18 +29,19 @@ Automatic preview functionality is currently only available for some branches. F
25
29
Additional information:
26
30
<!--- Optional: Include additional context or expand the description here.--->
27
31
28
-
29
-
30
32
<!--- Next steps after opening your PR:
31
33
32
-
* Ask for peer review from the OpenShift docs team:
33
-
- For Red Hat associates: Ping @peer-review-squad requesting a review in the #forum-docs-review channel (CoreOS Slack workspace) and provide the following information:
34
-
* A link to the PR.
35
-
* The size of the PR that the GitHub bot assigns (ex: XS, S, M, L, XL).
36
-
* If there is urgency or a deadline for the review.
34
+
* Ask for review from the OpenShift docs team:
37
35
- For community authors: Request a review by tagging @openshift/team-documentation in a GitHub comment.
38
-
39
-
Slack is the quickest and preferred way to request a review.
36
+
- For Red Hat associates:
37
+
* For normal peer requests, add a comment that contains this text: /label peer-review-needed
38
+
* For normal merge review requests, add a comment that contains this text: /label merge-review-needed
39
+
* For urgent peer review requests, ping @peer-review-squad requesting a review in the #forum-docs-review channel (CoreOS Slack workspace) and provide the following information:
40
+
* A link to the PR.
41
+
* The size of the PR that the GitHub bot assigns (ex: XS, S, M, L, XL).
42
+
* Details about how the PR is urgent.
43
+
* For urgent merge requests, ping @merge-review-squad in the #forum-docs-review channel (CoreOS Slack workspace).
44
+
* Except for changes that do not impact the meaning of the content, QE review is required before content is merged.
40
45
41
46
* IMPORTANT:
42
47
- All documentation changes must be verified by a QE team associate before merging.
0 commit comments