Skip to content

Commit 108d29a

Browse files
authored
Merge pull request #44953 from johnwilkins/ipi-remove-ifdef-product-version
BZ 2004210: Removes ifeval with product-version variable.
2 parents e992d46 + 940a49c commit 108d29a

6 files changed

+4
-65
lines changed

installing/installing_bare_metal_ipi/ipi-install-prerequisites.adoc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,10 @@ ifdef::openshift-origin[. One provisioner node with {op-system-first} installed.
1212
ifndef::openshift-origin[. One provisioner node with {op-system-base-full} 8.x installed. The provisioning node can be removed after installation.]
1313
. Three control plane nodes.
1414
. Baseboard Management Controller (BMC) access to each node.
15-
ifeval::[{product-version} > 4.5]
1615
. At least one network:
1716
.. One required routable network
1817
.. One optional network for provisioning nodes; and,
1918
.. One optional management network.
20-
endif::[]
21-
ifeval::[{product-version} < 4.6]
22-
. At least two networks:
23-
.. One required routable network
24-
.. One required network for provisioning nodes; and,
25-
.. One optional management network.
26-
endif::[]
2719

2820
Before starting an installer-provisioned installation of {product-title}, ensure the hardware environment meets the following requirements.
2921

modules/install-ibm-cloud-setting-up-ibm-cloud-infrastructure.adoc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@ The following table provides an example of fully qualified domain names. The API
109109
| Usage | Host Name | IP
110110
| API | api.<cluster_name>.<domain> | <ip>
111111
| Ingress LB (apps) | *.apps.<cluster_name>.<domain> | <ip>
112-
ifeval::[{product-version} <= 4.5]
113-
| Nameserver | ns1.<cluster_name>.<domain> | <ip>
114-
endif::[]
115112
| Provisioner node | provisioner.<cluster_name>.<domain> | <ip>
116113
| Master-0 | openshift-master-0.<cluster_name>.<domain> | <ip>
117114
| Master-1 | openshift-master-1.<cluster_name>.<domain> | <ip>

modules/ipi-install-additional-install-config-parameters.adoc

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,7 @@ networking:
4747
- cidr:
4848
----
4949
|
50-
|The public CIDR (Classless Inter-Domain Routing) of the external network. For example, `10.0.0.0/24`
51-
ifdef::upstream[]
52-
ifeval::[{product-version} >= 4.5]
53-
or `2620:52:0:1302::/64`
54-
endif::[]
55-
endif::[]
56-
.
50+
|The public CIDR (Classless Inter-Domain Routing) of the external network. For example, `10.0.0.0/24`.
5751

5852
a|
5953
----
@@ -206,4 +200,4 @@ The `hosts` parameter is a list of separate bare metal assets used to build the
206200
|
207201
| Set this optional parameter to configure the network interface of a host. See "(Optional) Configuring host network interfaces in the `install-config.yaml` file" for additional details.
208202

209-
|===
203+
|===

modules/ipi-install-configuring-the-install-config-file.adoc

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ baseDomain: <domain>
2222
metadata:
2323
name: <cluster-name>
2424
networking:
25-
machineNetwork:
25+
machineNetwork:
2626
- cidr: <public-cidr>
2727
networkType: OVNKubernetes
2828
compute:
@@ -110,7 +110,6 @@ $ cp install-config.yaml ~/clusterconfigs
110110
$ ipmitool -I lanplus -U <user> -P <password> -H <management-server-ip> power off
111111
----
112112

113-
ifeval::[{product-version} >= 4.6]
114113
. Remove old bootstrap resources if any are left over from a previous deployment attempt.
115114
+
116115
[source,terminal]
@@ -125,20 +124,3 @@ do
125124
sudo virsh pool-undefine $i;
126125
done
127126
----
128-
129-
endif::[]
130-
ifeval::[{product-version} < 4.6]
131-
. Remove old bootstrap resources if any are left over from a previous deployment attempt.
132-
+
133-
[source,terminal]
134-
----
135-
for i in $(sudo virsh list | tail -n +3 | grep bootstrap | awk {'print $2'});
136-
do
137-
sudo virsh destroy $i;
138-
sudo virsh undefine $i;
139-
sudo virsh vol-delete $i --pool default;
140-
sudo virsh vol-delete $i.ign --pool default;
141-
done
142-
----
143-
144-
endif::[]

modules/ipi-install-creating-the-openshift-manifests.adoc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,3 @@ INFO Consuming Install Config from target directory
1818
WARNING Making control-plane schedulable by setting MastersSchedulable to true for Scheduler cluster settings
1919
WARNING Discarding the OpenShift Manifest that was provided in the target directory because its dependencies are dirty and it needs to be regenerated
2020
----
21-
22-
ifeval::[{product-version} <= 4.3]
23-
. Copy the `metal3-config.yaml` file to the `clusterconfigs/openshift` directory.
24-
+
25-
[source,terminal]
26-
----
27-
$ cp ~/metal3-config.yaml clusterconfigs/openshift/99_metal3-config.yaml
28-
----
29-
endif::[]

modules/ipi-install-troubleshooting-cleaning-up-previous-installations.adoc

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ In the event of a previous failed deployment, remove the artifacts from the fail
1717
$ ipmitool -I lanplus -U <user> -P <password> -H <management-server-ip> power off
1818
----
1919

20-
ifeval::[{product-version} >= 4.6]
2120
. Remove all old bootstrap resources if any are left over from a previous deployment attempt:
2221
+
2322
[source,terminal]
@@ -33,25 +32,9 @@ do
3332
done
3433
----
3534

36-
endif::[]
37-
ifeval::[{product-version} < 4.6]
38-
. Remove all old bootstrap resources if any are left over from a previous deployment attempt:
39-
+
40-
[source,terminal]
41-
----
42-
for i in $(sudo virsh list | tail -n +3 | grep bootstrap | awk {'print $2'});
43-
do
44-
sudo virsh destroy $i;
45-
sudo virsh undefine $i;
46-
sudo virsh vol-delete $i --pool default;
47-
sudo virsh vol-delete $i.ign --pool default;
48-
done
49-
----
50-
endif::[]
51-
5235
. Remove the following from the `clusterconfigs` directory to prevent Terraform from failing:
5336
+
5437
[source,terminal]
5538
----
5639
$ rm -rf ~/clusterconfigs/auth ~/clusterconfigs/terraform* ~/clusterconfigs/tls ~/clusterconfigs/metadata.json
57-
----
40+
----

0 commit comments

Comments
 (0)