Skip to content

Commit 12cfd58

Browse files
authored
Merge pull request #45224 from emarcusRH/OCPRHV-609
OCPRHV-609 grammatical updates to instructions
2 parents 6333f72 + 9d4e3a0 commit 12cfd58

File tree

1 file changed

+18
-15
lines changed

1 file changed

+18
-15
lines changed

modules/machineset-yaml-rhv.adoc

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ metadata:
2323
namespace: openshift-machine-api
2424
spec:
2525
replicas: <number_of_replicas> <4>
26-
selector: <5>
26+
Selector: <5>
2727
matchLabels:
2828
machine.openshift.io/cluster-api-cluster: <infrastructure_id> <1>
2929
machine.openshift.io/cluster-api-machineset: <infrastructure_id>-<role> <3>
@@ -52,16 +52,17 @@ spec:
5252
guaranteed_memory_mb: <memory_size> <14>
5353
os_disk: <15>
5454
size_gb: <disk_size> <16>
55-
network_interfaces: <17>
56-
vnic_profile_id: <vnic_profile_id> <18>
55+
storage_domain_id: <storage_domain_UUID> <17>
56+
network_interfaces: <18>
57+
vnic_profile_id: <vnic_profile_id> <19>
5758
credentialsSecret:
58-
name: ovirt-credentials <19>
59+
name: ovirt-credentials <20>
5960
kind: OvirtMachineProviderSpec
60-
type: <workload_type> <20>
61-
auto_pinning_policy: <auto_pinning_policy> <21>
62-
hugepages: <hugepages> <22>
61+
type: <workload_type> <21>
62+
auto_pinning_policy: <auto_pinning_policy> <22>
63+
hugepages: <hugepages> <23>
6364
affinityGroupsNames:
64-
- compute <23>
65+
- compute <24>
6566
userDataSecret:
6667
name: worker-user-data
6768
----
@@ -113,16 +114,18 @@ If you are using a version earlier than {rh-virtualization} 4.4.8, see link:http
113114

114115
<16> Optional: Specify the size of the bootable disk in GiB.
115116

116-
<17> Optional: List of the network interfaces of the VM. If you include this parameter, {product-title} discards all network interfaces from the template and creates new ones.
117+
<17> Optional: Specify the UUID of the storage domain for the compute node's disks. If none is provided, the compute node is created on the same storage domain as the control nodes. (default)
117118

118-
<18> Optional: Specify the vNIC profile ID.
119+
<18> Optional: List of the network interfaces of the VM. If you include this parameter, {product-title} discards all network interfaces from the template and creates new ones.
119120

120-
<19> Specify the name of the secret that holds the {rh-virtualization} credentials.
121+
<19> Optional: Specify the vNIC profile ID.
121122

122-
<20> Optional: Specify the workload type for which the instance is optimized. This value affects the `{rh-virtualization} VM` parameter. Supported values: `desktop`, `server` (default), `high_performance`. `high_performance` improves performance on the VM, but there are limitations. For example, you cannot access the VM with a graphical console. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Configuring_High_Performance_Virtual_Machines_Templates_and_Pools[Configuring High Performance Virtual Machines, Templates, and Pools] in the _Virtual Machine Management Guide_.
123-
<21> Optional: AutoPinningPolicy defines the policy that automatically sets CPU and NUMA settings, including pinning to the host for this instance. Supported values: `none`, `resize_and_pin`. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Setting_NUMA_Nodes[Setting NUMA Nodes] in the _Virtual Machine Management Guide_.
124-
<22> Optional: Hugepages is the size in KiB for defining hugepages in a VM. Supported values: `2048` or `1048576`. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Configuring_Huge_Pages[Configuring Huge Pages] in the _Virtual Machine Management Guide_.
125-
<23> Optional: A list of affinity group names that should be applied to the VMs. The affinity groups must exist in oVirt.
123+
<20> Specify the name of the secret object that holds the {rh-virtualization} credentials.
124+
125+
<21> Optional: Specify the workload type for which the instance is optimized. This value affects the `{rh-virtualization} VM` parameter. Supported values: `desktop`, `server` (default), `high_performance`. `high_performance` improves performance on the VM. Limitations exist, for example, you cannot access the VM with a graphical console. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Configuring_High_Performance_Virtual_Machines_Templates_and_Pools[Configuring High Performance Virtual Machines, Templates, and Pools] in the _Virtual Machine Management Guide_.
126+
<22> Optional: AutoPinningPolicy defines the policy that automatically sets CPU and NUMA settings, including pinning to the host for this instance. Supported values: `none`, `resize_and_pin`. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Setting_NUMA_Nodes[Setting NUMA Nodes] in the _Virtual Machine Management Guide_.
127+
<23> Optional: Hugepages is the size in KiB for defining hugepages in a VM. Supported values: `2048` or `1048576`. For more information, see link:https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/virtual_machine_management_guide/index#Configuring_Huge_Pages[Configuring Huge Pages] in the _Virtual Machine Management Guide_.
128+
<24> Optional: A list of affinity group names to be applied to the VMs. The affinity groups must exist in oVirt.
126129

127130
[NOTE]
128131
====

0 commit comments

Comments
 (0)