Skip to content

Commit 2298ab0

Browse files
authored
Merge pull request #30702 from adellape/osdk_rbac
2 parents 00f76f5 + 6c69be4 commit 2298ab0

File tree

1 file changed

+13
-30
lines changed

1 file changed

+13
-30
lines changed

modules/osdk-prepare-supported-images.adoc

Lines changed: 13 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ endif::[]
1212
ifeval::["{context}" == "osdk-ansible-tutorial"]
1313
:ansible:
1414
:type: Ansible
15+
:type_lc: ansible
1516
endif::[]
1617
ifeval::["{context}" == "osdk-helm-tutorial"]
1718
:helm:
1819
:type: Helm
20+
:type_lc: helm
1921
endif::[]
2022

2123
[id="osdk-prepare-supported-images_{context}"]
@@ -41,35 +43,21 @@ FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
4143
----
4244

4345
. Depending on the Go project version, your Dockerfile might contain a `USER 65532:65532` or `USER nonroot:nonroot` directive. In either case, remove the line, as it is not required by the supported runner image.
44-
45-
. In the `config/default/manager_auth_proxy_patch.yaml` file, change the `image` value from:
46-
+
47-
[source,terminal]
48-
----
49-
gcr.io/kubebuilder/kube-rbac-proxy:<tag>
50-
----
51-
+
52-
to use the supported image:
53-
+
54-
[source,terminal,subs="attributes+"]
55-
----
56-
registry.redhat.io/openshift4/ose-kube-rbac-proxy:v{product-version}
57-
----
5846
endif::[]
5947

60-
ifdef::ansible[]
61-
* Update the project root-level Dockerfile to use supported images. Change the default builder image reference from:
48+
ifdef::ansible,helm[]
49+
. Update the project root-level Dockerfile to use supported images. Change the default builder image reference from:
6250
+
6351
[source,terminal,subs="attributes+"]
6452
----
65-
FROM quay.io/operator-framework/ansible-operator:{osdk_ver}
53+
FROM quay.io/operator-framework/{type_lc}-operator:{osdk_ver}
6654
----
6755
+
6856
to:
6957
+
7058
[source,terminal,subs="attributes+"]
7159
----
72-
FROM registry.redhat.io/openshift4/ose-ansible-operator:v{product-version}
60+
FROM registry.redhat.io/openshift4/ose-{type_lc}-operator:v{product-version}
7361
----
7462
+
7563
[IMPORTANT]
@@ -78,26 +66,19 @@ Use the builder image version that matches your Operator SDK version. Failure to
7866
====
7967
endif::[]
8068

81-
ifdef::helm[]
82-
* Update the project root-level Dockerfile to use supported images. Change the default builder image reference from:
69+
. In the `config/default/manager_auth_proxy_patch.yaml` file, change the `image` value from:
8370
+
84-
[source,terminal,subs="attributes+"]
71+
[source,terminal]
8572
----
86-
FROM quay.io/operator-framework/helm-operator:{osdk_ver}
73+
gcr.io/kubebuilder/kube-rbac-proxy:<tag>
8774
----
8875
+
89-
to:
76+
to use the supported image:
9077
+
9178
[source,terminal,subs="attributes+"]
9279
----
93-
FROM registry.redhat.io/openshift4/ose-helm-operator:v{product-version}
80+
registry.redhat.io/openshift4/ose-kube-rbac-proxy:v{product-version}
9481
----
95-
+
96-
[IMPORTANT]
97-
====
98-
Use the builder image version that matches your Operator SDK version. Failure to do so can result in problems due to project layout, or _scaffolding_, differences, particularly when mixing newer upstream versions of the Operator SDK with downstream {product-title} builder images.
99-
====
100-
endif::[]
10182

10283
:!osdk_ver:
10384
ifeval::["{context}" == "osdk-golang-tutorial"]
@@ -107,8 +88,10 @@ endif::[]
10788
ifeval::["{context}" == "osdk-ansible-tutorial"]
10889
:!ansible:
10990
:!type:
91+
:!type_lc:
11092
endif::[]
11193
ifeval::["{context}" == "osdk-helm-tutorial"]
11294
:!helm:
11395
:!type:
96+
:!type_lc:
11497
endif::[]

0 commit comments

Comments
 (0)