Skip to content

Commit 33cf5ae

Browse files
committed
Add explicit ref: "master" to various sample builds
As I understand it, `master` is the implicit default on the API side. But there's been an effort to use `main` or other names, xref https://sfconservancy.org/news/2020/jun/23/gitbranchname/ The client will clone the default branch, but this can cause problems around things like webhooks because the build API object is still watching for the implicit `master`. Make this explicit, in the hopes that people know to change it to `main` when they need to.
1 parent eb673db commit 33cf5ae

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

modules/builds-chaining-builds.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ spec:
3535
source:
3636
git:
3737
uri: https://github.com/openshift/openshift-jee-sample.git
38+
ref: "master"
3839
strategy:
3940
sourceStrategy:
4041
from:

modules/builds-define-build-inputs.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ The following example of a source definition includes multiple input types and a
5555
source:
5656
git:
5757
uri: https://github.com/openshift/ruby-hello-world.git <1>
58+
ref: "master"
5859
images:
5960
- from:
6061
kind: ImageStreamTag

modules/builds-image-source.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Image inputs are specified in the `source` definition of the `BuildConfig`:
1616
source:
1717
git:
1818
uri: https://github.com/openshift/ruby-hello-world.git
19+
ref: "master"
1920
images: <1>
2021
- from: <2>
2122
kind: ImageStreamTag

modules/builds-using-proxy-git-cloning.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Your source URI must use the HTTP or HTTPS protocol for this to work.
1717
source:
1818
git:
1919
uri: "https://github.com/openshift/ruby-hello-world"
20+
ref: "master"
2021
httpProxy: http://proxy.example.com
2122
httpsProxy: https://proxy.example.com
2223
noProxy: somedomain.com, otherdomain.com

0 commit comments

Comments
 (0)