Skip to content

Commit 4fd3567

Browse files
authored
Merge pull request #58237 from rh-max/srvls-overriding-probes
[SRVCOM-2210] Add notes on restrictions for overriding probes
2 parents f71bf43 + 33684e5 commit 4fd3567

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

serverless/eventing/tuning/overriding-config-eventing.adoc

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,22 @@ include::_attributes/common-attributes.adoc[]
66

77
toc::[]
88

9-
You can override the default configurations for some specific deployments by modifying the `deployments` spec in the `KnativeEventing` custom resource (CR).
9+
You can override the default configurations for some specific deployments by modifying the `deployments` spec in the `KnativeEventing` custom resource (CR). Currently, overriding default configuration settings is supported for the `eventing-controller`, `eventing-webhook`, and `imc-controller` fields, as well as for the `readiness` and `liveness` fields for probes.
10+
11+
[IMPORTANT]
12+
====
13+
The `replicas` spec cannot override the number of replicas for deployments that use the Horizontal Pod Autoscaler (HPA), and does not work for the `eventing-webhook` deployment.
14+
====
15+
16+
[NOTE]
17+
====
18+
You can only override probes that are defined in the deployment by default.
19+
20+
All Knative Serving deployments define a readiness and a liveness probe by default, with these exceptions:
21+
22+
* `net-kourier-controller` and `3scale-kourier-gateway` only define a readiness probe.
23+
* `net-istio-controller` and `net-istio-webhook` define no probes.
24+
====
1025

1126
include::modules/knative-eventing-CR-system-deployments.adoc[leveloffset=+1]
1227

serverless/knative-serving/config-applications/overriding-config-serving.adoc

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,18 @@ include::_attributes/common-attributes.adoc[]
66

77
You can override the default configurations for some specific deployments by modifying the `deployments` spec in the `KnativeServing` custom resources (CRs).
88

9+
[NOTE]
10+
====
11+
You can only override probes that are defined in the deployment by default.
12+
13+
All Knative Serving deployments define a readiness and a liveness probe by default, with these exceptions:
14+
15+
* `net-kourier-controller` and `3scale-kourier-gateway` only define a readiness probe.
16+
* `net-istio-controller` and `net-istio-webhook` define no probes.
17+
====
18+
919
include::modules/knative-serving-CR-system-deployments.adoc[leveloffset=+1]
1020

1121
[role="_additional-resources"]
1222
.Additional resources
13-
* link:https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#probe-v1-core[Probe configuration section of the Kubernetes API documentation]
23+
* link:https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#probe-v1-core[Probe configuration section of the Kubernetes API documentation]

0 commit comments

Comments
 (0)