Skip to content

Commit 6e90398

Browse files
committed
1980340 Add resize to ovirt CSI driver
Implemented SME comments. Implemented QE commens. Implemented Peer review comments.
1 parent 179eee4 commit 6e90398

File tree

6 files changed

+44
-28
lines changed

6 files changed

+44
-28
lines changed

modules/dynamic-provisioning-aws-definition.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,20 @@ parameters:
2525
See the
2626
link:http://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html[AWS documentation]
2727
for valid Amazon Resource Name (ARN) values.
28-
<2> (optional) Only for *io1* volumes. I/O operations per second per GiB.
28+
<2> Optional: Only for *io1* volumes. I/O operations per second per GiB.
2929
The AWS volume plug-in multiplies this with the size of the requested
3030
volume to compute IOPS of the volume. The value cap is 20,000 IOPS, which
3131
is the maximum supported by AWS. See the
3232
link:http://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html[AWS documentation]
3333
for further details.
34-
<3> (optional) Denotes whether to encrypt the EBS volume. Valid values
34+
<3> Optional: Denotes whether to encrypt the EBS volume. Valid values
3535
are `true` or `false`.
36-
<4> (optional) The full ARN of the key to use when encrypting the volume.
36+
<4> Optional: The full ARN of the key to use when encrypting the volume.
3737
If none is supplied, but `encypted` is set to `true`, then AWS generates a
3838
key. See the
3939
link:http://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html[AWS documentation]
4040
for a valid ARN value.
41-
<5> (optional) File system that is created on dynamically provisioned
41+
<5> Optional: File system that is created on dynamically provisioned
4242
volumes. This value is copied to the `fsType` field of dynamically
4343
provisioned persistent volumes and the file system is created when the
4444
volume is mounted for the first time. The default value is `ext4`.

modules/dynamic-provisioning-ceph-rbd-definition.adoc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,18 @@ parameters:
2525
imageFormat: "2" <9>
2626
----
2727
<1> (required) A comma-delimited list of Ceph monitors.
28-
<2> (optional) Ceph client ID that is capable of creating images in the
28+
<2> Optional: Ceph client ID that is capable of creating images in the
2929
pool. Default is `admin`.
30-
<3> (required) Secret Name for `adminId`. The provided secret must have
30+
<3> (required) Secret Name for `adminId`. The provided secret must have
3131
type `kubernetes.io/rbd`.
32-
<4> (optional) The namespace for `adminSecret`. Default is `default`.
33-
<5> (optional) Ceph RBD pool. Default is `rbd`.
34-
<6> (optional) Ceph client ID that is used to map the Ceph RBD image.
32+
<4> Optional: The namespace for `adminSecret`. Default is `default`.
33+
<5> Optional: Ceph RBD pool. Default is `rbd`.
34+
<6> Optional: Ceph client ID that is used to map the Ceph RBD image.
3535
Default is the same as `adminId`.
36-
<7> (required) The name of Ceph Secret for `userId` to map Ceph RBD image.
37-
It must exist in the same namespace as PVCs.
38-
<8> (optional) File system that is created on dynamically provisioned
39-
volumes. This value is copied to the `fsType` field of dynamically
40-
provisioned persistent volumes and the file system is created when the
36+
<7> (required) The name of Ceph Secret for `userId` to map Ceph RBD image.
37+
It must exist in the same namespace as PVCs.
38+
<8> Optional: File system that is created on dynamically provisioned
39+
volumes. This value is copied to the `fsType` field of dynamically
40+
provisioned persistent volumes and the file system is created when the
4141
volume is mounted for the first time. The default value is `ext4`.
42-
<9> (optional) Ceph RBD image format. The default value is `2`.
42+
<9> Optional: Ceph RBD image format. The default value is `2`.
Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,44 @@
11
// Module included in the following assemblies:
22
//
33
// * storage/container_storage_interface/persistent-storage-csi-ovirt.adoc
4+
// * post_installation_configuration/storage-configuration.adoc
45

56
[id="ovirt-csi-driver-storage-class_{context}"]
6-
= oVirt CSI driver storage class
7+
ifeval::["{context}" == "post-install-storage-configuration"]
8+
= {rh-virtualization-first} object definition
9+
endif::[]
10+
ifeval::["{context}" == "persistent-storage-csi-ovirt"]
11+
= {rh-virtualization-first} CSI driver storage class
12+
endif::[]
13+
714

815
{product-title} creates a default object of type `StorageClass` named `ovirt-csi-sc` which is used for creating dynamically provisioned persistent volumes.
916

1017
To create additional storage classes for different configurations, create and save a file with the `StorageClass` object described by the following sample YAML:
1118

19+
.ovirt-storageclass.yaml
1220
[source,yaml]
1321
----
1422
apiVersion: storage.k8s.io/v1
1523
kind: StorageClass
1624
metadata:
17-
name: <storage-class-name> <1>
25+
name: <storage_class_name> <1>
1826
annotations:
19-
storageclass.kubernetes.io/is-default-class: "false" <2>
27+
storageclass.kubernetes.io/is-default-class: "<boolean>" <2>
2028
provisioner: csi.ovirt.org
29+
allowVolumeExpansion: <boolean> <3>
30+
reclaimPolicy: Delete <4>
31+
volumeBindingMode: Immediate <5>
2132
parameters:
22-
storageDomainName: <rhv-storage-domain-name> <3>
23-
thinProvisioning: "true" <4>
24-
csi.storage.k8s.io/fstype: ext4 <5>
33+
storageDomainName: <rhv-storage-domain-name> <6>
34+
thinProvisioning: "<boolean>" <7>
35+
csi.storage.k8s.io/fstype: <file_system_type> <8>
2536
----
2637
<1> Name of the storage class.
2738
<2> Set to `false` if the storage class is the default storage class in the cluster. If set to `true`, the existing default storage class must be edited and set to `false`.
28-
<3> {rh-virtualization} storage domain name to use.
29-
<4> Disk must be thin provisioned.
30-
<5> File system type to be created.
39+
<3> `true` enables dynamic volume expansion, `false` prevents it. `true` is recommended.
40+
<4> Dynamically provisioned persistent volumes of this storage class are created with this reclaim policy. This default policy is `Delete`.
41+
<5> Indicates how to provision and bind `PersistentVolumeClaims`. When not set, `VolumeBindingImmediate` is used. This field is only applied by servers that enable the `VolumeScheduling` feature.
42+
<6> The {rh-virtualization} storage domain name to use.
43+
<7> If `true`, the disk is thin provisioned. If `false`, the disk is preallocated. Thin provisioning is recommended.
44+
<8> Optional: File system type to be created. Possible values: `ext4` (default) or `xfs`.

modules/persistent-storage-csi-drivers-supported.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ The following table describes the CSI drivers that are installed with {product-t
1818

1919
|AWS EBS (Tech Preview) | ✅ | - | ✅
2020
|Google Cloud Platform (GCP) persistent disk (PD) (Tech Preview)| ✅ | - | ✅
21-
|Microsoft Azure Disk (Tech Preview) | ✅ | ✅ | ✅
21+
|Microsoft Azure Disk (Tech Preview) | ✅ | ✅ | ✅
2222
|OpenStack Cinder | ✅ | ✅ | ✅
2323
|OpenStack Manila | ✅ | ✅ | ✅
24-
|Red Hat Virtualization (oVirt) | - | - | -
24+
|Red Hat Virtualization (oVirt) | - | - |
2525
|VMware vSphere (Tech Preview) | - | - | -
2626
|===
2727

modules/persistent-storage-rhv.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ When you create a `PersistentVolumeClaim` (PVC) object, {product-title} provisio
1111

1212
.Procedure
1313

14-
* If you are using the we console to dynamically create a persistent volume on {rh-virtualization}:
14+
* If you are using the web console to dynamically create a persistent volume on {rh-virtualization}:
1515
+
1616
. In the {product-title} console, click *Storage* -> *Persistent Volume Claims*.
1717
. In the persistent volume claims overview, click *Create Persistent Volume Claim*.
@@ -45,7 +45,7 @@ spec:
4545
- ReadWriteOnce
4646
resources:
4747
requests:
48-
storage: <volume size> <2>
48+
storage: <volume size> <2>
4949
volumeMode: <volume mode> <3>
5050
----
5151
<1> Name of the required storage class.

post_installation_configuration/storage-configuration.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ include::modules/dynamic-provisioning-gce-definition.adoc[leveloffset=+2]
5353

5454
include::modules/dynamic-provisioning-vsphere-definition.adoc[leveloffset=+2]
5555

56+
include::modules/ovirt-csi-driver-storage-class.adoc[leveloffset=+2]
57+
5658
include::modules/dynamic-provisioning-change-default-class.adoc[leveloffset=+1]
5759

5860
[id="post-install-optimizing-storage"]

0 commit comments

Comments
 (0)