Skip to content

Commit 77c9dd1

Browse files
authored
Merge pull request #47393 from apinnick/CNV-19657-clean-up-oadp
CNV-19657: Clean up CNV backup/restore
2 parents 759127c + 1d417df commit 77c9dd1

15 files changed

+19
-173
lines changed

_topic_maps/_topic_map.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3379,14 +3379,8 @@ Topics:
33793379
- Name: Backup and restore
33803380
Dir: backup_restore
33813381
Topics:
3382-
- Name: Backup and restore overview
3382+
- Name: Backing up and restoring virtual machines
33833383
File: virt-backup-restore-overview
3384-
- Name: Installing and configuring OADP
3385-
File: virt-installing-configuring-oadp
3386-
- Name: Backing up virtual machines
3387-
File: virt-backing-up-vms
3388-
- Name: Restoring virtual machines
3389-
File: virt-restoring-vms
33903384
# - Name: Collecting OKD Virtualization data for community report
33913385
# File: virt-collecting-virt-data
33923386
# Distros: openshift-origin

modules/oadp-about-backup-snapshot-locations-secrets.adoc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: CONCEPT
1110
[id="oadp-about-backup-snapshot-locations_{context}"]
@@ -25,12 +24,7 @@ Velero backs up {product-title} resources, Kubernetes objects, and internal imag
2524
[discrete]
2625
== Snapshot locations
2726

28-
ifdef::installing-oadp-aws,installing-oadp-azure,installing-oadp-gcp,installing-oadp-mcg,installing-oadp-ocs[]
2927
If you use your cloud provider's native snapshot API to back up persistent volumes, you must specify the cloud provider as the snapshot location.
30-
endif::[]
31-
ifdef::virt-installing-configuring-oadp[]
32-
If you use your cloud provider's native snapshot API to back up virtual machine disks, you must specify the cloud provider as the snapshot location.
33-
endif::[]
3428

3529
If you use Container Storage Interface (CSI) snapshots, you do not need to specify a snapshot location because you will create a `VolumeSnapshotClass` CR to register the CSI driver.
3630

modules/oadp-creating-default-secret.adoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: PROCEDURE
1110
[id="oadp-creating-default-secret_{context}"]
@@ -16,7 +15,7 @@ You create a default `Secret` if your backup and snapshot locations use the same
1615
ifdef::installing-oadp-aws,installing-oadp-azure,installing-oadp-gcp,installing-oadp-mcg[]
1716
The default name of the `Secret` is `{credentials}`.
1817
endif::[]
19-
ifdef::installing-oadp-ocs,virt-installing-configuring-oadp[]
18+
ifdef::installing-oadp-ocs[]
2019
The default name of the `Secret` is `{credentials}`, unless your backup storage provider has a default plug-in, such as `aws`, `azure`, or `gcp`. In that case, the default name is specified in the provider-specific OADP installation procedure.
2120
endif::[]
2221

modules/oadp-creating-restore-cr.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Module included in the following assemblies:
22
//
33
// * backup_and_restore/application_backup_and_restore/backing_up_and_restoring/restoring-applications.adoc
4-
// * virt/backup_restore/virt-backing-up-vms.adoc
54

65
:_content-type: PROCEDURE
76
[id="oadp-creating-restore-cr_{context}"]

modules/oadp-creating-restore-hooks.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Module included in the following assemblies:
22
//
33
// * backup_and_restore/application_backup_and_restore/backing_up_and_restoring/restoring-applications.adoc
4-
// * virt/backup_restore/virt-restoring-vms.adoc
54

65
:_content-type: PROCEDURE
76
[id="oadp-creating-restore-hooks_{context}"]

modules/oadp-enabling-csi-dpa.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: PROCEDURE
1110
[id="oadp-enabling-csi-dpa_{context}"]

modules/oadp-installing-dpa.adoc

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: PROCEDURE
1110
[id="oadp-installing-dpa_{context}"]
@@ -235,6 +234,7 @@ spec:
235234
configuration:
236235
velero:
237236
defaultPlugins:
237+
- kubevirt <.>
238238
- gcp <.>
239239
- csi <.>
240240
- openshift <.>
@@ -251,6 +251,7 @@ spec:
251251
bucket: <bucket_name> <.>
252252
prefix: <prefix> <.>
253253
----
254+
<.> Optional: The `kubevirt` plug-in is used with {VirtProductName}.
254255
<.> Specify the default plug-in for the backup provider, for example, `gcp`, if appropriate.
255256
<.> Specify the `csi` default plug-in if you use CSI snapshots to back up PVs. The `csi` plug-in uses the link:https://{velero-domain}/docs/main/csi/[Velero CSI beta snapshot APIs]. You do not need to configure a snapshot location.
256257
<.> The `openshift` plug-in is mandatory.
@@ -260,49 +261,6 @@ spec:
260261
<.> Specify a bucket as the backup storage location. If the bucket is not a dedicated bucket for Velero backups, you must specify a prefix.
261262
<.> Specify a prefix for Velero backups, for example, `velero`, if the bucket is used for multiple purposes.
262263
endif::[]
263-
ifdef::virt-installing-configuring-oadp[]
264-
+
265-
[source,yaml,subs="attributes+"]
266-
----
267-
apiVersion: oadp.openshift.io/v1alpha1
268-
kind: DataProtectionApplication
269-
metadata:
270-
name: <dpa_sample>
271-
namespace: openshift-adp
272-
spec:
273-
configuration:
274-
velero:
275-
defaultPlugins:
276-
- kubevirt <.>
277-
- gcp <.>
278-
- csi <.>
279-
- openshift <.>
280-
featureFlags:
281-
- EnableCSI <.>
282-
restic:
283-
enable: true <.>
284-
backupLocations:
285-
- velero:
286-
provider: {provider} <.>
287-
default: true
288-
credential:
289-
key: cloud
290-
name: <default_secret> <.>
291-
objectStorage:
292-
bucket: <bucket_name> <.>
293-
prefix: <prefix> <.>
294-
----
295-
<.> The `kubevirt` plug-in is mandatory for {VirtProductName}.
296-
<.> Specify the plug-in for the backup provider, for example, `gcp`, if it exists.
297-
<.> The `csi` plug-in is mandatory for backing up PVs with CSI snapshots. The `csi` plug-in uses the link:https://{velero-domain}/docs/main/csi/[Velero CSI beta snapshot APIs]. You do not need to configure a snapshot location.
298-
<.> The `openshift` plug-in is mandatory.
299-
<.> The `EnableCSI` feature flag is mandatory for CSI snapshots.
300-
<.> Set to `false` if you want to disable the Restic installation. Restic deploys a daemon set, which means that each worker node has `Restic` pods running. You configure Restic for backups by adding `spec.defaultVolumesToRestic: true` to the `Backup` CR.
301-
<.> Specify the backup provider.
302-
<.> If you use a default plug-in for the backup provider, you must specify the correct default name for the `Secret`, for example, `cloud-credentials-gcp`. If you specify a custom name, the custom name is used for the backup location. If you do not specify a `Secret` name, the default name is used.
303-
<.> Specify a bucket as the backup storage location. If the bucket is not a dedicated bucket for Velero backups, you must specify a prefix.
304-
<.> Specify a prefix for Velero backups, for example, `velero`, if the bucket is used for multiple purposes.
305-
endif::[]
306264

307265
. Click *Create*.
308266
. Verify the installation by viewing the OADP resources:

modules/oadp-installing-operator.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: PROCEDURE
1110
[id="oadp-installing-operator_{context}"]

modules/oadp-secrets-for-different-credentials.adoc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
66
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
77
// * backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
8-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
98

109
:_content-type: PROCEDURE
1110
[id="oadp-secrets-for-different-credentials_{context}"]
@@ -72,7 +71,7 @@ spec:
7271
profile: "volumeSnapshot"
7372
----
7473
endif::[]
75-
ifdef::installing-oadp-azure,installing-oadp-gcp,installing-oadp-ocs,installing-oadp-mcg,virt-installing-configuring-oadp[]
74+
ifdef::installing-oadp-azure,installing-oadp-gcp,installing-oadp-ocs,installing-oadp-mcg[]
7675
= Creating secrets for different credentials
7776

7877
If your backup and snapshot locations use different credentials, you must create two `Secret` objects:
@@ -198,7 +197,7 @@ spec:
198197
----
199198
<1> Backup location `Secret` with custom name.
200199
endif::[]
201-
ifdef::installing-oadp-ocs,virt-installing-configuring-oadp[]
200+
ifdef::installing-oadp-ocs[]
202201
+
203202
[source,yaml,subs="attributes+"]
204203
----

modules/oadp-self-signed-certificate.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Module included in the following assemblies:
22
//
33
// * backup_and_restore/application_backup_and_restore/configuring-oadp.adoc
4-
// * virt/backup_restore/virt-installing-configuring-oadp.adoc
54

65
:_content-type: PROCEDURE
76
[id="oadp-self-signed-certificate_{context}"]

0 commit comments

Comments
 (0)