Commit 7bd7b73
committed
modules/nodes-descheduler-profiles: Clarify RemovePodsHavingTooManyRestarts as sum
Pods don't restart, although they can be deleted and replaced with new
pods. Containers within pods restart. Previously it was unclear
whether the threshold was "one of my containers has more than 100
restarts" or "summing over all of my containers, there have been more
than 100 restarts". This commit makes it clear that it's the latter,
based on the backing code [1]. For example, a pod with three
containers, each with 50 restarts, would be eligible for descheduling.
I'm also not super exited about the "removes pods" language, since as
the docs point out elsewhere, some pods are not descheduled (e.g. pods
in the openshift-* and kube-system namespaces). I'd prefer language
like "Considers pods whose containers...". But that's orthogonal
enough that I'm leaving it out for this commit.
[1]: https://github.com/kubernetes-sigs/descheduler/blob/bfd5feaf60a202cecafcf2d30cf171a138c04885/pkg/descheduler/strategies/toomanyrestarts.go#L110-L1221 parent d69e827 commit 7bd7b73
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
0 commit comments