Merge pull request #43943 from mburke5678/BZ-1955683-diskDiB

BZ-1955683:Windows MachineSet diskDiB change disk size but doesn't affect the partition size

Author: mburke5678

modules/windows-machineset-vsphere.adoc

@@ -39,24 +39,24 @@ spec:
           apiVersion: vsphereprovider.openshift.io/v1beta1
           credentialsSecret:
             name: vsphere-cloud-credentials
-          diskGiB: 128
+          diskGiB: 128 <5>
           kind: VSphereMachineProviderSpec
           memoryMiB: 16384
           network:
             devices:
-            - networkName: "<vm_network_name>" <5>
+            - networkName: "<vm_network_name>" <6>
           numCPUs: 4
           numCoresPerSocket: 1
           snapshot: ""
-          template: <windows_vm_template_name> <6>
+          template: <windows_vm_template_name> <7>
           userDataSecret:
-            name: windows-user-data <7>
+            name: windows-user-data <8>
           workspace:
-             datacenter: <vcenter_datacenter_name> <8>
-             datastore: <vcenter_datastore_name> <9>
-             folder: <vcenter_vm_folder_path> <10>
-             resourcePool: <vsphere_resource_pool> <11>
-             server: <vcenter_server_ip> <12>
+             datacenter: <vcenter_datacenter_name> <9>
+             datastore: <vcenter_datastore_name> <10>
+             folder: <vcenter_vm_folder_path> <11>
+             resourcePool: <vsphere_resource_pool> <12>
+             server: <vcenter_server_ip> <13>
 ----
 <1> Specify the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. You can obtain the infrastructure ID by running the following command:
 +
@@ -67,17 +67,24 @@ $ oc get -o jsonpath='{.status.infrastructureName}{"\n"}' infrastructure cluster
 <2> Specify the Windows machine set name. The machine set name cannot be more than 9 characters long, due to the way machine names are generated in vSphere.
 <3> Configure the machine set as a Windows machine.
 <4> Configure the Windows node as a compute machine.
-<5> Specify the vSphere VM network to deploy the machine set to. This VM network must be where other Linux compute machines reside in the cluster.
-<6> Specify the full path of the Windows vSphere VM template to use, such as `golden-images/windows-server-template`. The name must be unique.
+<5> Specify the size of the vSphere Virtual Machine Disk (VMDK). 
++
+[NOTE]
+====
+This parameter does not set the size of the Windows partition. You can resize the Windows partition by using the `unattend.xml` file or by creating the vSphere Windows virtual machine (VM) golden image with the required disk size.
+====
++
+<6> Specify the vSphere VM network to deploy the machine set to. This VM network must be where other Linux compute machines reside in the cluster.
+<7> Specify the full path of the Windows vSphere VM template to use, such as `golden-images/windows-server-template`. The name must be unique.
 +
 [IMPORTANT]
 ====
 Do not specify the original VM template. The VM template must remain off and must be cloned for new Windows machines. Starting the VM template configures the VM template as a VM on the platform, which prevents it from being used as a template that machine sets can apply configurations to.
 ====
 +
-<7> The `windows-user-data` is created by the WMCO when the first Windows machine is configured. After that, the `windows-user-data` is available for all subsequent machine sets to consume.
-<8> Specify the vCenter Datacenter to deploy the machine set on.
-<9> Specify the vCenter Datastore to deploy the machine set on.
-<10> Specify the path to the vSphere VM folder in vCenter, such as `/dc1/vm/user-inst-5ddjd`.
-<11> Optional: Specify the vSphere resource pool for your Windows VMs.
-<12> Specify the vCenter server IP or fully qualified domain name.
+<8> The `windows-user-data` is created by the WMCO when the first Windows machine is configured. After that, the `windows-user-data` is available for all subsequent machine sets to consume.
+<9> Specify the vCenter Datacenter to deploy the machine set on.
+<10> Specify the vCenter Datastore to deploy the machine set on.
+<11> Specify the path to the vSphere VM folder in vCenter, such as `/dc1/vm/user-inst-5ddjd`.
+<12> Optional: Specify the vSphere resource pool for your Windows VMs.
+<13> Specify the vCenter server IP or fully qualified domain name.