Skip to content

Commit a473af7

Browse files
authored
Merge pull request #38797 from rh-max/srvls-sinkbinding-improvements
SRVKE-930: Sinkbinding page improvements
2 parents cddf18d + 659994a commit a473af7

File tree

3 files changed

+11
-22
lines changed

3 files changed

+11
-22
lines changed

modules/serverless-sinkbinding-kn.adoc

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,6 @@ The following procedure requires you to create YAML files.
1515
If you change the names of the YAML files from those used in the examples, you must ensure that you also update the corresponding CLI commands.
1616
====
1717

18-
[IMPORTANT]
19-
====
20-
Before developers can use sink binding, cluster administrators must label the namespace that will be configured for sink binding with `bindings.knative.dev/include:"true"`:
21-
22-
[source,terminal]
23-
----
24-
$ oc label namespace <namespace> bindings.knative.dev/include=true
25-
----
26-
====
27-
2818
.Procedure
2919

3020
. To check that sink binding is set up correctly, create a Knative event display service, or event sink, that dumps incoming messages to its log:
@@ -64,7 +54,7 @@ spec:
6454
restartPolicy: Never
6555
containers:
6656
- name: single-heartbeat
67-
image: quay.io/openshift-knative/knative-eventing-sources-heartbeats:latest
57+
image: quay.io/openshift-knative/heartbeats:latest
6858
args:
6959
- --period=1
7060
env:

modules/serverless-sinkbinding-reference.adoc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,3 +204,12 @@ This sets the `K_CE_OVERRIDES` environment variable on the `subject`:
204204
----
205205
{ "extensions": { "extra": "this is an extra attribute", "additional": "42" } }
206206
----
207+
208+
== The include label
209+
210+
To use a SinkBinding, you need to do assign the `bindings.knative.dev/include: "true"` label to either the resource or the namespace. If the resource definition does not include the label, a cluster administrator can attach it to the namespace by running:
211+
212+
[source,terminal]
213+
----
214+
$ oc label namespace <namespace> bindings.knative.dev/include=true
215+
----

modules/serverless-sinkbinding-yaml.adoc

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,6 @@ The following procedure requires you to create YAML files.
1818
If you change the names of the YAML files from those used in the examples, you must ensure that you also update the corresponding CLI commands.
1919
====
2020

21-
[IMPORTANT]
22-
====
23-
Before developers can use a SinkBinding, cluster administrators must label the namespace that will be configured in the SinkBinding with `bindings.knative.dev/include:"true"`:
24-
25-
[source,terminal]
26-
----
27-
$ oc label namespace <namespace> bindings.knative.dev/include=true
28-
----
29-
====
30-
3121
.Procedure
3222

3323
. To check that sink binding is set up correctly, create a Knative event display service, or event sink, that dumps incoming messages to its log.
@@ -108,7 +98,7 @@ spec:
10898
restartPolicy: Never
10999
containers:
110100
- name: single-heartbeat
111-
image: quay.io/openshift-knative/knative-eventing-sources-heartbeats:latest
101+
image: quay.io/openshift-knative/heartbeats:latest
112102
args:
113103
- --period=1
114104
env:

0 commit comments

Comments
 (0)