You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<!--- Specify the version or versions of OpenShift your PR applies to. -->
7
10
8
-
<!-- Version examples:
9
-
* PR applies to all versions after a specific version (e.g. 4.8): 4.8+
10
-
* PR applies to the in-development version (e.g. 4.12) and future versions: 4.12+
11
-
* PR applies only to a specific single version (e.g. 4.10): 4.10
12
-
* PR applies to multiple specific versions (e.g. 4.8-4.10): 4.8, 4.9, 4.10 --->
13
-
14
11
Issue:
15
12
<!--- Add a link to the Bugzilla, Jira, or GitHub issue, if applicable. --->
16
13
@@ -21,49 +18,8 @@ QE review:
21
18
-[ ] QE has approved this change.
22
19
<!--- QE approval is required to merge a PR except for changes that do not impact the meaning of the docs. --->
23
20
24
-
<!-- NOTE:
25
-
Automatic preview functionality is currently only available for some branches. For PRs that update the rendered build in any way against branches that do not create an automated preview:
26
-
* OpenShift documentation team members (core and aligned) must include a link to a locally generated preview.
27
-
* External contributors can request a generated preview from the OpenShift documentation team. --->
28
-
29
21
Additional information:
30
22
<!--- Optional: Include additional context or expand the description here.--->
31
23
32
-
<!--- Next steps after opening your PR:
33
-
34
-
* Ask for review from the OpenShift docs team:
35
-
- For community authors: Request a review by tagging @openshift/team-documentation in a GitHub comment.
36
-
- For Red Hat associates:
37
-
* For normal peer requests, add a comment that contains this text: /label peer-review-needed
38
-
* For normal merge review requests, add a comment that contains this text: /label merge-review-needed
39
-
* For urgent peer review requests, ping @peer-review-squad requesting a review in the #forum-docs-review channel (CoreOS Slack workspace) and provide the following information:
40
-
* A link to the PR.
41
-
* The size of the PR that the GitHub bot assigns (ex: XS, S, M, L, XL).
42
-
* Details about how the PR is urgent.
43
-
* For urgent merge requests, ping @merge-review-squad in the #forum-docs-review channel (CoreOS Slack workspace).
44
-
* Except for changes that do not impact the meaning of the content, QE review is required before content is merged.
45
-
46
-
* IMPORTANT:
47
-
- All documentation changes must be verified by a QE team associate before merging.
48
-
- Squash to one commit before submitting your PR for peer review.
49
-
50
-
* For more information about verifying your content, see:
Copy file name to clipboardExpand all lines: contributing_to_docs/create_or_edit_content.adoc
+25-7Lines changed: 25 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -46,13 +46,9 @@ with the remote repository.
46
46
[NOTE]
47
47
====
48
48
Because most changes in this repository must be committed to the `main`
49
-
branch (which is the main for the 4.x stream), the following process always
50
-
uses `main` as the name of the source
49
+
branch, the following process uses `main` as the name of the source
51
50
branch. If you must use another branch as the source for your change, make
52
51
sure that you consistently use that branch name instead of `main`.
53
-
54
-
When adding or updating content for version 3.11, you should create a feature
55
-
branch against enterprise-3.11 to submit your changes.
56
52
====
57
53
58
54
1. From your local repository, make sure you have the `main` branch checked
@@ -157,6 +153,7 @@ your GitHub repository:
157
153
$ git push origin <feature_branch>
158
154
----
159
155
156
+
[id="submit-PR"]
160
157
== Submit PR to merge your work
161
158
162
159
When you have pushed your changes to your GitHub account, you can submit a PR to
@@ -168,11 +165,32 @@ any further changes that are required, and finally merge your work.
168
165
your feature branch that includes all of your work.
169
166
2. Click on *Pull Request* to submit the PR against the `main` branch of the
170
167
`openshift-docs` repository.
171
-
3. If you know which product versions your change applies to, include a comment
168
+
3. Fill out the information requested on the template.
169
+
** If you know which product versions your change applies to, include a comment
172
170
that specifies the minimum version that the change applies to. The docs team
173
171
maintains these branches for all active and future distros and your PR will be
174
172
applied to one or more of these branches.
175
-
4. Tag the documentation team with @openshift/team-documentation (if you are a part of the OpenShift organization. If not, tag @vikram-redhat).
173
+
*** PR applies to all versions after a specific version (e.g. 4.8): 4.8+
174
+
*** PR applies to the in-development version (e.g. 4.12) and future versions: 4.12+
175
+
*** PR applies only to a specific single version (e.g. 4.10): 4.10
176
+
*** PR applies to multiple specific versions (e.g. 4.8-4.10): 4.8, 4.9, 4.10
177
+
** Provide a link to the preview. Automatic preview functionality is currently only available for some branches. For PRs that update the rendered build in any way against branches that do not create an automated preview:
178
+
*** OpenShift documentation team members (core and aligned) must include a link to a locally generated preview.
179
+
*** External contributors can request a generated preview from the OpenShift documentation team.
180
+
** All documentation changes that impact the meaning of the docs must be verified by a QE team associate before merging.
181
+
** Provide any other information about the change that the docs team might need to understand it.
182
+
4. Make sure that you squash to one commit before submitting your PR.
183
+
5. Ask for review from the OpenShift docs team:
184
+
** For community authors: Request a review by tagging @openshift/team-documentation or @kalexand-rh in a GitHub comment.
185
+
** For Red Hat associates:
186
+
*** For normal peer requests, add a comment that contains this text: /label peer-review-needed
187
+
*** For normal merge review requests, add a comment that contains this text: /label merge-review-needed
188
+
*** For urgent peer review requests, ping @peer-review-squad requesting a review in the #forum-docs-review channel (CoreOS Slack workspace) and provide the following information:
189
+
**** A link to the PR.
190
+
**** The size of the PR that the GitHub bot assigns (ex: XS, S, M, L, XL).
191
+
**** Details about how the PR is urgent.
192
+
*** For urgent merge requests, ping @merge-review-squad in the #forum-docs-review channel (CoreOS Slack workspace).
193
+
*** Except for changes that do not impact the meaning of the content, QE review is required before content is merged.
0 commit comments