Skip to content

Commit a8903e2

Browse files
authored
Merge pull request #96405 from openshift-cherrypick-robot/cherry-pick-96323-to-enterprise-4.19
[enterprise-4.19] Fixing a few double words
2 parents bfb4597 + c38d5f8 commit a8903e2

File tree

3 files changed

+21
-23
lines changed

3 files changed

+21
-23
lines changed

hardware_enablement/kmm-release-notes.adoc

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ toc::[]
3636
* In this release, you now have the option to configure the Kernel Module Management (KMM) module to not load an out-of-tree kernel driver and use the in-tree driver instead, and run only the device plugin. For more information, see xref:../hardware_enablement/kmm-kernel-module-management.adoc#kmm-using-intree-modules_kernel-module-management-operator[Using in-tree modules with the device plugin].
3737

3838
// TELCODOCS-2304
39-
* In this release, KMM configurations are now persistent after cluster and KMM Operator upgrades and redeployments of KMM.
39+
* In this release, KMM configurations are now persistent after cluster and KMM Operator upgrades and redeployments of KMM.
4040
+
4141
In earlier releases, a cluster or KMM upgrade, or any other action, such as upgrading a non-default configuration like the firmware path that redeploys KMM, could create the need to reconfigure KMM. In this release, KMM configurations now remain persistent regardless of any of such actions.
4242
+
@@ -46,22 +46,22 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
4646
* Improvements have been added to KMM so that GPU Operator vendors do not need to replicate KMM functionality in their code, but instead use KMM as is. This change greatly improves Operators' code size, tests, and reliability.
4747

4848
// MGMT-18966
49-
* In this release, KMM no longer uses HTTP(S) direct requests to check if a kmod image exists. Instead, CRI-O is used internally to check for the images. This mitigates the need to access container image registries directly from HTTP(S) requests and manually handle tasks such as reading `/etc/containers/registries.conf` for mirroring configuration, accessing the image cluster resource for TLS configuration, mounting the CAs from the node, and maintaining your own cache in Hub & Spoke.
49+
* In this release, KMM no longer uses HTTP(S) direct requests to check if a kmod image exists. Instead, CRI-O is used internally to check for the images. This mitigates the need to access container image registries directly from HTTP(S) requests and manually handle tasks such as reading `/etc/containers/registries.conf` for mirroring configuration, accessing the image cluster resource for TLS configuration, mounting the CAs from the node, and maintaining your own cache in Hub & Spoke.
5050

5151
// MGMT-19383
52-
* The KMM and KMM-hub Operators have been assigned the "Meets Best Practices" label in the
52+
* The KMM and KMM-hub Operators have been assigned the "Meets Best Practices" label in the
5353
https://catalog.redhat.com/search?searchType=software[Red Hat Catalog].
5454

5555
// MGMT20613
56-
* You can now install KMM on compute nodes, if needed. Previously, it was not possible to deploy workloads on the control-plane nodes. Because the compute nodes do not have the `node-role.kubernetes.io/control-plane` or `node-role.kubernetes.io/master` labels, the Kernel Module Management Operator might need further configurations. An internal code change has resolved this issue.
56+
* You can now install KMM on compute nodes, if needed. Previously, it was not possible to deploy workloads on the control-plane nodes. Because the compute nodes do not have the `node-role.kubernetes.io/control-plane` or `node-role.kubernetes.io/master` labels, the Kernel Module Management Operator might need further configurations. An internal code change has resolved this issue.
5757

5858
// MGMT-20249
5959
* In this release, the heartbeat filter for the NMC reconciler has been updated to filter the following events on nodes:
6060

6161
** `node.spec`
6262
** `metadata.labels`
6363
** `status.nodeInfo`
64-
** `status.conditions[]` (`NodeReady` only) and still filtering heartbeats
64+
** `status.conditions[]` (`NodeReady` only) and still filtering heartbeats
6565

6666
=== Notable technical changes
6767
// TELCODOCS-2343
@@ -82,23 +82,23 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
8282

8383
** *Consequence*: Two services were generated for the same deployment. One generated by `controller-gen` and added to the bundle manifests and the other that the OLM created.
8484

85-
** *Fix*: Make OLM find an already existing service called `webhook-service` in the cluster because the deployment is called `webhook`.
85+
** *Fix*: Make OLM find an already existing service called `webhook-service` in the cluster because the deployment is called `webhook`.
8686

8787
** *Result*: A second service is no longer created.
8888

89-
// MGMT-20892
89+
// MGMT-20892
9090
* Using `imageRepoSecret` object in conjunction with DTK as the image stream results in `authorization required` error.
9191

92-
** *Cause*: On the Kernel Module Management (KMM) Operator, when you set `imageRepoSecret` object in the KMM module, and the build's resulting container image is defined to be stored in the cluster's internal registry, the build fails to push the final image and generate an `authorization required` error.
92+
** *Cause*: On the Kernel Module Management (KMM) Operator, when you set `imageRepoSecret` object in the KMM module, and the build's resulting container image is defined to be stored in the cluster's internal registry, the build fails to push the final image and generate an `authorization required` error.
9393

94-
** *Consequence*: The KMM Operator does not work as expected.
94+
** *Consequence*: The KMM Operator does not work as expected.
9595

96-
** *Fix*: When the `imageRepoSecret` object is user-defined, it is used as both a pull and push secret by the build process. To support using the cluster's internal registry, you must add the authorization token for that registry to the `imageRepoSecret` object. You can obtain the token from the "build" service account of the KMM module's namespace.
96+
** *Fix*: When the `imageRepoSecret` object is user-defined, it is used as both a pull and push secret by the build process. To support using the cluster's internal registry, you must add the authorization token for that registry to the `imageRepoSecret` object. You can obtain the token from the "build" service account of the KMM module's namespace.
9797

98-
** *Result*: The KMM Operator works as expected.
98+
** *Result*: The KMM Operator works as expected.
9999

100100
// MGMT-16797
101-
* Creating or deleting the image or creating an MCM module does not load the module on the spoke.
101+
* Creating or deleting the image or creating an MCM module does not load the module on the spoke.
102102

103103
** *Cause*: In a hub and spoke environment, when creating or deleting the image in registry, or when creating a `ManagedClusterModule` (MCM), the module on the spoke cluster is not loaded.
104104

@@ -120,7 +120,7 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
120120
** *Result:* You can now use private registries when doing in-cluster builds.
121121

122122
// MGMT-19897
123-
* KMM worker pod is orphaned when deleting a module with a container image that can not be pulled.
123+
* KMM worker pod is orphaned when deleting a module with a container image that can not be pulled.
124124

125125
** *Cause*: A Kernel Module Management (KMM) Operator worker pod is orphaned when deleting a module with a container image that can not be pulled.
126126

@@ -164,7 +164,7 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
164164
** *Result:* The NMC controller only gets real events and filters out node heartbeats.
165165

166166
// MGMT-20286
167-
* NMC status contains toleration values, even though there are no tolerations in the `NMC.spec` or in the module.
167+
* NMC status contains toleration values, even though there are no tolerations in the `NMC.spec` or in the module.
168168

169169
** *Cause*: The Node Machine Configuration (NMC) status contains toleration values, even though there are no tolerations in the `NMC.spec` or in the module.
170170

@@ -175,7 +175,7 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
175175
** *Result:* The NMC status only contains the module's tolerations.
176176

177177
// MGMT-20725
178-
* The KMM Operator version 2.4 fails to start properly and cannot list the `\modulebuildsignconfigs\` resource.
178+
* The KMM Operator version 2.4 fails to start properly and cannot list the `\modulebuildsignconfigs\` resource.
179179

180180
** *Cause*: On the Kernel Module Management (KMM) Operator, when the Operator is installed using Red Hat Konflux, it does not start properly because the log files contain errors.
181181

@@ -225,7 +225,7 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
225225

226226
** *Consequence*: Resources are not used appropriately or as intended.
227227

228-
** *Fix*: The `CreateOrPatch` MIC API receives a slice of `ImageSpecs`, as the input is created by going over the the target nodes and adding their images to the slice, so any duplicate `ImageSpecs`, are now filtered out.
228+
** *Fix*: The `CreateOrPatch` MIC API receives a slice of `ImageSpecs`, as the input is created by going over the target nodes and adding their images to the slice, so any duplicate `ImageSpecs`, are now filtered out.
229229

230230
** *Result:* The KMM Operator works as expected.
231231

@@ -305,7 +305,7 @@ For more information, see xref:../hardware_enablement/kmm-kernel-module-manageme
305305

306306
** *Fix*: Introduce an alerting mechanism for this potential behavior and for awareness when working with modules.
307307

308-
** *Result:* Not yet available.
308+
** *Result:* Not yet available.
309309

310310
[id="kmm-2-4-1-RN"]
311311
== Release notes for Kernel Module Management Operator 2.4.1

modules/creating-manifest-file-customized-br-ex-bridge.adoc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ As an alternative to using the `configure-ovs.sh` shell script to set a `br-ex`
2323

2424
[IMPORTANT]
2525
====
26-
After creating the `NodeNetworkConfigurationPolicy` CR, copy content from the NMState configuration file that was created during cluster installation into the NNCP CR. An incomplete NNCP CR file means that the the network policy described in the file cannot get applied to nodes in the cluster.
26+
After creating the `NodeNetworkConfigurationPolicy` CR, copy content from the NMState configuration file that was created during cluster installation into the NNCP CR. An incomplete NNCP CR file means that the network policy described in the file cannot get applied to nodes in the cluster.
2727
====
2828

2929
This feature supports the following tasks:
@@ -116,7 +116,7 @@ interfaces:
116116
ipv4:
117117
enabled: true
118118
dhcp: true
119-
auto-route-metric: 48 <6>
119+
auto-route-metric: 48 <6>
120120
ipv6:
121121
enabled: true
122122
dhcp: true
@@ -171,7 +171,7 @@ ifdef::postinstall-bare-metal[]
171171
+
172172
[IMPORTANT]
173173
====
174-
As a post-installation task, you can configure most parameters for a customized `br-ex` bridge that you defined in an existing NNCP CR, except for the primary IP address of the customized `br-ex` bridge.
174+
As a post-installation task, you can configure most parameters for a customized `br-ex` bridge that you defined in an existing NNCP CR, except for the primary IP address of the customized `br-ex` bridge.
175175

176176
If you want to convert your single-stack cluster network to a dual-stack cluster network, you can add or change a secondary IPv6 address in the NNCP CR, but the existing primary IP address cannot be changed.
177177
====
@@ -246,4 +246,3 @@ endif::postinstall-bare-metal[]
246246
ifeval::["{context}" == "bare-metal-postinstallation-configuration"]
247247
:!postinstall-bare-metal:
248248
endif::[]
249-

modules/external-secrets-test-coverage.adoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[id="external-secrets-test-coverage_{context}"]
77
= Testing external secrets provider types
88

9-
The following table shows the the test coverage for each tested external secrets provider type.
9+
The following table shows the test coverage for each tested external secrets provider type.
1010

1111
[cols="1,1,1",options="header"]
1212
|===
@@ -30,4 +30,3 @@ The following table shows the the test coverage for each tested external secrets
3030
| Partially tested
3131
|
3232
|===
33-

0 commit comments

Comments
 (0)