Skip to content

Commit b8e6aa3

Browse files
authored
Merge pull request #41324 from bgaydosrh/CNV-13715
CNV-13715: Online VM Snapshot improvements
2 parents d24e754 + 99019ff commit b8e6aa3

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

modules/virt-creating-vm-snapshot-cli.adoc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,13 @@ $ kubectl wait my-vm my-vmsnapshot --for condition=Ready
6464
+
6565
[NOTE]
6666
====
67-
Online snapshots have a default time deadline of five (`5`) minutes. If the snapshot does not complete successfully in five minutes, the status is set to `failed`. Afterwards, the file system will be thawed and the VM unfrozen but the status remains `failed` until you delete the failed snapshot image.
67+
Online snapshots have a default time deadline of five minutes (`5m`). If the snapshot does not complete successfully in five minutes, the status is set to `failed`. Afterwards, the file system will be thawed and the VM unfrozen but the status remains `failed` until you delete the failed snapshot image.
6868
69-
To change the default time deadline, add the `FailureDeadline` attribute to the VM snapshot spec with the time (in minutes) that you want to specify before the snapshot operation times out.
69+
To change the default time deadline, add the `FailureDeadline` attribute to the VM snapshot spec with the time designated in minutes (`m`) or in seconds (`s`) that you want to specify before the snapshot operation times out.
7070

7171
To set no deadline, you can specify `0`, though this is generally not recommended, as it can result in an unresponsive VM.
72+
73+
If you do not specify a unit of time such as `m` or `s`, the default is seconds (`s`).
7274
====
7375

7476
.Verification

virt/virtual_machines/virtual_disks/virt-managing-vm-snapshots.adoc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ You can create and delete virtual machine (VM) snapshots for VMs, whether the VM
1111
* Red Hat OpenShift Container Storage
1212
* Any other storage provider with the Container Storage Interface (CSI) driver that supports the Kubernetes Volume Snapshot API
1313
14+
Online snapshots have a default time deadline of five minutes (`5m`) that can be changed, if needed.
15+
1416
[IMPORTANT]
1517
====
16-
Online snapshots are not supported for virtual machines that have hot-plugged virtual disks.
18+
Online snapshots are supported for virtual machines that have hot-plugged virtual disks. However, hot-plugged disks that are not in the virtual machine specification are not included in the snapshot.
1719
====
1820

1921
[NOTE]

0 commit comments

Comments
 (0)