Skip to content

Commit bd063c7

Browse files
committed
HCP Workshop: Fixed some command related issues in the docs
1 parent bf54d48 commit bd063c7

6 files changed

+17
-30
lines changed

modules/rosa-hcp-creating-account-wide-sts-roles-and-policies.adoc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@ Before using the {product-title} (ROSA) CLI (`rosa`) to create {hcp-title-first}
2020
2121
.Procedure
2222

23-
* If they do not exist in your AWS account, create the required account-wide STS roles and attach the policies by running the following command:
23+
. If they do not exist in your AWS account, create the required account-wide STS roles and attach the policies by running the following command:
2424
+
2525
[source,terminal]
2626
----
27-
$ rosa create account-roles --hosted-cp --mode auto --yes
27+
$ rosa create account-roles --hosted-cp
2828
----
29-
** Optional: Set your prefix as an environmental variable by running the following command:
29+
30+
. Optional: Set your prefix as an environmental variable by running the following command:
3031
+
3132
[source,terminal]
3233
----

modules/rosa-hcp-sts-creating-a-cluster-cli.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ $ rosa create cluster --private --cluster-name=<cluster_name> \
6767
+
6868
[source,terminal]
6969
----
70-
$ rosa create cluster --cluster-name=<cluster_name> --mode=auto --hosted-cp --operator-roles-prefix=$OPERATOR_ROLES_PREFIX --oidc-config-id=$ODIC_CONFIG --subnet-ids=$SUBNET_IDS
70+
$ rosa create cluster --cluster-name=<cluster_name> --mode=auto --hosted-cp --operator-roles-prefix=$OPERATOR_ROLES_PREFIX --oidc-config-id=$OIDC_CONFIG --subnet-ids=$SUBNET_IDS
7171
----
7272
+
7373
. Check the status of your cluster by running the following command:

modules/rosa-hcp-vpc-subnet-tagging.adoc

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,6 @@ You must tag at least one private subnet and, if applicable, and one public subn
3535
3636
.Procedure
3737

38-
. Verify the tags currently on your subnet by running the following command:
39-
+
40-
[source,terminal]
41-
----
42-
$ aws ec2 describe-tags --filters "Name=resource-id,Values=<subnet-id>"
43-
----
44-
+
45-
.Example output
46-
+
47-
[source,text]
48-
----
49-
TAGS Name <subnet-id> subnet <prefix>-subnet-public1-us-east-1a
50-
----
51-
5238
. Tag your resources in your terminal by running the following commands:
5339
.. For public subnets, run:
5440
+
@@ -65,7 +51,7 @@ $ aws ec2 create-tags --resources <private-subnet-id> --tags Key=kubernetes.io/r
6551

6652
.Verification
6753

68-
. Verify that the tag is correctly applied by running the following command:
54+
* Verify that the tag is correctly applied by running the following command:
6955
+
7056
[source,terminal]
7157
----

modules/rosa-hcp-vpc-terraform.adoc

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ A message confirming the initialization appears when this process completes.
4242
+
4343
[source,terminal]
4444
----
45-
$ terraform plan -out rosa.tfplan -var region=<region> [-var cluster_name=<cluster_name>]
45+
$ terraform plan -out rosa.tfplan -var region=<region>
4646
----
4747

4848
. Apply this plan file to build your VPC by running the following command:
@@ -51,17 +51,15 @@ $ terraform plan -out rosa.tfplan -var region=<region> [-var cluster_name=<clust
5151
----
5252
$ terraform apply rosa.tfplan
5353
----
54-
55-
. Optional: You can capture the values of the Terraform-provisioned private, public, and machinepool subnet IDs as environment variables to use when creating your {hcp-title} cluster by running the following commands:
54+
+
55+
.. Optional: You can capture the values of the Terraform-provisioned private, public, and machinepool subnet IDs as environment variables to use when creating your {hcp-title} cluster by running the following commands:
5656
+
5757
[source,terminal]
5858
----
5959
$ export SUBNET_IDS=$(terraform output -raw cluster-subnets-string)
6060
----
61-
62-
.Verification
63-
64-
* You can verify that the variables were correctly set with the following command:
61+
+
62+
.. Verify that the variables were correctly set with the following command:
6563
+
6664
[source,terminal]
6765
----

modules/rosa-sts-byo-oidc.adoc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ endif::rosa-hcp[]
3535

3636
.Procedure
3737

38-
* To create your OIDC configuration alongside the AWS resources, run the following command:
38+
. To create your OIDC configuration alongside the AWS resources, run the following command:
3939
+
4040
[source,terminal]
4141
----
42-
$ rosa create oidc-config --mode=auto --yes
42+
$ rosa create oidc-config --mode=auto --yes
4343
----
4444
+
4545
This command returns the following information.
@@ -60,13 +60,15 @@ I: Created OIDC provider with ARN 'arn:aws:iam::4540112244:oidc-provider/dvbwgdz
6060
+
6161
When creating your cluster, you must supply the OIDC config ID. The CLI output provides this value for `--mode auto`, otherwise you must determine these values based on `aws` CLI output for `--mode manual`.
6262

63-
** Optional: you can save the OIDC configuration ID as a variable to use later. Run the following command to save the variable:
63+
. Optional: you can save the OIDC configuration ID as a variable to use later. Run the following command to save the variable:
6464
+
65+
--
6566
[source,terminal]
6667
----
6768
$ export OIDC_ID=<oidc_config_id><1>
6869
----
6970
<1> In the example output above, the OIDC configuration ID is 13cdr6b.
71+
--
7072

7173
** View the value of the variable by running the following command:
7274
+

rosa_hcp/rosa-hcp-sts-creating-a-cluster-quickly.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ include::modules/rosa-hcp-vpc-terraform.adoc[leveloffset=+3]
9494
[discrete]
9595
include::modules/rosa-hcp-vpc-manual.adoc[leveloffset=+2]
9696
[discrete]
97-
include::modules/rosa-hcp-vpc-subnet-tagging.adoc[leveloffset=+2]
97+
include::modules/rosa-hcp-vpc-subnet-tagging.adoc[leveloffset=+3]
9898

9999
[role="_additional-resources"]
100100
[id="additional-resources_rosa-hcp-vpc-aws"]

0 commit comments

Comments
 (0)