Merge pull request #97579 from openshift-cherrypick-robot/cherry-pick-96737-to-enterprise-4.19

[enterprise-4.19] OSDOCS-15470-security: Removed unneccessary code blocks for net secur…

Author: xenolinux

installing/installing_aws/ipi/installing-aws-localzone.adoc

@@ -21,13 +21,13 @@ AWS {zone-type} is an infrastructure that place Cloud Resources close to metropo
 +
 [WARNING]
 ====
-If you have an AWS profile stored on your computer, it must not use a temporary session token that you generated while using a multi-factor authentication device. The cluster continues to use your current AWS credentials to create AWS resources for the entire life of the cluster, so you must use key-based, long-term credentials. To generate appropriate keys, see link:https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_access-keys.html[Managing Access Keys for IAM Users] in the AWS documentation. You can supply the keys when you run the installation program.
+If you have an AWS profile stored on your computer, it must not use a temporary session token that you generated while using a multifactor authentication device. The cluster continues to use your current AWS credentials to create AWS resources for the entire life of the cluster, so you must use key-based, long-term credentials. To generate appropriate keys, see link:https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_access-keys.html[Managing Access Keys for IAM Users] in the AWS documentation. You can supply the keys when you run the installation program.
 ====
 * You downloaded the AWS CLI and installed it on your computer. See link:https://docs.aws.amazon.com/cli/latest/userguide/install-bundle.html[Install the AWS CLI Using the Bundled Installer (Linux, macOS, or UNIX)] in the AWS documentation.
 * If you use a firewall, you xref:../../../installing/install_config/configuring-firewall.adoc#configuring-firewall[configured it to allow the sites] that your cluster must access.
 * You noted the region and supported link:https://aws.amazon.com/about-aws/global-infrastructure/localzones/locations[AWS Local Zones locations] to create the network resources in.
 * You read the link:https://aws.amazon.com/about-aws/global-infrastructure/localzones/features/[AWS Local Zones features] in the AWS documentation.
-* You added permissions for creating network resources that support AWS Local Zones to the Identity and Access Management (IAM) user or role. The following example enables a zone group that can provide a user or role access for creating network network resources that support AWS {zone-type}.
+* You added permissions for creating network resources that support AWS Local Zones to the Identity and Access Management (IAM) user or role. The following example enables a zone group that can give a user or role access for creating network resources that support AWS {zone-type}.
 +
 .Example of an additional IAM policy with the `ec2:ModifyAvailabilityZoneGroup` permission attached to an IAM user or role.
 +
@@ -137,22 +137,22 @@ include::modules/install-creating-install-config-aws-edge-zones.adoc[leveloffset
 [id="creating-aws-local-zone-environment-existing_{context}"]
 == Installing a cluster in an existing VPC that has Local Zone subnets
 
-You can install a cluster into an existing Amazon Virtual Private Cloud (VPC) on Amazon Web Services (AWS). The installation program provisions the rest of the required infrastructure, which you can further customize. To customize the installation, modify parameters in the `install-config.yaml` file before you install the cluster.
+You can install a cluster into an existing Amazon Virtual Private Cloud (VPC) on Amazon Web Services (AWS). The installation program provisions the rest of the required infrastructure, which you can further customize. To customize the installation, change parameters in the `install-config.yaml` file before you install the cluster.
 
 Installing a cluster on AWS into an existing VPC requires extending compute nodes to the edge of the Cloud Infrastructure by using AWS {zone-type}.
 
 Local Zone subnets extend regular compute nodes to edge networks. Each edge compute nodes runs a user workload. After you create an Amazon Web Service (AWS) Local Zone environment, and you deploy your cluster, you can use edge compute nodes to create user workloads in Local Zone subnets.
 
 [NOTE]
 ====
-If you want to create private subnets, you must either modify the provided CloudFormation template or create your own template.
+If you want to create private subnets, you must either change the provided CloudFormation template or create your own template.
 ====
 
-You can use a provided CloudFormation template to create network resources. Additionally, you can modify a template to customize your infrastructure or use the information that they contain to create AWS resources according to your company's policies.
+You can use a provided CloudFormation template to create network resources. Additionally, you can change a template to customize your infrastructure or use the information that they contain to create AWS resources according to your company's policies.
 
 [IMPORTANT]
 ====
-The steps for performing an installer-provisioned infrastructure installation are provided for example purposes only. Installing a cluster in an existing VPC requires that you have knowledge of the cloud provider and the installation process of {product-title}. You can use a CloudFormation template to assist you with completing these steps or to help model your own cluster installation. Instead of using the CloudFormation template to create resources, you can decide to use other methods for generating these resources.
+The documentation provides the steps for performing an installer-provisioned infrastructure installation for example purposes only. Installing a cluster in an existing VPC requires that you have knowledge of the cloud provider and the installation process of {product-title}. You can use a CloudFormation template to assist you with completing these steps or to help model your own cluster installation. Instead of using the CloudFormation template to create resources, you can decide to use other methods for generating these resources.
 ====
 
 // Creating a VPC in AWS

modules/cnf-performing-end-to-end-tests-junit-test-output.adoc

@@ -27,11 +27,11 @@ You must create the `junit` folder before running this command.
 ----
 $ podman run -v $(pwd)/:/kubeconfig:Z -v $(pwd)/junit:/junit \
 -e KUBECONFIG=/kubeconfig/kubeconfig registry.redhat.io/openshift4/cnf-tests-rhel9:v{product-version} \
-/usr/bin/test-run.sh --ginkgo.junit-report junit/<file-name>.xml --ginkgo.v
+/usr/bin/test-run.sh --ginkgo.junit-report junit/<file_name>.xml --ginkgo.v
 ----
 +
 where:
 +
 --
-`junit` :: Is the folder where the junit report is stored.
+`file_name` :: The name of the XML report file.
 --

modules/hcp-deploy-openstack-create.adoc

@@ -1,3 +1,7 @@
+// Module included in the following assemblies:
+//
+// * hosted_control_planes/hcp-deploy-hcp-deploy-openstack
+
 :_mod-docs-content-type: PROCEDURE
 [id="hcp-deploy-openstack-create_{context}"]
 = Creating a hosted cluster on OpenStack
@@ -80,5 +84,5 @@ $ df -h /var/lib
 ====
 The {rh-openstack} resources that the cluster API (CAPI) provider creates are tagged with the label `openshiftClusterID=<infraID>`. 
 
-You can define additional tags for the resources as values in the `HostedCluster.Spec.Platform.OpenStack.Tags` field of a YAML manifest that you use to create the hosted cluster. The tags are applied when you scale up the node pool.
+You can define additional tags for the resources as values in the `HostedCluster.Spec.Platform.OpenStack.Tags` field of a YAML manifest that you use to create the hosted cluster. After you scale up the node pool, the tags apply to resources.
 ====

modules/hosted-clusters-openstack-upload-rhcos.adoc

@@ -6,7 +6,7 @@
 [id="hosted-clusters-openstack-upload-rhcos_{context}"]
 = Uploading the RHCOS image to OpenStack
 
-If you want to specify which {op-system} image to use when deploying node pools on and {hcp} and {rh-openstack-first} deployment, upload the image to the {rh-openstack} cloud. If you do not upload the image, the OpenStack Resource Controller (ORC) downloads an image from the {product-title} mirror and deletes it when the hosted cluster is deleted.
+If you want to specify the {op-system} image to use when deploying node pools on {hcp} and {rh-openstack-first} deployment, upload the image to the {rh-openstack} cloud. If you do not upload the image, the OpenStack Resource Controller (ORC) downloads an image from the {product-title} mirror and deletes the image after deletion of the hosted cluster.
 
 .Prerequisites
 

modules/nw-egressnetworkpolicy-create.adoc

@@ -44,18 +44,7 @@ policy rules.
 $ oc create -f <policy_name>.yaml -n <project>
 ----
 +
-In the following example, a new {kind} object is created in a project named `project1`:
-+
-[source,terminal]
-----
-$ oc create -f default.yaml -n project1
-----
-+
-.Example output
-[source,terminal,subs="attributes"]
-----
-{obj} created
-----
+Successful output lists the {obj} name and the `created` status.
 
 . Optional: Save the `<policy_name>.yaml` file so that you can make changes later.
 

modules/nw-networkpolicy-allow-application-all-namespaces.adoc

@@ -31,7 +31,7 @@ ifndef::microshift[]
 endif::microshift[]
 * You installed the OpenShift CLI (`oc`).
 ifndef::microshift[]
-* You are logged in to the cluster with a user with `{role}` privileges.
+* You logged in to the cluster with a user with `{role}` privileges.
 endif::microshift[]
 * You are working in the namespace that the {name} policy applies to.
 
@@ -71,7 +71,7 @@ spec:
 +
 [NOTE]
 ====
-By default, if you omit specifying a `namespaceSelector` it does not select any namespaces, which means the policy allows traffic only from the namespace the network policy is deployed to.
+By default, if you do not specify a `namespaceSelector` parameter in the policy object, no namespaces get selected. This means the policy allows traffic only from the namespace where the network policy deployes.
 ====
 
 . Apply the policy by entering the following command:
@@ -81,16 +81,7 @@ By default, if you omit specifying a `namespaceSelector` it does not select any
 $ oc apply -f web-allow-all-namespaces.yaml
 ----
 +
-.Example output
-[source,terminal]
-----
-ifndef::multi[]
-networkpolicy.networking.k8s.io/web-allow-all-namespaces created
-endif::multi[]
-ifdef::multi[]
-multinetworkpolicy.k8s.cni.cncf.io/web-allow-all-namespaces created
-endif::multi[]
-----
+Successful output lists the name of the policy object and the `created` status.
 
 .Verification
 
@@ -108,7 +99,7 @@ $ oc run web --namespace=default --image=nginx --labels="app=web" --expose --por
 $ oc run test-$RANDOM --namespace=secondary --rm -i -t --image=alpine -- sh
 ----
 
-. Run the following command in the shell and observe that the request is allowed:
+. Run the following command in the shell and observe that the service allows the request:
 +
 [source,terminal]
 ----

modules/nw-networkpolicy-allow-application-particular-namespace.adoc

@@ -25,7 +25,7 @@ endif::microshift[]
 
 Follow this procedure to configure a policy that allows traffic to a pod with the label `app=web` from a particular namespace. You might want to do this to:
 
-* Restrict traffic to a production database only to namespaces where production workloads are deployed.
+* Restrict traffic to a production database only to namespaces that have production workloads deployed.
 * Enable monitoring tools deployed to a particular namespace to scrape metrics from the current namespace.
 
 .Prerequisites
@@ -34,7 +34,7 @@ ifndef::microshift[]
 endif::microshift[]
 * You installed the OpenShift CLI (`oc`).
 ifndef::microshift[]
-* You are logged in to the cluster with a user with `{role}` privileges.
+* You logged in to the cluster with a user with `{role}` privileges.
 endif::microshift[]
 * You are working in the namespace that the {name} policy applies to.
 
@@ -81,16 +81,7 @@ spec:
 $ oc apply -f web-allow-prod.yaml
 ----
 +
-.Example output
-[source,terminal]
-----
-ifndef::multi[]
-networkpolicy.networking.k8s.io/web-allow-prod created
-endif::multi[]
-ifdef::multi[]
-multinetworkpolicy.k8s.cni.cncf.io/web-allow-prod created
-endif::multi[]
-----
+Successful output lists the name of the policy object and the `created` status.
 
 .Verification
 
@@ -136,19 +127,12 @@ $ oc label namespace/dev purpose=testing
 $ oc run test-$RANDOM --namespace=dev --rm -i -t --image=alpine -- sh
 ----
 
-. Run the following command in the shell and observe that the request is blocked:
+. Run the following command in the shell and observe the reason for the blocked request. For example, expected output states `wget: download timed out`.
 +
 [source,terminal]
 ----
 # wget -qO- --timeout=2 http://web.default
 ----
-+
-.Expected output
-+
-[source,terminal]
-----
-wget: download timed out
-----
 
 . Run the following command to deploy an `alpine` image in the `prod` namespace and start a shell:
 +

modules/nw-networkpolicy-allow-external-clients.adoc

@@ -38,7 +38,7 @@ ifndef::microshift[]
 endif::microshift[]
 * You installed the OpenShift CLI (`oc`).
 ifndef::microshift[]
-* You are logged in to the cluster with a user with `{role}` privileges.
+* You logged in to the cluster with a user with `{role}` privileges.
 endif::microshift[]
 * You are working in the namespace that the {name} policy applies to.
 
@@ -80,17 +80,7 @@ spec:
 $ oc apply -f web-allow-external.yaml
 ----
 +
-.Example output
-+
-[source,terminal]
-----
-ifndef::multi[]
-networkpolicy.networking.k8s.io/web-allow-external created
-endif::multi[]
-ifdef::multi[]
-multinetworkpolicy.k8s.cni.cncf.io/web-allow-external created
-endif::multi[]
-----
+Successful output lists the name of the policy object and the `created` status.
 ifndef::microshift[]
 This policy allows traffic from all resources, including external traffic as illustrated in the following diagram:
 

modules/nw-networkpolicy-audit-configure.adoc

@@ -24,7 +24,7 @@ $ oc edit network.operator.openshift.io/cluster
 +
 [TIP]
 ====
-You can alternatively customize and apply the following YAML to configure audit logging:
+You can also customize and apply the following YAML to configure audit logging:
 
 [source,yaml]
 ----
@@ -60,11 +60,7 @@ metadata:
 EOF
 ----
 +
-.Example output
-[source,text]
-----
-namespace/verify-audit-logging created
-----
+Successful output lists the namespace with the network policy and the `created` status.
 
 .. Create network policies for the namespace:
 +
@@ -150,12 +146,7 @@ EOF
 done
 ----
 +
-.Example output
-[source,text]
-----
-pod/client created
-pod/server created
-----
+Successful output lists the two pods, such as `pod/client` and `pod/server`, and the `created` status.
 
 . To generate traffic and produce network policy audit log entries, complete the following steps:
 
@@ -166,7 +157,7 @@ pod/server created
 $ POD_IP=$(oc get pods server -n verify-audit-logging -o jsonpath='{.status.podIP}')
 ----
 
-.. Ping the IP address from the previous command from the pod named `client` in the `default` namespace and confirm that all packets are dropped:
+.. Ping the IP address from an earlier command from the pod named `client` in the `default` namespace and confirm the all packets are dropped:
 +
 [source,terminal]
 ----
@@ -182,7 +173,7 @@ PING 10.128.2.55 (10.128.2.55) 56(84) bytes of data.
 2 packets transmitted, 0 received, 100% packet loss, time 2041ms
 ----
 
-.. Ping the IP address saved in the `POD_IP` shell environment variable from the pod named `client` in the `verify-audit-logging` namespace and confirm that all packets are allowed:
+.. From the client pod in the `verify-audit-logging` namespace, ping the IP address stored in the `POD_IP shell` environment variable and confirm the system allows all packets.
 +
 [source,terminal]
 ----

modules/nw-networkpolicy-audit-disable.adoc

@@ -30,7 +30,7 @@ where:
 +
 [TIP]
 ====
-You can alternatively apply the following YAML to disable audit logging:
+You can also apply the following YAML to disable audit logging:
 
 [source,yaml]
 ----
@@ -43,8 +43,4 @@ metadata:
 ----
 ====
 +
-.Example output
-[source,terminal]
-----
-namespace/verify-audit-logging annotated
-----
+Successful output lists the audit logging name and the `annotated` status.