Skip to content

Commit bf68ce3

Browse files
authored
Merge pull request #40236 from codyhoag/remove-aws-refs
GH#40104 Hide AWS-specific configs for installer proxy information
2 parents 1716e19 + 5ad27d2 commit bf68ce3

File tree

1 file changed

+62
-11
lines changed

1 file changed

+62
-11
lines changed

modules/installation-configure-proxy.adoc

Lines changed: 62 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// Module included in the following assemblies:
22
//
3-
// * installing/installing_aws/installing_aws-customizations.adoc
4-
// * installing/installing_aws/installing_aws-network-customizations.adoc
5-
// * installing/installing_aws/installing_aws-private.adoc
6-
// * installing/installing_aws/installing_aws-vpc.adoc
7-
// * installing/installing_aws/installing_aws-china.adoc
3+
// * installing/installing_aws/installing-aws-customizations.adoc
4+
// * installing/installing_aws/installing-aws-network-customizations.adoc
5+
// * installing/installing_aws/installing-aws-private.adoc
6+
// * installing/installing_aws/installing-aws-vpc.adoc
7+
// * installing/installing_aws/installing-aws-china.adoc
88
// * installing/installing_aws/installing-aws-user-infra.adoc
99
// * installing/installing_aws/installing-aws-government-region.adoc
1010
// * installing/installing_aws/installing-restricted-networks-aws-installer-provisioned.adoc
@@ -53,8 +53,33 @@
5353
// * installing/installing-rhv-restricted-network.adoc
5454

5555
ifeval::["{context}" == "installing-aws-china-region"]
56+
:aws:
5657
:aws-china:
5758
endif::[]
59+
ifeval::["{context}" == "installing-aws-customizations"]
60+
:aws:
61+
endif::[]
62+
ifeval::["{context}" == "installing-aws-network-customizations"]
63+
:aws:
64+
endif::[]
65+
ifeval::["{context}" == "installing-aws-private"]
66+
:aws:
67+
endif::[]
68+
ifeval::["{context}" == "installing-aws-vpc"]
69+
:aws:
70+
endif::[]
71+
ifeval::["{context}" == "installing-aws-user-infra"]
72+
:aws:
73+
endif::[]
74+
ifeval::["{context}" == "installing-aws-government-region"]
75+
:aws:
76+
endif::[]
77+
ifeval::["{context}" == "installing-restricted-networks-aws-installer-provisioned"]
78+
:aws:
79+
endif::[]
80+
ifeval::["{context}" == "installing-restricted-networks-aws"]
81+
:aws:
82+
endif::[]
5883
ifeval::["{context}" == "installing-bare-metal"]
5984
:bare-metal:
6085
endif::[]
@@ -152,12 +177,13 @@ The `Proxy` object `status.noProxy` field is populated with the values of the `n
152177
153178
For installations on Amazon Web Services (AWS), Google Cloud Platform (GCP), Microsoft Azure, and {rh-openstack-first}, the `Proxy` object `status.noProxy` field is also populated with the instance metadata endpoint (`169.254.169.254`).
154179
====
155-
ifndef::aws-china[]
156-
* If your cluster is on AWS, you added the `ec2.<region>.amazonaws.com`, `elasticloadbalancing.<region>.amazonaws.com`, and `s3.<region>.amazonaws.com` endpoints to your VPC endpoint. These endpoints are required to complete requests from the nodes to the AWS EC2 API. Because the proxy works on the container level, not the node level, you must route these requests to the AWS EC2 API through the AWS private network. Adding the public IP address of the EC2 API to your allowlist in your proxy server is not sufficient.
157-
endif::aws-china[]
158-
ifdef::aws-china[]
159-
* You have added the `ec2.<region>.amazonaws.com.cn`, `elasticloadbalancing.<region>.amazonaws.com`, and `s3.<region>.amazonaws.com` endpoints to your VPC endpoint. These endpoints are required to complete requests from the nodes to the AWS EC2 API. Because the proxy works on the container level, not the node level, you must route these requests to the AWS EC2 API through the AWS private network. Adding the public IP address of the EC2 API to your allowlist in your proxy server is not sufficient.
160-
endif::aws-china[]
180+
181+
ifdef::aws[]
182+
* You have added the
183+
ifdef::aws-china[`ec2.<region>.amazonaws.com.cn`, ]
184+
ifndef::aws-china[`ec2.<region>.amazonaws.com`, ]
185+
`elasticloadbalancing.<region>.amazonaws.com`, and `s3.<region>.amazonaws.com` endpoints to your VPC endpoint. These endpoints are required to complete requests from the nodes to the AWS EC2 API. Because the proxy works on the container level, not the node level, you must route these requests to the AWS EC2 API through the AWS private network. Adding the public IP address of the EC2 API to your allowlist in your proxy server is not sufficient.
186+
endif::aws[]
161187
// TODO: xref installation-aws-user-infra-requirements.adoc#installation-aws-user-infra-other-infrastructure_{context} as a relative link
162188

163189
.Procedure
@@ -213,8 +239,33 @@ proxies can be created.
213239
====
214240

215241
ifeval::["{context}" == "installing-aws-china-region"]
242+
:!aws:
216243
:!aws-china:
217244
endif::[]
245+
ifeval::["{context}" == "installing-aws-customizations"]
246+
:!aws:
247+
endif::[]
248+
ifeval::["{context}" == "installing-aws-network-customizations"]
249+
:!aws:
250+
endif::[]
251+
ifeval::["{context}" == "installing-aws-private"]
252+
:!aws:
253+
endif::[]
254+
ifeval::["{context}" == "installing-aws-vpc"]
255+
:!aws:
256+
endif::[]
257+
ifeval::["{context}" == "installing-aws-user-infra"]
258+
:!aws:
259+
endif::[]
260+
ifeval::["{context}" == "installing-aws-government-region"]
261+
:!aws:
262+
endif::[]
263+
ifeval::["{context}" == "installing-restricted-networks-aws-installer-provisioned"]
264+
:!aws:
265+
endif::[]
266+
ifeval::["{context}" == "installing-restricted-networks-aws"]
267+
:!aws:
268+
endif::[]
218269
ifeval::["{context}" == "installing-bare-metal"]
219270
:!bare-metal:
220271
endif::[]

0 commit comments

Comments
 (0)