Skip to content

Commit c3c3d3e

Browse files
authored
Merge pull request #60258 from mburke5678/mco-layering-image-names
OCPBUGS13384: Examples for layering custom content should not have invalid image links
2 parents 3fe9227 + 11c4501 commit c3c3d3e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

modules/coreos-layering-configuring.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ For example, the following Containerfile creates a custom layered image from an
3030
[source,yaml]
3131
----
3232
# Using a 4.12.0 image
33-
FROM quay.io/openshift-release/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d <1>
33+
FROM quay.io/openshift-release/ocp-release@sha256... <1>
3434
#Install hotfix rpm
3535
RUN rpm-ostree override replace https://example.com/hotfixes/haproxy-1.0.16-5.el8.src.rpm && \ <2>
3636
rpm-ostree cleanup -m && \
3737
ostree container commit
3838
----
39-
<1> Specifies an {product-title} release image.
39+
<1> Specifies the {op-system} base image of your cluster.
4040
<2> Specifies the path to the Hotfix package.
4141
+
4242
[NOTE]
@@ -63,7 +63,7 @@ metadata:
6363
machineconfiguration.openshift.io/role: worker <1>
6464
name: os-layer-custom
6565
spec:
66-
osImageURL: quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3 <2>
66+
osImageURL: quay.io/my-registry/custom-image@sha256... <2>
6767
----
6868
<1> Specifies the machine config pool to apply the custom layered image.
6969
<2> Specifies the path to the custom layered image in the repository.
@@ -133,7 +133,7 @@ Annotations: machineconfiguration.openshift.io/generated-by-controller-version:
133133
API Version: machineconfiguration.openshift.io/v1
134134
Kind: MachineConfig
135135
...
136-
Os Image URL: quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3
136+
Os Image URL: quay.io/my-registry/custom-image@sha256...
137137
----
138138

139139
.. Check that the associated machine config pool is updating with the new machine config:
@@ -199,7 +199,7 @@ sh-4.4# sudo rpm-ostree status
199199
----
200200
State: idle
201201
Deployments:
202-
* ostree-unverified-registry:quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3
203-
Digest: sha256:306b606615dcf8f0e5e7d87fee3
202+
* ostree-unverified-registry:quay.io/my-registry/...
203+
Digest: sha256:...
204204
----
205205

post_installation_configuration/coreos-layering.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ In the event you want a Hotfix, it will be provided to you based on link:https:/
4444
[source,yaml]
4545
----
4646
# Using a 4.12.0 image
47-
FROM quay.io/openshift-release-dev/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d
47+
FROM quay.io/openshift-release-dev/ocp-release@sha256...
4848
#Install hotfix rpm
4949
RUN rpm-ostree override replace https://example.com/myrepo/haproxy-1.0.16-5.el8.src.rpm && \
5050
rpm-ostree cleanup -m && \
@@ -56,7 +56,7 @@ RUN rpm-ostree override replace https://example.com/myrepo/haproxy-1.0.16-5.el8.
5656
.Example Containerfile to apply the firewalld utility
5757
[source,yaml]
5858
----
59-
FROM quay.io/openshift-release-dev/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d
59+
FROM quay.io/openshift-release-dev/ocp-release@sha256...
6060
ADD configure-firewall-playbook.yml .
6161
RUN rpm-ostree install firewalld ansible && \
6262
ansible-playbook configure-firewall-playbook.yml && \

0 commit comments

Comments
 (0)