Skip to content

Commit c6c43c1

Browse files
orelmisanorelmisan
committed
virt: Update DPDK checkup API
Following an upstream user-facing API change, update ConfigMap related parts. Signed-off-by: Orel Misan <[email protected]>
1 parent e69f557 commit c6c43c1

File tree

2 files changed

+45
-48
lines changed

2 files changed

+45
-48
lines changed

‎modules/virt-checking-cluster-dpdk-readiness.adoc

Lines changed: 32 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,12 @@ metadata:
106106
data:
107107
spec.timeout: 10m
108108
spec.param.networkAttachmentDefinitionName: <network_name> <1>
109-
spec.param.trafficGeneratorImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:v0.1.1" <2>
110-
spec.param.vmContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-vm:v0.1.1" <3>
109+
spec.param.trafficGenContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:v0.1.1" <2>
110+
spec.param.vmUnderTestContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-vm:v0.1.1" <3>
111111
----
112112
<1> The name of the `NetworkAttachmentDefinition` object.
113-
<2> The container image for the traffic generator. In this example, the image is pulled from the upstream Project Quay Container Registry.
114-
<3> The container disk image for the VM. In this example, the image is pulled from the upstream Project Quay Container Registry.
113+
<2> The container disk image for the traffic generator. In this example, the image is pulled from the upstream Project Quay Container Registry.
114+
<3> The container disk image for the VM under test. In this example, the image is pulled from the upstream Project Quay Container Registry.
115115
116116
. Apply the `ConfigMap` manifest in the target namespace:
117117
+
@@ -186,18 +186,35 @@ kind: ConfigMap
186186
metadata:
187187
name: dpdk-checkup-config
188188
data:
189-
spec.timeout: 1h2m
189+
spec.timeout: 10m
190190
spec.param.NetworkAttachmentDefinitionName: "dpdk-network-1"
191-
spec.param.trafficGeneratorImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:v0.1.1"
192-
spec.param.vmContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-vm:v0.1.1"
193-
status.succeeded: true
194-
status.failureReason: " "
195-
status.startTimestamp: 2022-12-21T09:33:06+00:00
196-
status.completionTimestamp: 2022-12-21T11:33:06+00:00
197-
status.result.actualTrafficGeneratorTargetNode: worker-dpdk1
198-
status.result.actualDPDKVMTargetNode: worker-dpdk2
199-
status.result.dropRate: 0
200-
----
191+
spec.param.trafficGenContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:v0.1.1"
192+
spec.param.vmUnderTestContainerDiskImage: "quay.io/kiagnose/kubevirt-dpdk-checkup-vm:v0.1.1"
193+
status.succeeded: "true" <1>
194+
status.failureReason: "" <2>
195+
status.startTimestamp: "2023-07-31T13:14:38Z" <3>
196+
status.completionTimestamp: "2023-07-31T13:19:41Z" <4>
197+
status.result.trafficGenSentPackets: "480000000" <5>
198+
status.result.trafficGenOutputErrorPackets: "0" <6>
199+
status.result.trafficGenInputErrorPackets: "0" <7>
200+
status.result.trafficGenActualNodeName: worker-dpdk1 <8>
201+
status.result.vmUnderTestActualNodeName: worker-dpdk2 <9>
202+
status.result.vmUnderTestReceivedPackets: "480000000" <10>
203+
status.result.vmUnderTestRxDroppedPackets: "0" <11>
204+
status.result.vmUnderTestTxDroppedPackets: "0" <12>
205+
----
206+
<1> Specifies if the checkup is successful (`true`) or not (`false`).
207+
<2> The reason for failure if the checkup fails.
208+
<3> The time when the checkup started, in RFC 3339 time format.
209+
<4> The time when the checkup has completed, in RFC 3339 time format.
210+
<5> The number of packets sent from the traffic generator.
211+
<6> The number of error packets sent from the traffic generator.
212+
<7> The number of error packets received by the traffic generator.
213+
<8> The node on which the traffic generator VM was scheduled.
214+
<9> The node on which the VM under test was scheduled.
215+
<10> The number of packets received on the VM under test.
216+
<11> The ingress traffic packets that were dropped by the DPDK application.
217+
<12> The egress traffic packets that were dropped from the DPDK application.
201218
202219
. Delete the job and config map that you previously created by running the following commands:
203220
+

‎modules/virt-dpdk-config-map-parameters.adoc

Lines changed: 13 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
The following table shows the mandatory and optional parameters that you can set in the `data` stanza of the input `ConfigMap` manifest when you run a cluster DPDK readiness checkup:
1010

11-
.DPDK checkup config map parameters
11+
.DPDK checkup config map input parameters
1212
[cols="1,1,1", options="header"]
1313
|====
1414
|Parameter
@@ -23,52 +23,32 @@ The following table shows the mandatory and optional parameters that you can set
2323
|The name of the `NetworkAttachmentDefinition` object of the SR-IOV NICs connected.
2424
|True
2525

26-
|`spec.param.trafficGeneratorRuntimeClassName`
27-
|The RuntimeClass resource that the traffic generator pod uses.
28-
|True
29-
30-
|`spec.param.trafficGeneratorImage`
31-
|The container image for the traffic generator. The default value is `quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:main`.
32-
|False
33-
34-
|`spec.param.trafficGeneratorNodeSelector`
35-
|The node on which the traffic generator pod is to be scheduled. The node should be configured to allow DPDK traffic.
36-
|False
37-
38-
|`spec.param.trafficGeneratorPacketsPerSecond`
39-
|The number of packets per second, in kilo (k) or million(m). The default value is 14m.
40-
|False
41-
42-
|`spec.param.trafficGeneratorEastMacAddress`
43-
|The MAC address of the NIC connected to the traffic generator pod or VM. The default value is a random MAC address in the format `50:xx:xx:xx:xx:01`.
44-
|False
45-
46-
|`spec.param.trafficGeneratorWestMacAddress`
47-
|The MAC address of the NIC connected to the traffic generator pod or VM. The default value is a random MAC address in the format `50:xx:xx:xx:xx:02`.
26+
|`spec.param.trafficGenContainerDiskImage`
27+
|The container disk image for the traffic generator. The default value is `quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:main`.
4828
|False
4929

50-
|`spec.param.vmContainerDiskImage`
51-
|The container disk image for the VM. The default value is `quay.io/kiagnose/kubevirt-dpdk-checkup-vm:main`.
30+
|`spec.param.trafficGenTargetNodeName`
31+
|The node on which the traffic generator VM is to be scheduled. The node should be configured to allow DPDK traffic.
5232
|False
5333

54-
|`spec.param.DPDKLabelSelector`
55-
|The label of the node on which the VM runs. The node should be configured to allow DPDK traffic.
34+
|`spec.param.trafficGenPacketsPerSecond`
35+
|The number of packets per second, in kilo (k) or million(m). The default value is 8m.
5636
|False
5737

58-
|`spec.param.DPDKEastMacAddress`
59-
|The MAC address of the NIC that is connected to the VM. The default value is a random MAC address in the format `60:xx:xx:xx:xx:01`.
38+
|`spec.param.vmUnderTestContainerDiskImage`
39+
|The container disk image for the VM under test. The default value is `quay.io/kiagnose/kubevirt-dpdk-checkup-vm:main`.
6040
|False
6141

62-
|`spec.param.DPDKWestMacAddress`
63-
|The MAC address of the NIC that is connected to the VM. The default value is a random MAC address in the format `60:xx:xx:xx:xx:02`.
42+
|`spec.param.vmUnderTestTargetNodeName`
43+
|The node on which the VM under test is to be scheduled. The node should be configured to allow DPDK traffic.
6444
|False
6545

6646
|`spec.param.testDuration`
6747
|The duration, in minutes, for which the traffic generator runs. The default value is 5 minutes.
6848
|False
6949

70-
|`spec.param.portBandwidthGB`
71-
|The maximum bandwidth of the SR-IOV NIC. The default value is 10GB.
50+
|`spec.param.portBandwidthGbps`
51+
|The maximum bandwidth of the SR-IOV NIC. The default value is 10Gbps.
7252
|False
7353

7454
|`spec.param.verbose`

0 commit comments

Comments
 (0)