Skip to content

Commit c91ae64

Browse files
authored
Merge pull request #51547 from smunje1/RHDEVDOCS-4543
RHDEVDOCS-4543 : Disable OLM Descriptor Feature
2 parents a1ad16c + e0dff76 commit c91ae64

File tree

6 files changed

+38
-7
lines changed

6 files changed

+38
-7
lines changed

applications/connecting_applications_to_services/exposing-binding-data-from-a-service.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ include::modules/sbo-categories-of-exposable-binding-data.adoc[leveloffset=+1]
2121
[role="_additional-resources"]
2222
[id="additional-resources_exposing-binding-data"]
2323
== Additional resources
24-
* link:https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md[OLM Descriptor Reference].
24+
// * link:https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md[OLM Descriptor Reference].
25+
// When OLM descriptors are supported again, add this additional resource.
2526
* xref:../../operators/operator_sdk/osdk-generating-csvs.adoc#osdk-generating-csvs[Defining cluster service versions (CSVs)].
2627
* xref:../../applications/connecting_applications_to_services/projecting-binding-data.adoc#projecting-binding-data[Projecting binding data].

modules/sbo-categories-of-exposable-binding-data.adoc

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ data:
7373
user: "Z3Vlc3Q="
7474
----
7575

76+
////
7677
The following example shows how to expose an entire config map through OLM descriptors:
7778
7879
.Example: Exposing an entire config map through OLM descriptors
@@ -87,6 +88,8 @@ The following example shows how to expose an entire config map through OLM descr
8788
This example uses the `path` attribute with a `urn:alm:descriptor:io.kubernetes:ConfigMap` entry to indicate that the path points to the `ConfigMap` service resource.
8889
8990
If you intend to project all the values from a `ConfigMap` service resource, you must specify it as an attribute in the backing service CR. For example, if the attribute is part of the `.spec` section, you can create and use a `specDescriptors` array. Or, if the attribute is part of the `.status` section, you can create and use a `statusDescriptors` array.
91+
////
92+
// When the OLM descriptors are supported again, add this example.
9093

9194
[id="exposing-a-specific-entry-from-a-config-map-or-secret-that-is-referenced-from-a-resource_{context}"]
9295
== Exposing a specific entry from a config map or secret that is referenced from a resource
@@ -117,6 +120,7 @@ data:
117120
user: "hippo"
118121
----
119122

123+
////
120124
The following example shows how to expose a specific entry from a config map through OLM descriptors:
121125
122126
.Example: Exposing an entry from a config map through OLM descriptors
@@ -132,6 +136,8 @@ This example uses the `path` attribute with an `X-Descriptors` update for `servi
132136
133137
* Name of the binding key that is to be projected
134138
* Name of the key in the Secret service resource
139+
////
140+
// When the OLM descriptors are supported again, add this example.
135141

136142
[id="exposing-a-resource-definition-value_{context}"]
137143
== Exposing a resource definition value
@@ -150,6 +156,7 @@ metadata:
150156
...
151157
----
152158

159+
////
153160
The following example shows how to expose a resource definition value through OLM descriptors:
154161
155162
.Example: Exposing a resource definition value through OLM descriptors
@@ -163,6 +170,8 @@ The following example shows how to expose a resource definition value through OL
163170
The previous example uses the `connectionURL` attribute that points to the required resource definition value that is to be projected as `uri`.
164171
165172
If required values are available as attributes of backing service resources, annotating these values using `X-Descriptors` identifies them as the binding data.
173+
////
174+
// When the OLM descriptors are supported again, add this example.
166175

167176
[id="exposing-entries-of-a-collection-with-the-key-and-value-from-each-entry_{context}"]
168177
== Exposing entries of a collection with the key and value from each entry
@@ -200,6 +209,7 @@ The following example shows how the previous entries of a collection in annotati
200209
/bindings/<binding-name>/uri_404 => black-hole.example.com
201210
----
202211

212+
////
203213
The following example shows how to expose the entries of a collection with the key and value from each entry through OLM descriptors:
204214
205215
.Example: Exposing the entries of a collection through OLM descriptors
@@ -211,6 +221,8 @@ The following example shows how to expose the entries of a collection with the k
211221
----
212222
213223
The previous example uses the `path` attribute with an `X-Descriptors` update for the required entries of a collection.
224+
////
225+
// When the OLM descriptors are supported again, add this example.
214226

215227
.Example: Configuration from a backing service resource
216228
[source,yaml]
@@ -259,6 +271,7 @@ The following example shows how the previous items of a collection in annotation
259271
/bindings/<binding-name>/tags_2 => power
260272
----
261273

274+
////
262275
The following example shows how to expose the items of a collection with one key per item through OLM descriptors:
263276
264277
.Example: Exposing the items of a collection through OLM descriptors
@@ -270,6 +283,8 @@ The following example shows how to expose the items of a collection with one key
270283
----
271284
272285
The previous example uses the `path` attribute with an `X-Descriptors` update for the required items of a collection.
286+
////
287+
// When the OLM descriptors are supported again, add this example.
273288

274289
.Example: Configuration from a backing service resource
275290
[source,yaml]
@@ -315,6 +330,7 @@ The following example shows how the previous values of a collection in annotatio
315330
/bindings/<binding-name>/url_2 => black-hole.example.com
316331
----
317332

333+
////
318334
The following example shows how to expose the values of collection entries with one key per entry value through OLM descriptors:
319335
320336
.Example: Exposing the values of collection entries through OLM descriptors
@@ -323,4 +339,6 @@ The following example shows how to expose the values of collection entries with
323339
- path: bootstrap
324340
x-descriptors:
325341
- service.binding:endpoints:elementType=sliceOfStrings:sourceValue=url
326-
----
342+
----
343+
////
344+
// When the OLM descriptors are supported again, add this example.

modules/sbo-data-model.adoc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
= Data model
88

99
[role="_abstract"]
10-
The data model used in the annotations and OLM descriptors follow specific conventions.
10+
// The data model used in the annotations and OLM descriptors follow specific conventions.
11+
// When the OLM descriptors are supported again, add this sentence.
12+
13+
The data model used in the annotations follows specific conventions.
1114

1215
Service binding annotations must use the following convention:
1316

@@ -21,7 +24,8 @@ where:
2124
`<NAME>`:: Specifies the name under which the binding value is to be exposed. You can exclude it only when the `objectType` parameter is set to `Secret` or `ConfigMap`.
2225
`<VALUE>`:: Specifies the constant value exposed when no `path` is set.
2326

24-
Although, the data model is the same for custom resource definitions (CRD), custom resource (CR) annotations, and Operator Lifecycle Manager (OLM) descriptors, the syntax for each one differs.
27+
// Although, the data model is the same for custom resource definitions (CRD), custom resource (CR) annotations, and Operator Lifecycle Manager (OLM) descriptors, the syntax for each one differs.
28+
// When the OLM descriptors are supported again, add this sentence.
2529

2630
The data model provides the details on the allowed values and semantic for the `path`, `elementType`, `objectType`, `sourceKey`, and `sourceValue` parameters.
2731

modules/sbo-key-features.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
* Exposal of binding data from services
1010
** Based on annotations present in CRD, custom resources (CRs), or resources.
11-
** Based on descriptors present in Operator Lifecycle Manager (OLM) descriptors.
11+
// ** Based on descriptors present in Operator Lifecycle Manager (OLM) descriptors.
12+
// When the OLM descriptors are supported again, add this sentence.
1213
* Workload projection
1314
** Projection of binding data as files, with volume mounts.
1415
** Projection of binding data as environment variables.

modules/sbo-methods-of-exposing-binding-data.adoc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ You must expose the binding data from the backing service. Depending on your wor
2323
+
2424
** Direct secret reference
2525
** Declaring binding data through custom resource definition (CRD) or CR annotations
26-
** Declaring binding data through Operator Lifecycle Manager (OLM) descriptors
26+
// ** Declaring binding data through Operator Lifecycle Manager (OLM) descriptors
27+
// When the OLM descriptors are supported again, add this sentence.
2728
** Detection of binding data through owned resources
2829
2930
[id="provisioned-service_{context}"]
@@ -199,6 +200,7 @@ data:
199200
user: "hippo"
200201
----
201202

203+
////
202204
[id="declaring-binding-data-through-olm-descriptors_{context}"]
203205
== Declaring binding data through OLM descriptors
204206
You can use this method if your backing service is provided by an Operator. If your Operator is distributed as an OLM bundle, you can add OLM descriptors to describe the binding data that is to be exposed. The OLM descriptors are part of Cluster Service Version resources. The {servicebinding-title} detects the OLM descriptors and then creates a `Secret` resource with the values extracted based on the detected OLM descriptors.
@@ -235,6 +237,8 @@ The following examples show how to define an X-Descriptor depending on the resou
235237
* You must have a `service.binding` entry in the X-Descriptors to identify that it is a configuration for service binding.
236238
* The absence of the `Secret` or `ConfigMap` specific X-Descriptors indicates that the descriptor is referencing the binding data value at the given path.
237239
====
240+
////
241+
// When the OLM descriptors are supported again, add this section.
238242

239243
[id="detection-of-binding-data-through-owned-resources_{context}"]
240244
== Detection of binding data through owned resources

modules/sbo-naming-strategies.adoc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ While using naming strategies, depending on the expectations or requirements of
2121
* `title`: Converts the character strings where the first letter of each word is capitalized except for certain minor words.
2222
2323
.Predefined naming strategies
24-
Binding names declared through annotations or Operator Lifecycle Manager (OLM) descriptors are processed for their name change before their projection into the workload according to the following predefined naming strategies:
24+
// Binding names declared through annotations or Operator Lifecycle Manager (OLM) descriptors are processed for their name change before their projection into the workload according to the following predefined naming strategies:
25+
// When the OLM descriptors are supported again, add this sentence.
26+
27+
Binding names declared through annotations are processed for their name change before their projection into the workload according to the following predefined naming strategies:
2528

2629
* `none`: When applied, there are no changes in the binding names.
2730
+

0 commit comments

Comments
 (0)