Skip to content

Commit cdd2114

Browse files
committed
virt, DPDK: Update runtimeClass configuration API
Following a change in HCO [0] that exposes the defaultRuntimeClass API to the user, it is now possible to configure the defaultRuntimeClass on the cluster by editing the HCO CR. This change avoids forcing the user to use the json-patch annotation workaround. [0] kubevirt/hyperconverged-cluster-operator#2370 Signed-off-by: Ram Lavi <[email protected]>
1 parent 39fc206 commit cdd2114

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

modules/virt-configuring-cluster-dpdk.adoc

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,17 @@ The compute nodes automatically restart after you apply the `MachineConfigPool`
8989
$ oc get performanceprofiles.performance.openshift.io profile-1 -o=jsonpath='{.status.runtimeClass}{"\n"}'
9090
----
9191

92-
. Set the previously obtained `RuntimeClass` name as the default container runtime class for the `virt-launcher` pods by adding the following annotation to the `HyperConverged` custom resource (CR):
92+
. Set the previously obtained `RuntimeClass` name as the default container runtime class for the `virt-launcher` pods by editing the `HyperConverged` custom resource (CR):
9393
+
9494
[source,terminal]
9595
----
96-
$ oc annotate --overwrite -n openshift-cnv hco kubevirt-hyperconverged \
97-
kubevirt.kubevirt.io/jsonpatch='[{"op": "add", "path": "/spec/configuration/defaultRuntimeClass", "value": <runtimeclass_name>}]'
96+
$ oc patch -n openshift-cnv hco kubevirt-hyperconverged \
97+
--type='json' -p='[{"op": "add", "path": "/spec/defaultRuntimeClass", "value":"<runtimeclass-name>"}]'
9898
----
9999
+
100100
[NOTE]
101101
====
102-
Adding the annotation to the `HyperConverged` CR changes a global setting that affects all VMs that are created after the annotation is applied.
103-
Setting this annotation breaches support of the {VirtProductName} instance and must be used only on test clusters. For best performance, apply for a support exception.
102+
Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.
104103
====
105104

106105
. Create an `SriovNetworkNodePolicy` object with the `spec.deviceType` field set to `vfio-pci`:

0 commit comments

Comments
 (0)