Skip to content

Commit d655dc3

Browse files
authored
Merge pull request #66878 from aireilly/custom-custom-crs
Typo fixes: "custom custom resources" doesn't make sense
2 parents c95716b + 34914fb commit d655dc3

File tree

3 files changed

+52
-52
lines changed

3 files changed

+52
-52
lines changed

modules/ztp-adding-new-content-to-gitops-ztp.adoc

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Perform the following procedure to add new content to the {ztp} pipeline.
1313

1414
. Create a subdirectory named `source-crs` in the directory that contains the `kustomization.yaml` file for the `PolicyGenTemplate` custom resource (CR).
1515

16-
. Add your custom CRs to the `source-crs` subdirectory, as shown in the following example:
16+
. Add your user-provided CRs to the `source-crs` subdirectory, as shown in the following example:
1717
+
1818
[source,text]
1919
----
@@ -42,54 +42,54 @@ example
4242
apiVersion: ran.openshift.io/v1
4343
kind: PolicyGenTemplate
4444
metadata:
45-
name: "group-dev"
46-
namespace: "ztp-clusters"
45+
name: "group-dev"
46+
namespace: "ztp-clusters"
4747
spec:
4848
bindingRules:
49-
dev: "true"
50-
mcp: "master"
49+
dev: "true"
50+
mcp: "master"
5151
sourceFiles:
5252
# These policies/CRs come from the internal container Image
5353
#Cluster Logging
5454
- fileName: ClusterLogNS.yaml
55-
remediationAction: inform
56-
policyName: "group-dev-cluster-log-ns"
55+
remediationAction: inform
56+
policyName: "group-dev-cluster-log-ns"
5757
- fileName: ClusterLogOperGroup.yaml
58-
remediationAction: inform
59-
policyName: "group-dev-cluster-log-operator-group"
58+
remediationAction: inform
59+
policyName: "group-dev-cluster-log-operator-group"
6060
- fileName: ClusterLogSubscription.yaml
61-
remediationAction: inform
62-
policyName: "group-dev-cluster-log-sub"
61+
remediationAction: inform
62+
policyName: "group-dev-cluster-log-sub"
6363
#Local Storage Operator
6464
- fileName: StorageNS.yaml
65-
remediationAction: inform
66-
policyName: "group-dev-lso-ns"
65+
remediationAction: inform
66+
policyName: "group-dev-lso-ns"
6767
- fileName: StorageOperGroup.yaml
68-
remediationAction: inform
69-
policyName: "group-dev-lso-operator-group"
68+
remediationAction: inform
69+
policyName: "group-dev-lso-operator-group"
7070
- fileName: StorageSubscription.yaml
7171
remediationAction: inform
7272
policyName: "group-dev-lso-sub"
7373
#These are custom local polices that come from the source-crs directory in the git repo
7474
# Performance Addon Operator
7575
- fileName: PaoSubscriptionNS.yaml
76-
remediationAction: inform
77-
policyName: "group-dev-pao-ns"
76+
remediationAction: inform
77+
policyName: "group-dev-pao-ns"
7878
- fileName: PaoSubscriptionCatalogSource.yaml
79-
remediationAction: inform
80-
policyName: "group-dev-pao-cat-source"
79+
remediationAction: inform
80+
policyName: "group-dev-pao-cat-source"
8181
spec:
8282
image: <image_URL_here>
8383
- fileName: PaoSubscription.yaml
8484
remediationAction: inform
8585
policyName: "group-dev-pao-sub"
8686
#Elasticsearch Operator
8787
- fileName: elasticsearch/ElasticsearchNS.yaml <1>
88-
remediationAction: inform
89-
policyName: "group-dev-elasticsearch-ns"
88+
remediationAction: inform
89+
policyName: "group-dev-elasticsearch-ns"
9090
- fileName: elasticsearch/ElasticsearchOperatorGroup.yaml
91-
remediationAction: inform
92-
policyName: "group-dev-elasticsearch-operator-group"
91+
remediationAction: inform
92+
policyName: "group-dev-elasticsearch-operator-group"
9393
#Custom Resources
9494
- fileName: custom-crs/apiserver-config.yaml <1>
9595
remediationAction: inform

modules/ztp-preparing-the-ztp-git-repository-ver-ind.adoc

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@
66
[id="ztp-preparing-the-ztp-git-repository-ver-ind_{context}"]
77
= Preparing the {ztp} site configuration repository for version independence
88

9-
You can use {ztp} to manage source custom resources (CRs) for managed clusters that are running different versions of {product-title}.
10-
This means that the version of {product-title} running on the hub cluster can be independent of the version running on the managed clusters.
9+
You can use {ztp} to manage source custom resources (CRs) for managed clusters that are running different versions of {product-title}.
10+
This means that the version of {product-title} running on the hub cluster can be independent of the version running on the managed clusters.
1111

1212
.Procedure
1313

1414
. Create a directory structure with separate paths for the `SiteConfig` and `PolicyGenTemplate` CRs.
1515

1616
. Within the `PolicyGenTemplate` directory, create a directory for each {product-title} version you want to make available.
17-
For each version, create the following resources:
17+
For each version, create the following resources:
1818
* `kustomization.yaml` file that explicitly includes the files in that directory
1919
* `source-crs` directory to contain reference CR configuration files from the `ztp-site-generate` container
2020

21-
. In the `/siteconfig` directory, create a subdirectory for each {product-title} version you want to make available. For each version, create at least one directory for reference CRs to be copied from the container. There is no restriction on the naming of directories or on the number of reference directories. If you want to work with custom CRs, you must create a separate directory for those.
21+
. In the `/siteconfig` directory, create a subdirectory for each {product-title} version you want to make available. For each version, create at least one directory for reference CRs to be copied from the container. There is no restriction on the naming of directories or on the number of reference directories. If you want to work with user-provided CRs, you must create a separate directory for those.
2222
+
23-
The following example describes a structure using custom CRs for different versions of {product-title}:
23+
The following example describes a structure using user-provided CRs for different versions of {product-title}:
2424
+
2525
[source,text]
2626
----
2727
├── policygentemplates
28-
│ ├── kustomization.yaml <1>
28+
│ ├── kustomization.yaml <1>
2929
│ ├── version_4.13 <2>
3030
│ │ ├── common-ranGen.yaml
3131
│ │ ├── group-du-sno-ranGen.yaml
@@ -42,50 +42,50 @@ The following example describes a structure using custom CRs for different versi
4242
│ ├── kustomization.yaml <3>
4343
│ ├── ns.yaml
4444
│ └── source-crs/ <4>
45-
└── siteconfig
45+
└── siteconfig
4646
├── kustomization.yaml
4747
├── version_4.13
4848
│ ├── helix56-v413.yaml
4949
│ ├── kustomization.yaml
50-
│ ├── extra-manifest/ <5>
51-
│ └── custom-manifest/ <6>
52-
└── version_4.14
50+
│ ├── extra-manifest/ <5>
51+
│ └── custom-manifest/ <6>
52+
└── version_4.14
5353
├── helix57-v414.yaml
5454
├── kustomization.yaml
55-
├── extra-manifest/ <5>
56-
└── custom-manifest/ <6>
55+
├── extra-manifest/ <5>
56+
└── custom-manifest/ <6>
5757

5858
----
5959
<1> Create a top-level `kustomization` yaml file.
6060
<2> Create the version-specific directories within the custom `/policygentemplates` directory.
61-
<3> Create a `kustomization.yaml` file for each version.
62-
<4> Create a `source-crs` directory for each version to contain reference CRs from the `ztp-site-generate` container.
61+
<3> Create a `kustomization.yaml` file for each version.
62+
<4> Create a `source-crs` directory for each version to contain reference CRs from the `ztp-site-generate` container.
6363
<5> Create a directory within the custom `/siteconfig` directory to contain extra manifests from the `ztp-site-generate` container.
64-
<6> Create a folder to hold custom CRs.
64+
<6> Create a folder to hold user-provided CRs.
6565
+
6666
[NOTE]
6767
====
68-
In the previous example, each version subdirectory in the custom `/siteconfig` directory contains two further subdirectories, one containing the reference manifests copied from the container, the other for custom manifests that you provide.
69-
The names assigned to those directories are examples.
70-
If you use custom CRs, the last directory listed under `extraManifests.searchPaths` in the `SiteConfig` CR must be the directory containing custom CRs.
68+
In the previous example, each version subdirectory in the custom `/siteconfig` directory contains two further subdirectories, one containing the reference manifests copied from the container, the other for custom manifests that you provide.
69+
The names assigned to those directories are examples.
70+
If you use user-provided CRs, the last directory listed under `extraManifests.searchPaths` in the `SiteConfig` CR must be the directory containing user-provided CRs.
7171
====
7272
7373
. Edit the `SiteConfig` CR to include the search paths of any directories you have created.
7474
The first directory that is listed under `extraManifests.searchPaths` must be the directory containing the reference manifests.
75-
Consider the order in which the directories are listed.
75+
Consider the order in which the directories are listed.
7676
In cases where directories contain files with the same name, the file in the final directory takes precedence.
7777
+
7878
.Example SiteConfig CR
7979
+
80-
[source,yaml]
80+
[source,yaml]
8181
----
8282
extraManifests:
8383
searchPaths:
8484
- extra-manifest/ <1>
8585
- custom-manifest/ <2>
8686
----
8787
<1> The directory containing the reference manifests must be listed first under `extraManifests.searchPaths`.
88-
<2> If you are using custom CRs, the last directory listed under `extraManifests.searchPaths` in the `SiteConfig` CR must be the directory containing those custom CRs.
88+
<2> If you are using user-provided CRs, the last directory listed under `extraManifests.searchPaths` in the `SiteConfig` CR must be the directory containing those user-provided CRs.
8989

9090
. Edit the top-level `kustomization.yaml` file to control which {product-title} versions are active. The following is an example of a `kustomization.yaml` file at the top level:
9191
+
@@ -96,4 +96,4 @@ resources:
9696
#- version_4.14 <2>
9797
----
9898
<1> Activate version 4.13.
99-
<2> Use comments to deactivate a version.
99+
<2> Use comments to deactivate a version.

modules/ztp-preparing-the-ztp-git-repository.adoc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ $ podman run --log-driver=none --rm registry.redhat.io/openshift4/ztp-site-gener
5252

5353
. Copy the `out/source-crs` folder and contents to the `PolicyGentemplate` directory.
5454

55-
. The out/extra-manifests directory contains the reference manifests for a RAN DU cluster.
55+
. The out/extra-manifests directory contains the reference manifests for a RAN DU cluster.
5656
Copy the `out/extra-manifests` directory into the `SiteConfig` folder.
5757
This directory should contain CRs from the `ztp-site-generate` container only.
58-
Do not add custom CRs here.
59-
If you want to work with custom CRs you must create another directory for that content.
58+
Do not add user-provided CRs here.
59+
If you want to work with user-provided CRs you must create another directory for that content.
6060
For example:
6161
+
6262
[source,text]
@@ -70,12 +70,12 @@ example/
7070
└── kustomization.yaml
7171
----
7272

73-
. Commit the directory structure and the `kustomization.yaml` files and push to your Git repository.
73+
. Commit the directory structure and the `kustomization.yaml` files and push to your Git repository.
7474
The initial push to Git should include the `kustomization.yaml` files.
7575

76-
You can use the directory structure under `out/argocd/example` as a reference for the structure and content of your Git repository.
77-
That structure includes `SiteConfig` and `PolicyGenTemplate` reference CRs for single-node, three-node, and standard clusters.
78-
Remove references to cluster types that you are not using.
76+
You can use the directory structure under `out/argocd/example` as a reference for the structure and content of your Git repository.
77+
That structure includes `SiteConfig` and `PolicyGenTemplate` reference CRs for single-node, three-node, and standard clusters.
78+
Remove references to cluster types that you are not using.
7979

8080
For all cluster types, you must:
8181

0 commit comments

Comments
 (0)