Merge pull request #39410 from aireilly/fix-footer-overlap-welcome-page

fixes footer overlap on welcome page

Author: vikram-redhat

_templates/_page_openshift.html.erb

@@ -442,24 +442,52 @@
     toc = document.querySelector('#toc')
     main = document.querySelector('.main')
     okd_footer = document.querySelector('.footer-origin-docs')
+    
+    //handle short pages
+    if (window.innerHeight === document.documentElement.scrollHeight) {
+      //sidebar
+      if (sidebar !== null && okd_footer == null) {
+        sidebar.style.marginBottom = "38px";
+        main.style.marginBottom = "35px";
+      };
+      //okd sidebar
+      if(sidebar !== null && okd_footer !== null) {
+        sidebar.style.marginBottom = "176px";
+        main.style.marginBottom = "135px";
+      }
+    };
+
+    //handle scrolling pages
     document.addEventListener('scroll', () => {
       //scroll to bottom
       if (window.innerWidth >= 1008) {
-        if(sidebar !== null && toc !== null) {
+        if(sidebar !== null) {
+          //pages with multiple toc entries
           if(document.documentElement.scrollHeight === window.pageYOffset + window.innerHeight) {
-              sidebar.style.marginBottom = "38px";
-              toc.style.bottom = "35px";
-              main.style.marginBottom = "35px";
-              //okd footer
-              if(okd_footer !== null) {
+              //sidebar
+              if (sidebar !== null && okd_footer == null){
+                sidebar.style.marginBottom = "38px";
+                main.style.marginBottom = "35px";
+              };
+              //toc
+              if (toc !== null && okd_footer == null){
+                toc.style.bottom = "35px";
+              };
+              //okd sidebar
+              if(sidebar !== null && okd_footer !== null) {
                 sidebar.style.marginBottom = "176px";
-                toc.style.bottom = "175px";
                 main.style.marginBottom = "135px";
               };
+              //okd toc
+              if (toc !== null && okd_footer !== null){
+                toc.style.bottom = "175px";
+              };
             };
           if(document.documentElement.scrollHeight != window.pageYOffset + window.innerHeight) {
             sidebar.style.marginBottom = "0px";
-            toc.style.bottom = "0px";
+            if (toc !== null) {
+              toc.style.bottom = "0px";
+            }
           }
         }
       }