Nodes docs fixes during ROSA review

Author: Michael Burke

modules/nodes-pods-configmap-overview.adoc

@@ -6,11 +6,11 @@
 [id="nodes-pods-configmap-overview_{context}"]
 = Understanding config maps
 
-Many applications require configuration using some combination of configuration files, command line arguments, and environment variables. In {product-title}, these configuration artifacts are decoupled from image content to keep containerized applications portable.
+Many applications require configuration by using some combination of configuration files, command line arguments, and environment variables. In {product-title}, these configuration artifacts are decoupled from image content to keep containerized applications portable.
 
 The `ConfigMap` object provides mechanisms to inject containers with configuration data while keeping containers agnostic of {product-title}. A config map can be used to store fine-grained information like individual properties or coarse-grained information like entire configuration files or JSON blobs.
 
-The `ConfigMap` API object holds key-value pairs of configuration data that can be consumed in pods or used to store configuration data for system components such as controllers. For example:
+The `ConfigMap` object holds key-value pairs of configuration data that can be consumed in pods or used to store configuration data for system components such as controllers. For example:
 
 .`ConfigMap` Object Definition
 [source,yaml]
@@ -20,7 +20,7 @@ apiVersion: v1
 metadata:
   creationTimestamp: 2016-02-18T19:14:38Z
   name: example-config
-  namespace: default
+  namespace: my-namespace
 data: <1>
   example.property.1: hello
   example.property.2: world

modules/nodes-pods-configmaps-use-case-consuming-in-env-vars.adoc

@@ -6,7 +6,7 @@
 [id="nodes-pods-configmaps-use-case-consuming-in-env-vars_{context}"]
 = Populating environment variables in containers by using config maps
 
-Config maps can be used to populate individual environment variables in containers or to populate environment variables in containers from all keys that form valid environment variable names.
+You can use config maps to populate individual environment variables in containers or to populate environment variables in containers from all keys that form valid environment variable names.
 
 As an example, consider the following config map:
 

modules/nodes-pods-configmaps-use-case-consuming-in-volumes.adoc

@@ -37,7 +37,7 @@ spec:
   containers:
     - name: test-container
       image: gcr.io/google_containers/busybox
-      command: [ "/bin/sh", "cat", "/etc/config/special.how" ]
+      command: [ "/bin/sh", "-c", "cat", "/etc/config/special.how" ]
       volumeMounts:
       - name: config-volume
         mountPath: /etc/config
@@ -67,7 +67,7 @@ spec:
   containers:
     - name: test-container
       image: gcr.io/google_containers/busybox
-      command: [ "/bin/sh", "cat", "/etc/config/path/to/special-key" ]
+      command: [ "/bin/sh", "-c", "cat", "/etc/config/path/to/special-key" ]
       volumeMounts:
       - name: config-volume
         mountPath: /etc/config

modules/nodes-pods-configmaps-use-case-setting-command-line-arguments.adoc

@@ -7,7 +7,9 @@
 [id="nodes-pods-configmaps-use-case-setting-command-line-arguments_{context}"]
 = Setting command-line arguments for container commands with config maps
 
-A config map can also be used to set the value of the commands or arguments in a container. This is accomplished by using the Kubernetes substitution syntax `$(VAR_NAME)`. Consider the following config map:
+You can use a config map to set the value of the commands or arguments in a container by using the Kubernetes substitution syntax `$(VAR_NAME)`.
+
+As an example, consider the following config map:
 
 [source,yaml]
 ----
@@ -23,9 +25,9 @@ data:
 
 .Procedure
 
-* To inject values into a command in a container, you must consume the keys you want to use as environment variables, as in the consuming ConfigMaps in environment variables use case. Then you can refer to them in a container's command using the `$(VAR_NAME)` syntax.
+* To inject values into a command in a container, you must consume the keys you want to use as environment variables. Then you can refer to them in a container's command using the `$(VAR_NAME)` syntax.
 +
-.Sample `Pod` specification configured to inject specific environment variables
+.Sample pod specification configured to inject specific environment variables
 [source,yaml]
 ----
 apiVersion: v1

modules/nodes-pods-configuring-pod-critical.adoc

@@ -20,6 +20,10 @@ To make a pod critical:
 +
 [source,yaml]
 ----
+apiVersion: v1
+kind: Pod
+metadata:
+  name: my-pdb
 spec:
   template:
     metadata:

modules/nodes-pods-pod-disruption-about.adoc

@@ -47,9 +47,15 @@ $ oc get poddisruptionbudget --all-namespaces
 .Example output
 [source,terminal]
 ----
-NAMESPACE         NAME          MIN-AVAILABLE   SELECTOR
-another-project   another-pdb   4               bar=foo
-test-project      my-pdb        2               foo=bar
+NAMESPACE                              NAME                                    MIN AVAILABLE   MAX UNAVAILABLE   ALLOWED DISRUPTIONS   AGE
+openshift-apiserver                    openshift-apiserver-pdb                 N/A             1                 1                     121m
+openshift-cloud-controller-manager     aws-cloud-controller-manager            1               N/A               1                     125m
+openshift-cloud-credential-operator    pod-identity-webhook                    1               N/A               1                     117m
+openshift-cluster-csi-drivers          aws-ebs-csi-driver-controller-pdb       N/A             1                 1                     121m
+openshift-cluster-storage-operator     csi-snapshot-controller-pdb             N/A             1                 1                     122m
+openshift-cluster-storage-operator     csi-snapshot-webhook-pdb                N/A             1                 1                     122m
+openshift-console                      console                                 N/A             1                 1                     116m
+#...
 ----
 
 The `PodDisruptionBudget` is considered healthy when there are at least

modules/nodes-pods-pod-disruption-configuring.adoc

@@ -27,7 +27,7 @@ spec:
   minAvailable: 2  <2>
   selector:  <3>
     matchLabels:
-      foo: bar
+      name: my-pod
 ----
 <1> `PodDisruptionBudget` is part of the `policy/v1` API group.
 <2> The minimum number of pods that must be available simultaneously. This can
@@ -47,7 +47,7 @@ spec:
   maxUnavailable: 25% <2>
   selector: <3>
     matchLabels:
-      foo: bar
+      name: my-pod
 ----
 <1> `PodDisruptionBudget` is part of the `policy/v1` API group.
 <2> The maximum number of pods that can be unavailable simultaneously. This can

modules/nodes-pods-secrets-certificates-creating.adoc

@@ -100,10 +100,10 @@ spec:
   - name: mypod
     image: redis
     volumeMounts:
-    - name: foo
-      mountPath: "/etc/foo"
+    - name: my-container
+      mountPath: "/etc/my-path"
   volumes:
-  - name: foo
+  - name: my-volume
     secret:
       secretName: my-cert
       items:

modules/nodes-pods-secrets-creating.adoc

@@ -120,6 +120,10 @@ spec:
           secretKeyRef: <1>
             name: test-secret
             key: username
+      from:
+        kind: ImageStreamTag
+        namespace: openshift
+        name: 'cli:latest'
 ----
 <1> Specifies the environment variable that consumes the secret key.
 

modules/nodes-pods-viewing-project.adoc

@@ -30,7 +30,7 @@ For example:
 +
 [source,terminal]
 ----
-$ oc get pods -n openshift-console
+$ oc get pods
 ----
 +
 .Example output