OSDOCS#11308: Generating CLI docs for 4.17 #81546
Conversation
openshift-ci
bot
added
the
size/L
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
@zhouying7780 Can you please QE review? |
| oc adm node-image monitor --ip-addresses 192.168.111.83 | ||
| # Monitor multiple nodes being added to a cluster by separating each | ||
| IP address with a comma |
There was a problem hiding this comment.
Note that I've submitted a fix for this line (should be commented out) here: openshift/oc#1872
ShaunaDiaz
added
peer-review-done
|
/lgtm |
| [source,bash,options="nowrap"] | ||
| ---- | ||
| # Create the ISO image and download it in the current folder | ||
| oc adm node-image create |
There was a problem hiding this comment.
error: stat nodes-config.yaml: no such file or directory```
command failed.
There was a problem hiding this comment.
@zhouying7780 if I look at the help for oc adm node-image create, it does say this:
A nodes-config.yaml config file must be created to provide the required initial configuration for the selected nodes.
So I think this means that this file must exist (either in the current folder for this command, or in the /tmp/assets/ folder for the next command) for these commands to work.
There was a problem hiding this comment.
That's correct. If the --dir option is not configured (and no single node flag is used), by default the asset is equal to the current working directory
| oc adm node-image create | ||
| # Use a different assets folder | ||
| oc adm node-image create --dir=/tmp/assets |
There was a problem hiding this comment.
same here : ./oc adm node-image create --dir=/tmp/assets error: stat nodes-config.yaml: no such file or directory
There was a problem hiding this comment.
In this example the nodes-config.yaml it's expected to be in the /tmp/assets folder
| oc adm node-image create --dir=/tmp/assets | ||
| # Specify a custom image name | ||
| oc adm node-image create --o=my-node.iso |
There was a problem hiding this comment.
error: unknown flag: --o
See 'oc adm node-image create --help' for usage```
There was a problem hiding this comment.
I think this is supposed to be
| oc adm node-image create --o=my-node.iso | |
| oc adm node-image create -o=my-node.iso |
There was a problem hiding this comment.
I'll submit a PR to fix this
There was a problem hiding this comment.
Submitted openshift/oc#1874 to fix this in the oc repo for next time. Also manually fixed it here in this PR
bergerhoffer
force-pushed
the
OSDOCS-11308
branch
from
2950284 to
b4a5203
Compare
|
New changes are detected. LGTM label has been removed. |
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherrypick enterprise-4.17 |
|
@bergerhoffer: new pull request created: #82345 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Version(s):
4.17
Issue:
https://issues.redhat.com/browse/OSDOCS-11308
Link to docs preview:
QE review:
Additional information:
Note to peer reviewers: These files are automatically generated. I can't fix anything manually here, but if you see any issues, we can fix it in the appropriate eng repo.