-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP-6353 Added role to mark DITA descriptions #97476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-6353 Added role to mark DITA descriptions #97476
Conversation
🤖 Thu Aug 14 09:41:16 - Prow CI generated the docs preview: |
@anarnold97 Thank you for creating this PR but I realized that the modules/oadp-features-plugins-known-issues.adoc file must not be included in this PR as this file was removed in the #95005. This is just a friendly reminder that this file must be removed in this PR too. Thanks in advance! |
/label oadp |
7f5988a
to
25829df
Compare
@Pkylas007 - removed, please re-check and do a peer-review Thanks |
@anarnold97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you! LGTM |
@Pkylas007 - what do you want me to do with this PR?
Thanks |
@shdeshpa07 Please could you merge this PR? cc @anarnold97 |
@Pkylas007 - thank you! lost track of this |
@Pkylas007 - Please could you add relevant information in comment 0 of the PR description, such as the JIra, OCP version, etc. thanks. Also, I am confused as to why the PR is created against Please verify. cc: @anarnold97 Thanks. |
@shdeshpa07 & @Pkylas007 - my fault. lost track of this PR and got very confused |
Hi @shdeshpa07 This PR is not created by me. So, I'm unable to add the relevant JIRA info myself. |
@Pkylas007 - is this for 4.19 or do you need me to manually cherrypick to 4.20 & main, please? |
Hi @anarnold97 I clarified that this PR is for 4.19. Please could you create another one for main too? |
JIRA
Version(s):
Link to docs preview:
QE review: