Skip to content

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Aug 13, 2025

JIRA

Version(s):

  • OCP 4.19

Link to docs preview:

QE review:

  • Formatting changes therefore no QE has been needed to approve this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2025
@anarnold97 anarnold97 closed this Aug 13, 2025
@anarnold97 anarnold97 reopened this Aug 13, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 13, 2025

🤖 Thu Aug 14 09:41:16 - Prow CI generated the docs preview:
https://97476--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@Pkylas007
Copy link

@anarnold97 Thank you for creating this PR but I realized that the modules/oadp-features-plugins-known-issues.adoc file must not be included in this PR as this file was removed in the #95005. This is just a friendly reminder that this file must be removed in this PR too. Thanks in advance!

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. OADP Label for all OADP PRs and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2025
@anarnold97 anarnold97 force-pushed the oadp-6353-role-abstract-mod-work branch from 7f5988a to 25829df Compare August 14, 2025 09:28
@anarnold97
Copy link
Contributor Author

@anarnold97 Thank you for creating this PR but I realized that the modules/oadp-features-plugins-known-issues.adoc file must not be included in this PR as this file was removed in the #95005. This is just a friendly reminder that this file must be removed in this PR too. Thanks in advance!

@Pkylas007 - removed, please re-check and do a peer-review

Thanks

@anarnold97 anarnold97 closed this Aug 14, 2025
@anarnold97 anarnold97 reopened this Aug 14, 2025
Copy link

openshift-ci bot commented Aug 14, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Pkylas007
Copy link

@anarnold97 Thank you for creating this PR but I realized that the modules/oadp-features-plugins-known-issues.adoc file must not be included in this PR as this file was removed in the #95005. This is just a friendly reminder that this file must be removed in this PR too. Thanks in advance!

@Pkylas007 - removed, please re-check and do a peer-review

Thanks

Thank you!

LGTM

@anarnold97
Copy link
Contributor Author

@Pkylas007 - what do you want me to do with this PR?

  • Send the PR to @shdeshpa07 for merge review?
  • Leave it to you?

Thanks

@Pkylas007
Copy link

@Pkylas007 - what do you want me to do with this PR?

  • Send the PR to @shdeshpa07 for merge review?
  • Leave it to you?

Thanks

@shdeshpa07 Please could you merge this PR? cc @anarnold97

@anarnold97
Copy link
Contributor Author

@Pkylas007 - thank you! lost track of this

@shdeshpa07
Copy link
Contributor

shdeshpa07 commented Aug 18, 2025

@Pkylas007 - what do you want me to do with this PR?

  • Send the PR to @shdeshpa07 for merge review?
  • Leave it to you?

Thanks

@shdeshpa07 Please could you merge this PR? cc @anarnold97

@Pkylas007 - Please could you add relevant information in comment 0 of the PR description, such as the JIra, OCP version, etc. thanks.

Also, I am confused as to why the PR is created against enterprise-4.19. Do we not want to merge this in 4.20 and main? If yes, the PR has to be created on main.

Please verify.

cc: @anarnold97

Thanks.

@anarnold97
Copy link
Contributor Author

@shdeshpa07 & @Pkylas007 - my fault. lost track of this PR and got very confused

@Pkylas007
Copy link

Pkylas007 commented Aug 18, 2025

@Pkylas007 - what do you want me to do with this PR?

  • Send the PR to @shdeshpa07 for merge review?
  • Leave it to you?

Thanks

@shdeshpa07 Please could you merge this PR? cc @anarnold97

@Pkylas007 - Please could you add relevant information in comment 0 of the PR description, such as the JIra, OCP version, etc. thanks.

Also, I am confused as to why the PR is created against enterprise-4.19. Do we not want to merge this in 4.20 and main? If yes, the PR has to be created on main.

Please verify.

cc: @anarnold97

Thanks.

Hi @shdeshpa07 This PR is not created by me. So, I'm unable to add the relevant JIRA info myself.
It'd be great if you can merge this to enterprise-4.19 branch. I'll create a different PR for the main and 4.20 branches. Please let me know if that works for you.

@anarnold97
Copy link
Contributor Author

@Pkylas007 - is this for 4.19 or do you need me to manually cherrypick to 4.20 & main, please?
thanks

@Pkylas007
Copy link

@Pkylas007 - is this for 4.19 or do you need me to manually cherrypick to 4.20 & main, please? thanks

Hi @anarnold97 I clarified that this PR is for 4.19. Please could you create another one for main too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants