Removed image expiration from the on-push Konflux pipeline.

Fixed the configuration test to fail on unexpected configuration.

Author: syedriko

.tekton/openshift-mcp-server-push.yaml

@@ -28,8 +28,6 @@ spec:
       value: '{{revision}}'
     - name: output-image
       value: quay.io/redhat-user-workloads/crt-nshift-lightspeed-tenant/openshift-mcp-server:{{revision}}
-    - name: image-expires-after
-      value: 5d
     - name: build-platforms
       value:
         - linux/x86_64

pkg/mcp/configuration_test.go

@@ -1,12 +1,13 @@
 package mcp
 
 import (
+	"testing"
+
 	"github.com/containers/kubernetes-mcp-server/pkg/kubernetes"
 	"github.com/mark3labs/mcp-go/mcp"
 	"k8s.io/client-go/rest"
 	v1 "k8s.io/client-go/tools/clientcmd/api/v1"
 	"sigs.k8s.io/yaml"
-	"testing"
 )
 
 func TestConfigurationView(t *testing.T) {
@@ -31,7 +32,7 @@ func TestConfigurationView(t *testing.T) {
 		})
 		t.Run("configuration_view returns context info", func(t *testing.T) {
 			if len(decoded.Contexts) != 1 {
-				t.Errorf("invalid context count, expected 1, got %v", len(decoded.Contexts))
+				t.Fatalf("invalid context count, expected 1, got %v", len(decoded.Contexts))
 			}
 			if decoded.Contexts[0].Name != "fake-context" {
 				t.Errorf("fake-context not found: %v", decoded.Contexts)
@@ -45,7 +46,7 @@ func TestConfigurationView(t *testing.T) {
 		})
 		t.Run("configuration_view returns cluster info", func(t *testing.T) {
 			if len(decoded.Clusters) != 1 {
-				t.Errorf("invalid cluster count, expected 1, got %v", len(decoded.Clusters))
+				t.Fatalf("invalid cluster count, expected 1, got %v", len(decoded.Clusters))
 			}
 			if decoded.Clusters[0].Name != "fake" {
 				t.Errorf("fake-cluster not found: %v", decoded.Clusters)
@@ -56,7 +57,7 @@ func TestConfigurationView(t *testing.T) {
 		})
 		t.Run("configuration_view returns auth info", func(t *testing.T) {
 			if len(decoded.AuthInfos) != 1 {
-				t.Errorf("invalid auth info count, expected 1, got %v", len(decoded.AuthInfos))
+				t.Fatalf("invalid auth info count, expected 1, got %v", len(decoded.AuthInfos))
 			}
 			if decoded.AuthInfos[0].Name != "fake" {
 				t.Errorf("fake-auth not found: %v", decoded.AuthInfos)
@@ -78,7 +79,7 @@ func TestConfigurationView(t *testing.T) {
 		})
 		t.Run("configuration_view with minified=false returns additional context info", func(t *testing.T) {
 			if len(decoded.Contexts) != 2 {
-				t.Errorf("invalid context count, expected2, got %v", len(decoded.Contexts))
+				t.Fatalf("invalid context count, expected 2, got %v", len(decoded.Contexts))
 			}
 			if decoded.Contexts[0].Name != "additional-context" {
 				t.Errorf("additional-context not found: %v", decoded.Contexts)
@@ -95,15 +96,15 @@ func TestConfigurationView(t *testing.T) {
 		})
 		t.Run("configuration_view with minified=false returns cluster info", func(t *testing.T) {
 			if len(decoded.Clusters) != 2 {
-				t.Errorf("invalid cluster count, expected 2, got %v", len(decoded.Clusters))
+				t.Fatalf("invalid cluster count, expected 2, got %v", len(decoded.Clusters))
 			}
 			if decoded.Clusters[0].Name != "additional-cluster" {
 				t.Errorf("additional-cluster not found: %v", decoded.Clusters)
 			}
 		})
 		t.Run("configuration_view with minified=false returns auth info", func(t *testing.T) {
 			if len(decoded.AuthInfos) != 2 {
-				t.Errorf("invalid auth info count, expected 2, got %v", len(decoded.AuthInfos))
+				t.Fatalf("invalid auth info count, expected 2, got %v", len(decoded.AuthInfos))
 			}
 			if decoded.AuthInfos[0].Name != "additional-auth" {
 				t.Errorf("additional-auth not found: %v", decoded.AuthInfos)