refactor(config): introduce provider-specific config registry

Signed-off-by: Calum Murray <[email protected]>

Author: Cali0707

pkg/config/config.go

@@ -1,6 +1,8 @@
 package config
 
 import (
+	"bytes"
+	"fmt"
 	"os"
 
 	"github.com/BurntSushi/toml"
@@ -61,19 +63,13 @@ type StaticConfig struct {
 	// If set to "kubeconfig", the clusters will be loaded from those in the kubeconfig.
 	// If set to "in-cluster", the server will use the in cluster config
 	ClusterProviderStrategy string `toml:"cluster_provider_strategy,omitempty"`
-	// ClusterContexts is which context should be used for each cluster
-	ClusterContexts map[string]string `toml:"cluster_contexts"`
-
-	// name of the context in the kubeconfig file to look for acm access credentials in. should point to the "hub" cluster
-	AcmContextName string `toml:"acm_context_name,omitempty"`
-	// the host for the ACM cluster proxy addon
-	// if using the acm-kubeconfig strategy, this should be the route for the proxy
-	// if using the acm strategy, this should be the service for the proxy
-	AcmClusterProxyAddonHost string `toml:"acm_cluster_proxy_addon_host,omitempty"`
-	// whether to skip verifiying the tls certs from the cluster proxy
-	AcmClusterProxyAddonSkipTLSVerify bool `toml:"acm_cluster_proxy_addon_skip_tls_verify"`
-	// the CA file for the cluster proxy addon
-	AcmClusterProxyAddonCaFile string `toml:"acm_cluster_proxy_addon_ca_file"`
+
+	// ClusterProvider-specific configurations
+	// This map holds raw TOML primitives that will be parsed by registered provider parsers
+	ClusterProviderConfigs map[string]toml.Primitive `toml:"cluster_provider_configs,omitempty"`
+
+	// Internal: parsed provider configs (not exposed to TOML package)
+	parsedClusterProviderConfigs map[string]ProviderConfig
 }
 
 func Default() *StaticConfig {
@@ -101,8 +97,46 @@ func Read(configPath string) (*StaticConfig, error) {
 // ReadToml reads the toml data and returns the StaticConfig.
 func ReadToml(configData []byte) (*StaticConfig, error) {
 	config := Default()
-	if err := toml.Unmarshal(configData, config); err != nil {
+	md, err := toml.NewDecoder(bytes.NewReader(configData)).Decode(config)
+	if err != nil {
+		return nil, err
+	}
+
+	if err := config.parseClusterProviderConfigs(md); err != nil {
 		return nil, err
 	}
+
 	return config, nil
 }
+
+func (c *StaticConfig) GetProviderConfig(strategy string) (ProviderConfig, bool) {
+	config, ok := c.parsedClusterProviderConfigs[strategy]
+
+	return config, ok
+}
+
+func (c *StaticConfig) parseClusterProviderConfigs(md toml.MetaData) error {
+	if c.parsedClusterProviderConfigs == nil {
+		c.parsedClusterProviderConfigs = make(map[string]ProviderConfig, len(c.ClusterProviderConfigs))
+	}
+
+	for strategy, primitive := range c.ClusterProviderConfigs {
+		parser, ok := getProviderConfigParser(strategy)
+		if !ok {
+			continue
+		}
+
+		providerConfig, err := parser(primitive, md)
+		if err != nil {
+			return fmt.Errorf("failed to parse config for ClusterProvider '%s': %w", strategy, err)
+		}
+
+		if err := providerConfig.Validate(); err != nil {
+			return fmt.Errorf("invalid config file for ClusterProvider '%s': %w", strategy, err)
+		}
+
+		c.parsedClusterProviderConfigs[strategy] = providerConfig
+	}
+
+	return nil
+}

pkg/config/provider_config.go

@@ -0,0 +1,33 @@
+package config
+
+import (
+	"fmt"
+
+	"github.com/BurntSushi/toml"
+)
+
+// ProviderConfig is the interface that all provider-specific configurations must implement.
+// Each provider registers a factory function to parse its config from TOML primitives
+type ProviderConfig interface {
+	Validate() error
+}
+
+type ProviderConfigParser func(primitive toml.Primitive, md toml.MetaData) (ProviderConfig, error)
+
+var (
+	providerConfigParsers = make(map[string]ProviderConfigParser)
+)
+
+func RegisterProviderConfig(strategy string, parser ProviderConfigParser) {
+	if _, exists := providerConfigParsers[strategy]; exists {
+		panic(fmt.Sprintf("provider config parser already registered for strategy '%s'", strategy))
+	}
+
+	providerConfigParsers[strategy] = parser
+}
+
+func getProviderConfigParser(strategy string) (ProviderConfigParser, bool) {
+	provider, ok := providerConfigParsers[strategy]
+
+	return provider, ok
+}