-
Notifications
You must be signed in to change notification settings - Fork 78
UPSTREAM: <carry>: migrate bandrade test cases #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bandrade The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bandrade: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| }) | ||
|
|
||
| // Polarion ID: 43073 | ||
| g.It("PolarionID:43073-[OTP]Indicate dependency class in resolution constraint text", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:43073-[Skipped:Disconnected]Indicate dependency class in resolution constraint text"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
43073 is a new case in this repo, no need to add original-name
| "exclude": "topology==\"External\"" | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all cases are added in this json file
please run "make update-metadata"
| }) | ||
|
|
||
| // Polarion ID: 47149 | ||
| g.It("PolarionID:47149-[OTP]Conjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47149-[Skipped:Disconnected]Conjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add original-name
| }) | ||
|
|
||
| // Polarion ID: 47181 | ||
| g.It("PolarionID:47181-[OTP]Disjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47181-[Skipped:Disconnected]Disjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add original-name
| }) | ||
|
|
||
| // Polarion ID: 47179 | ||
| g.It("PolarionID:47179-[OTP]Disjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47179-[Skipped:Disconnected]Disjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add original-name
|
|
||
| }) | ||
|
|
||
| g.It("PolarionID:41026-[LEVEL0]OCS should only one installplan generated when creating subscription", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 within a namespace PolarionID:41026-[LEVEL0]Critical-OCS should only one installplan generated when creating subscription"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be [Level0] not [LEVEL0]
no need to add original-name
| olmv0util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Compare, "Complete", exutil.Ok, []string{"installplan", installPlan, "-n", ns, "-o=jsonpath={.status.phase}"}).Check(oc) | ||
| }) | ||
|
|
||
| g.It("PolarionID:68521-Check failureThreshold of redhat-operators catalog", g.Label("NonHyperShiftHOST"), g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 within a namespace PolarionID:68521-[Skipped:Disconnected]Check failureThreshold of redhat-operators catalog"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add original-name
| olmv0util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "10", exutil.Ok, []string{"pods", "-n", "openshift-marketplace", "-l", "olm.catalogSource=redhat-operators", "-o=jsonpath={..spec.containers[0].startupProbe.failureThreshold}"}).Check(oc) | ||
| }) | ||
|
|
||
| g.It("PolarionID:68901-Packageserver pod should not crash if updateStrategy is incorrect", g.Label("NonHyperShiftHOST"), g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 within a namespace PolarionID:68901-[Skipped:Disconnected]Packageserver pod should not crash if updateStrategy is incorrect"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add original-name
| dr.RmIr(itName) | ||
| }) | ||
|
|
||
| g.It("PolarionID:OCP-24818-Checking OLM descriptors", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade caseID format is not correct.
| } | ||
| }, | ||
| { | ||
| "name": "[sig-operator][Jira:OLM] OLMv0 webhook operator PolarionID:83979-[Skipped:Disconnected]ClusterExtension installs webhook-operator and webhooks work", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade the update is not full. you should miss some cases. please update them.
| }) | ||
|
|
||
| // Polarion ID: 43073 | ||
| g.It("PolarionID:43073-[OTP]Indicate dependency class in resolution constraint text", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:43073-[Skipped:Disconnected]Indicate dependency class in resolution constraint text"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade no need g.Label because it is first added.
same comment for other new added cases.
|
|
||
| catsrc := olmv0util.CatalogSourceDescription{ | ||
| Name: "cs-43073", | ||
| Namespace: "openshift-marketplace", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade better to create it in oc.Namespace.
| DisplayName: "ocp-47149", | ||
| Publisher: "OLM QE", | ||
| SourceType: "grpc", | ||
| Address: "quay.io/olmqe/etcd-47149:1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade if bundle image or operand iamge is not in quay.io/olmqe, quay.io/openshifttest, quay.io/openshift-qe-optional-operators, registry.redhat.io, brew.registry.redhat.io, registry.stage.redhat.io and registry-proxy.engineering.redhat.com (I am fear etcd image is not in them), please add [Skipped:Disconnected] because qe disc env only support to mirror these registry.
| olmv0util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "10", exutil.Ok, []string{"pods", "-n", "openshift-marketplace", "-l", "olm.catalogSource=redhat-operators", "-o=jsonpath={..spec.containers[0].startupProbe.failureThreshold}"}).Check(oc) | ||
| }) | ||
|
|
||
| g.It("PolarionID:68901-Packageserver pod should not crash if updateStrategy is incorrect", g.Label("NonHyperShiftHOST"), g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 within a namespace PolarionID:68901-[Skipped:Disconnected]Packageserver pod should not crash if updateStrategy is incorrect"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade
1, miss OTP
2, it was ConnectedOnly, so need to add [Skipped:Disconnected]
| }) | ||
|
|
||
| // Polarion ID: 47179 | ||
| g.It("PolarionID:47179-[OTP]Disjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47179-[Skipped:Disconnected]Disjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade it was ConnectedOnly, so need to add [Skipped:Disconnected]
| }) | ||
|
|
||
| // Polarion ID: 47181 | ||
| g.It("PolarionID:47181-[OTP]Disjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47181-[Skipped:Disconnected]Disjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade it was ConnectedOnly, so need to add [Skipped:Disconnected]
| }) | ||
|
|
||
| // Polarion ID: 47149 | ||
| g.It("PolarionID:47149-[OTP]Conjunctive constraint of one package and one GVK", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:47149-[Skipped:Disconnected]Conjunctive constraint of one package and one GVK"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade it was ConnectedOnly, so need to add [Skipped:Disconnected]
| }) | ||
|
|
||
| // Polarion ID: 43073 | ||
| g.It("PolarionID:43073-[OTP]Indicate dependency class in resolution constraint text", g.Label("original-name:[sig-operator][Jira:OLM] OLMv0 optional should PolarionID:43073-[Skipped:Disconnected]Indicate dependency class in resolution constraint text"), func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade it was ConnectedOnly, so need to add [Skipped:Disconnected]
|
/payload-aggregate periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-gcp-ovn-fips-extended-f2 3 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2c634da0-f1b7-11f0-858b-09190287355b-0 |
|
/payload-aggregate periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-gcp-ovn-techpreview-slow-extended-f1 3 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3631d4f0-f1b7-11f0-8329-1051d7132f07-0 |
|
/payload-aggregate periodic-ci-openshift-operator-framework-olm-release-4.22-periodics-e2e-gcp-ovn-ipi-disconnected-extended-f1 3 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c2ec900-f1b7-11f0-903d-2300658efe38-0 |
No description provided.