OCPBUGS-48486: Fix concurrent namespace resolution #936
Conversation
…n handler (#3483) * switch queue informer to use types.NamespacedName; relocate deletion handler Signed-off-by: Joe Lanford <[email protected]> * Add error message to object count assertion failure Signed-off-by: Per Goncalves da Silva <[email protected]> --------- Signed-off-by: Joe Lanford <[email protected]> Signed-off-by: Per Goncalves da Silva <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff
Signed-off-by: Per Goncalves da Silva <[email protected]>
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/severity-important
|
@perdasilva: This pull request references Jira Issue OCPBUGS-48486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@perdasilva Hi, what is the different between this PR and #929 ? |
|
/retest |
|
/retest |
@kuiwang02 there shouldn't be any differences. The reason I'm not using that one is that I just side-loaded the upstream PR (which hadn't merged yet) for your testing. After you gave your approval, we felt comfortable merging upstream, and this is us downstreaming it now =D I think it would be ok to do do a lite verification. Assuming CI goes through =S btw - thanks again for doing that for us! it really made us feel more comfortable merging it!! |
|
/retest |
|
@perdasilva the upstream PR operator-framework/operator-lifecycle-manager#3483 has been merged. I'm concerned this will bite us in the future. @joelanford since this is a downstream of your PR, can you verify it looks correct? |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@tmshort I mentioned it in the auto sync PR. We cannot bring it down because it requires downstream changes. The fix for the concurrent namespace resolution makes changes to the workqueues. We have some downstream only reconcilers. Merging this will clear up the auto sync. Here's the downstream only commit. It would also be possible to just cherry pick this commit into another downsync. But, I really want to get this down and start on the backporting to free up SRE. |
|
/cherry-pick release-4.17 |
|
@perdasilva: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Per Goncalves da Silva <[email protected]>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@perdasilva: Jira Issue OCPBUGS-48486: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-48486 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@perdasilva: #936 failed to apply on top of branch "release-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18 |
|
@perdasilva: new pull request created: #945 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
[ART PR BUILD NOTIFIER] Distgit: ose-operator-framework-tools |
8 participants
No description provided.