Skip to content

Commit 04585dc

Browse files
UPSTREAM: <carry>: Remove openshift-redhat-marketplace catalog tests
Removes all test references to the openshift-redhat-marketplace ClusterCatalog which has been removed from the default catalogs. Changes: - Updated catalog list in olmv1-catalog.go - Removed marketplace /v1/api/all endpoint test - Removed marketplace /v1/api/metas endpoint test - Removed marketplace check from QE test PolarionID:77413
1 parent 699aa15 commit 04585dc

File tree

4 files changed

+4
-49
lines changed

4 files changed

+4
-49
lines changed

openshift/tests-extension/.openshift-tests-extension/openshift_payload_olmv1.json

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -852,16 +852,6 @@
852852
"lifecycle": "blocking",
853853
"environmentSelector": {}
854854
},
855-
{
856-
"name": "[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog should serve FBC via the /v1/api/all endpoint",
857-
"labels": {},
858-
"resources": {
859-
"isolation": {}
860-
},
861-
"source": "openshift:payload:olmv1",
862-
"lifecycle": "blocking",
863-
"environmentSelector": {}
864-
},
865855
{
866856
"name": "[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 openshift-redhat-operators Catalog should serve FBC via the /v1/api/all endpoint",
867857
"labels": {},
@@ -892,16 +882,6 @@
892882
"lifecycle": "blocking",
893883
"environmentSelector": {}
894884
},
895-
{
896-
"name": "[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog should serve FBC via the /v1/api/metas endpoint",
897-
"labels": {},
898-
"resources": {
899-
"isolation": {}
900-
},
901-
"source": "openshift:payload:olmv1",
902-
"lifecycle": "blocking",
903-
"environmentSelector": {}
904-
},
905885
{
906886
"name": "[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:Disconnected] OLMv1 openshift-redhat-operators Catalog should serve FBC via the /v1/api/metas endpoint",
907887
"labels": {},

openshift/tests-extension/cmd/main.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,10 @@ func main() {
275275
// 3 - Remove the test in your test file.
276276
// 4 - Run make build-update
277277
ext.IgnoreObsoleteTests(
278-
// "[sig-olmv1] OLMv1 should pass a trivial sanity check",
279-
// Add more removed test names below
278+
// "[sig-olmv1] OLMv1 should pass a trivial sanity check",
279+
// Removed marketplace catalog tests (marketplace catalog removed from default catalogs)
280+
"[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog should serve FBC via the /v1/api/all endpoint",
281+
"[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog should serve FBC via the /v1/api/metas endpoint",
280282
)
281283

282284
// Initialize the environment before running any tests.

openshift/tests-extension/test/olmv1-catalog.go

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1
3838
catalogs := []string{
3939
"openshift-certified-operators",
4040
"openshift-community-operators",
41-
"openshift-redhat-marketplace",
4241
"openshift-redhat-operators",
4342
}
4443

@@ -125,18 +124,6 @@ var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1
125124
})
126125
})
127126

128-
var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog", func() {
129-
BeforeEach(func() {
130-
helpers.RequireOLMv1CapabilityOnOpenshift()
131-
if !env.Get().IsOpenShift {
132-
Skip("This test requires OpenShift Catalogs")
133-
}
134-
})
135-
It("should serve FBC via the /v1/api/all endpoint", func(ctx SpecContext) {
136-
verifyCatalogEndpoint(ctx, "openshift-redhat-marketplace", "all", "")
137-
})
138-
})
139-
140127
var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 openshift-redhat-operators Catalog", func() {
141128
BeforeEach(func() {
142129
helpers.RequireOLMv1CapabilityOnOpenshift()
@@ -173,18 +160,6 @@ var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:D
173160
})
174161
})
175162

176-
var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:Disconnected] OLMv1 openshift-redhat-marketplace Catalog", func() {
177-
BeforeEach(func() {
178-
helpers.RequireOLMv1CapabilityOnOpenshift()
179-
if !env.Get().IsOpenShift {
180-
Skip("This test requires OpenShift Catalogs")
181-
}
182-
})
183-
It("should serve FBC via the /v1/api/metas endpoint", func(ctx SpecContext) {
184-
verifyCatalogEndpoint(ctx, "openshift-redhat-marketplace", "metas", "?schema=olm.package")
185-
})
186-
})
187-
188163
var _ = Describe("[sig-olmv1][OCPFeatureGate:NewOLMCatalogdAPIV1Metas][Skipped:Disconnected] OLMv1 openshift-redhat-operators Catalog", func() {
189164
BeforeEach(func() {
190165
helpers.RequireOLMv1CapabilityOnOpenshift()

openshift/tests-extension/test/qe/specs/olmv1_cc.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ var _ = g.Describe("[sig-olmv1][Jira:OLM] clustercatalog", g.Label("NonHyperShif
136136
[]string{"clustercatalog", "openshift-community-operators", `-o=jsonpath={.status.conditions[?(@.type=="Serving")].status}`}),
137137
olmv1util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "True", exutil.Ok,
138138
[]string{"clustercatalog", "openshift-redhat-operators", `-o=jsonpath={.status.conditions[?(@.type=="Serving")].status}`}),
139-
olmv1util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "True", exutil.Ok,
140-
[]string{"clustercatalog", "openshift-redhat-marketplace", `-o=jsonpath={.status.conditions[?(@.type=="Serving")].status}`}),
141139
}
142140
for _, check := range checks {
143141
check.Check(oc)

0 commit comments

Comments
 (0)