Skip to content

Commit f5aab1b

Browse files
kuiwang02tmshort
authored andcommitted
UPSTREAM: <carry>: Update OwnSingle template to use spec.config.inline.watchNamespace
1 parent 2dd587a commit f5aab1b

File tree

4 files changed

+27
-22
lines changed

4 files changed

+27
-22
lines changed

openshift/tests-extension/.openshift-tests-extension/openshift_payload_olmv1.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"isolation": {}
1010
},
1111
"source": "openshift:payload:olmv1",
12-
"lifecycle": "informing",
12+
"lifecycle": "blocking",
1313
"environmentSelector": {
1414
"exclude": "topology==\"External\""
1515
}
@@ -40,7 +40,7 @@
4040
"isolation": {}
4141
},
4242
"source": "openshift:payload:olmv1",
43-
"lifecycle": "informing",
43+
"lifecycle": "blocking",
4444
"environmentSelector": {
4545
"exclude": "topology==\"External\""
4646
}
@@ -55,7 +55,7 @@
5555
"isolation": {}
5656
},
5757
"source": "openshift:payload:olmv1",
58-
"lifecycle": "informing",
58+
"lifecycle": "blocking",
5959
"environmentSelector": {
6060
"exclude": "topology==\"External\""
6161
}
@@ -71,7 +71,7 @@
7171
"isolation": {}
7272
},
7373
"source": "openshift:payload:olmv1",
74-
"lifecycle": "informing",
74+
"lifecycle": "blocking",
7575
"environmentSelector": {
7676
"exclude": "topology==\"External\""
7777
}
@@ -87,7 +87,7 @@
8787
"isolation": {}
8888
},
8989
"source": "openshift:payload:olmv1",
90-
"lifecycle": "informing",
90+
"lifecycle": "blocking",
9191
"environmentSelector": {
9292
"exclude": "topology==\"External\""
9393
}
@@ -102,7 +102,7 @@
102102
"isolation": {}
103103
},
104104
"source": "openshift:payload:olmv1",
105-
"lifecycle": "informing",
105+
"lifecycle": "blocking",
106106
"environmentSelector": {
107107
"exclude": "topology==\"External\""
108108
}
@@ -117,7 +117,7 @@
117117
"isolation": {}
118118
},
119119
"source": "openshift:payload:olmv1",
120-
"lifecycle": "informing",
120+
"lifecycle": "blocking",
121121
"environmentSelector": {
122122
"exclude": "topology==\"External\""
123123
}
@@ -132,7 +132,7 @@
132132
"isolation": {}
133133
},
134134
"source": "openshift:payload:olmv1",
135-
"lifecycle": "informing",
135+
"lifecycle": "blocking",
136136
"environmentSelector": {
137137
"exclude": "topology==\"External\""
138138
}
@@ -147,7 +147,7 @@
147147
"isolation": {}
148148
},
149149
"source": "openshift:payload:olmv1",
150-
"lifecycle": "informing",
150+
"lifecycle": "blocking",
151151
"environmentSelector": {
152152
"exclude": "topology==\"External\""
153153
}
@@ -162,7 +162,7 @@
162162
"isolation": {}
163163
},
164164
"source": "openshift:payload:olmv1",
165-
"lifecycle": "informing",
165+
"lifecycle": "blocking",
166166
"environmentSelector": {
167167
"exclude": "topology==\"External\""
168168
}
@@ -177,7 +177,7 @@
177177
"isolation": {}
178178
},
179179
"source": "openshift:payload:olmv1",
180-
"lifecycle": "informing",
180+
"lifecycle": "blocking",
181181
"environmentSelector": {
182182
"exclude": "topology==\"External\""
183183
}
@@ -192,7 +192,7 @@
192192
"isolation": {}
193193
},
194194
"source": "openshift:payload:olmv1",
195-
"lifecycle": "informing",
195+
"lifecycle": "blocking",
196196
"environmentSelector": {
197197
"exclude": "topology==\"External\""
198198
}
@@ -207,7 +207,7 @@
207207
"isolation": {}
208208
},
209209
"source": "openshift:payload:olmv1",
210-
"lifecycle": "informing",
210+
"lifecycle": "blocking",
211211
"environmentSelector": {
212212
"exclude": "topology==\"External\""
213213
}
@@ -222,7 +222,7 @@
222222
"isolation": {}
223223
},
224224
"source": "openshift:payload:olmv1",
225-
"lifecycle": "informing",
225+
"lifecycle": "blocking",
226226
"environmentSelector": {
227227
"exclude": "topology==\"External\""
228228
}
@@ -237,7 +237,7 @@
237237
"isolation": {}
238238
},
239239
"source": "openshift:payload:olmv1",
240-
"lifecycle": "informing",
240+
"lifecycle": "blocking",
241241
"environmentSelector": {
242242
"exclude": "topology==\"External\""
243243
}

openshift/tests-extension/cmd/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,10 @@ func main() {
219219
specs = specs.Walk(func(spec *et.ExtensionTestSpec) {
220220
if spec.Labels.Has("Extended") {
221221
// Change blocking tests to informing unless marked as ReleaseGate
222-
if !spec.Labels.Has("ReleaseGate") && spec.Lifecycle == "blocking" {
223-
spec.Lifecycle = "informing"
224-
}
222+
// QE case becomes better so that we could try it
223+
// if !spec.Labels.Has("ReleaseGate") && spec.Lifecycle == "blocking" {
224+
// spec.Lifecycle = "informing"
225+
// }
225226
// Exclude External topology for NonHyperShiftHOST tests
226227
if spec.Labels.Has("NonHyperShiftHOST") {
227228
spec.Exclude(et.TopologyEquals("External"))

openshift/tests-extension/pkg/bindata/qe/bindata.go

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

openshift/tests-extension/test/qe/testdata/olm/clusterextension-withselectorlabel-OwnSingle.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ objects:
77
kind: ClusterExtension
88
metadata:
99
name: "${NAME}"
10-
annotations:
11-
olm.operatorframework.io/watch-namespace: "${WATCHNS}"
1210
spec:
1311
namespace: "${INSTALLNAMESPACE}"
1412
serviceAccount:
1513
name: "${SANAME}"
14+
config:
15+
configType: Inline
16+
inline:
17+
watchNamespace: "${WATCHNS}"
1618
source:
1719
sourceType: "${SOURCETYPE}"
1820
catalog:

0 commit comments

Comments
 (0)