Skip to content

OCPBUGS-65634: add service account to curl job #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ehearne-redhat wants to merge 5 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-65634: add service account to curl job #594

ehearne-redhat wants to merge 5 commits into from

Conversation

@ehearne-redhat
Copy link

@ehearne-redhat ehearne-redhat commented Jan 7, 2026 •
edited
Loading

This PR adds a service account to the curl job, so that it doesn't use a default service account. The reason for this is that default service account usage should be avoided, and a bespoke service account should be used where possible.

The service account is also cleaned up after the curl job finishes/deletes itself.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 7, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2026

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-65634, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehearne-redhat
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 59e1fb0 to 5097073 Compare January 7, 2026 14:37
@ehearne-redhat
Copy link
Author

ehearne-redhat commented Jan 8, 2026

/retest

@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 816d2fc to e596858 Compare January 9, 2026 12:53
@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job branch from 788ac6e to 47e7072 Compare January 12, 2026 13:21
@ehearne-redhat
Copy link
Author

ehearne-redhat commented Jan 13, 2026

/test openshift-e2e-aws

@ehearne-redhat
Copy link
Author

ehearne-redhat commented Jan 13, 2026

/retest

@ehearne-redhat
Copy link
Author

ehearne-redhat commented Jan 13, 2026

I'm unsure why this test openshift-e2e-aws continues to fail. However, the failing file test/e2e/single_namespace_support_test.go seems to be removed in a future PR #597 .

This test isn't marked as required, so I will move this PR out of WIP.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-65634, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

Details

In response to this:

This PR adds a service account to the curl job, so that it doesn't use a default service account. The reason for this is that default service account usage should be avoided, and a bespoke service account should be used where possible.

The service account is also cleaned up after the curl job finishes/deletes itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat ehearne-redhat changed the title [WIP] OCPBUGS-65634: add service account to curl job OCPBUGS-65634: add service account to curl job Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/test openshift-e2e-aws

@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/hold
Need to wait until #597 (sync) merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/unhold

PR597 merged, you might need to rebase.

@tmshort
Copy link
Contributor

tmshort commented Jan 13, 2026

/test openshift-e2e-aws

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

@ehearne-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

@anik120 anik120 Awaiting requested review from anik120

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees

No one assigned

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehearne-redhat @openshift-ci-robot @tmshort