OCPBUGS-54412: Fix retry logic for extension tests

I accidentally broke retries for extension tests, because the pointer to
a test binary was omitted.  However, because our end goal is that we
don't retry at all, and we've existed in this state for months, I'm
leaving retries off for externally sourced tests.

origin-source tests will continue to retry with the hope we ratchet up
test quality to also stop retrying them.

Author: stbenjam

pkg/test/ginkgo/cmd_runsuite.go

@@ -505,15 +505,23 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, junitSuiteName string, mon
 
 		// Make a copy of the all failing tests (subject to the max allowed flakes) so we can have
 		// a list of tests to retry.
+		failedExtensionTestCount := 0
 		for _, test := range failing {
+			// Do not retry extension tests -- we also want to remove retries from origin-sourced
+			// tests, but extensions is where we can start.
+			if test.binary != nil {
+				failedExtensionTestCount++
+				continue
+			}
+
 			retry := test.Retry()
 			retries = append(retries, retry)
 			if len(retries) > suite.MaximumAllowedFlakes {
 				break
 			}
 		}
 
-		logrus.Warningf("Retry count: %d", len(retries))
+		logrus.Warningf("%d tests failed, %d origin-sourced tests will be retried; %d extension tests will not", len(failing), len(retries), failedExtensionTestCount)
 
 		// Run the tests in the retries list.
 		q := newParallelTestQueue(testRunnerContext)

pkg/test/ginkgo/test_suite.go

@@ -121,10 +121,12 @@ func (t *testCase) Retry() *testCase {
 	copied := &testCase{
 		name:          t.name,
 		spec:          t.spec,
+		binary:        t.binary,
 		rawName:       t.rawName,
 		binaryName:    t.binaryName,
 		locations:     t.locations,
 		testExclusion: t.testExclusion,
+		testTimeout:   t.testTimeout,
 
 		previous: t,
 	}