Skip to content

Commit 11d30d9

Browse files
Merge pull request #29900 from Miciah/OCPBUGS-56281-gatewayapicontroller-clean-up-resources-when-done
OCPBUGS-56281: gatewayapicontroller: Clean up resources when done
2 parents 7a0ace8 + 573f478 commit 11d30d9

File tree

87 files changed

+8758
-1734
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+8758
-1734
lines changed

go.mod

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ require (
3232
github.com/coreos/stream-metadata-go v0.4.9
3333
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
3434
github.com/distribution/distribution/v3 v3.0.0-20230530204932-ba46c769b3d1
35-
github.com/docker/docker v27.1.2+incompatible
35+
github.com/docker/docker v27.3.1+incompatible
3636
github.com/fsouza/go-dockerclient v1.12.0
3737
github.com/gebn/bmc v0.0.0-20250519231546-bf709e03fe3c
3838
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
@@ -59,11 +59,12 @@ require (
5959
github.com/onsi/gomega v1.37.0
6060
github.com/opencontainers/go-digest v1.0.0
6161
github.com/openshift-eng/openshift-tests-extension v0.0.0-20250711173707-dc2a20e5a5f8
62-
github.com/openshift/api v0.0.0-20250710004639-926605d3338b
62+
github.com/openshift/api v3.9.0+incompatible
6363
github.com/openshift/apiserver-library-go v0.0.0-20250710132015-f0d44ef6e53b
6464
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee
6565
github.com/openshift/client-go v0.0.0-20250710075018-396b36f983ee
6666
github.com/openshift/library-go v0.0.0-20250812160438-378de074fe7b
67+
github.com/operator-framework/operator-lifecycle-manager v0.30.1-0.20250114164243-1b6752ec65fa
6768
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250118001652-a8b9c3c31417
6869
github.com/pborman/uuid v1.2.0
6970
github.com/pkg/errors v0.9.1
@@ -88,7 +89,7 @@ require (
8889
go.etcd.io/etcd/client/pkg/v3 v3.5.21
8990
go.etcd.io/etcd/client/v3 v3.5.21
9091
golang.org/x/crypto v0.40.0
91-
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56
92+
golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c
9293
golang.org/x/mod v0.25.0
9394
golang.org/x/net v0.42.0
9495
golang.org/x/oauth2 v0.30.0
@@ -132,7 +133,6 @@ require (
132133
cloud.google.com/go/iam v1.5.2 // indirect
133134
cloud.google.com/go/monitoring v1.24.2 // indirect
134135
git.sr.ht/~sbinet/gg v0.5.0 // indirect
135-
github.com/AdaLogics/go-fuzz-headers v0.0.0-20230811130428-ced1acdcaa24 // indirect
136136
github.com/Azure/azure-pipeline-go v0.2.3 // indirect
137137
github.com/Azure/azure-sdk-for-go/sdk/internal v1.11.0 // indirect
138138
github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets v0.12.0 // indirect
@@ -198,7 +198,7 @@ require (
198198
github.com/fatih/camelcase v1.0.0 // indirect
199199
github.com/felixge/fgprof v0.9.4 // indirect
200200
github.com/felixge/httpsnoop v1.0.4 // indirect
201-
github.com/fsnotify/fsnotify v1.7.0 // indirect
201+
github.com/fsnotify/fsnotify v1.8.0 // indirect
202202
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
203203
github.com/gabriel-vasile/mimetype v1.4.9 // indirect
204204
github.com/go-asn1-ber/asn1-ber v1.5.4 // indirect
@@ -310,6 +310,7 @@ require (
310310
github.com/opencontainers/runtime-spec v1.2.0 // indirect
311311
github.com/opencontainers/selinux v1.11.1 // indirect
312312
github.com/opentracing/opentracing-go v1.2.0 // indirect
313+
github.com/operator-framework/api v0.27.0 // indirect
313314
github.com/pelletier/go-toml v1.9.5 // indirect
314315
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
315316
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
@@ -398,7 +399,7 @@ require (
398399
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect
399400
sigs.k8s.io/cloud-provider-azure/pkg/azclient v0.0.29 // indirect
400401
sigs.k8s.io/cloud-provider-azure/pkg/azclient/configloader v0.0.16 // indirect
401-
sigs.k8s.io/controller-runtime v0.19.0 // indirect
402+
sigs.k8s.io/controller-runtime v0.19.4 // indirect
402403
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect
403404
sigs.k8s.io/kube-storage-version-migrator v0.0.6-0.20230721195810-5c8923c5ff96 // indirect
404405
sigs.k8s.io/kustomize/api v0.19.0 // indirect
@@ -440,3 +441,6 @@ replace (
440441
k8s.io/sample-cli-plugin => github.com/openshift/kubernetes/staging/src/k8s.io/sample-cli-plugin v0.0.0-20250906192346-6efb6a95323f
441442
k8s.io/sample-controller => github.com/openshift/kubernetes/staging/src/k8s.io/sample-controller v0.0.0-20250906192346-6efb6a95323f
442443
)
444+
445+
// github.com/operator-framework/operator-lifecycle-manager requires this import.
446+
replace github.com/openshift/api => github.com/openshift/api v0.0.0-20250710004639-926605d3338b

go.sum

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,8 @@ github.com/distribution/distribution/v3 v3.0.0-20230530204932-ba46c769b3d1 h1:go
292292
github.com/distribution/distribution/v3 v3.0.0-20230530204932-ba46c769b3d1/go.mod h1:+AmQ9ZZMMxKQCOOUFHIN/5viLDj3tEQGPsLbNPSc0EI=
293293
github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5QvfrDyIgxBk=
294294
github.com/distribution/reference v0.6.0/go.mod h1:BbU0aIcezP1/5jX/8MP0YiH4SdvB5Y4f/wlDRiLyi3E=
295-
github.com/docker/docker v27.1.2+incompatible h1:AhGzR1xaQIy53qCkxARaFluI00WPGtXn0AJuoQsVYTY=
296-
github.com/docker/docker v27.1.2+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
295+
github.com/docker/docker v27.3.1+incompatible h1:KttF0XoteNTicmUtBO0L2tP+J7FGRFTjaEF4k6WdhfI=
296+
github.com/docker/docker v27.3.1+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
297297
github.com/docker/go-connections v0.5.0 h1:USnMq7hx7gwdVZq1L49hLXaFtUdTADjXGp+uj1Br63c=
298298
github.com/docker/go-connections v0.5.0/go.mod h1:ov60Kzw0kKElRwhNs9UlUHAE/F9Fe6GLaXnqyDdmEXc=
299299
github.com/docker/go-units v0.5.0 h1:69rxXcBk27SvSaaxTtLh/8llcHD8vYHT7WSdRZ/jvr4=
@@ -329,8 +329,8 @@ github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f/go.mod h1:OSY
329329
github.com/fatih/camelcase v1.0.0 h1:hxNvNX/xYBp0ovncs8WyWZrOrpBNub/JfaMvbURyft8=
330330
github.com/fatih/camelcase v1.0.0/go.mod h1:yN2Sb0lFhZJUdVvtELVWefmrXpuZESvPmqwoZc+/fpc=
331331
github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
332-
github.com/fatih/color v1.17.0 h1:GlRw1BRJxkpqUCBKzKOw098ed57fEsKeNjpTe3cSjK4=
333-
github.com/fatih/color v1.17.0/go.mod h1:YZ7TlrGPkiz6ku9fK3TLD/pl3CpsiFyu8N92HLgmosI=
332+
github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
333+
github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
334334
github.com/felixge/fgprof v0.9.3/go.mod h1:RdbpDgzqYVh/T9fPELJyV7EYJuHB55UTEULNun8eiPw=
335335
github.com/felixge/fgprof v0.9.4 h1:ocDNwMFlnA0NU0zSB3I52xkO4sFXk80VK9lXjLClu88=
336336
github.com/felixge/fgprof v0.9.4/go.mod h1:yKl+ERSa++RYOs32d8K6WEXCB4uXdLls4ZaZPpayhMM=
@@ -341,8 +341,8 @@ github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoD
341341
github.com/frankban/quicktest v1.14.4 h1:g2rn0vABPOOXmZUj+vbmUp0lPoXEMuhTpIluN0XL9UY=
342342
github.com/frankban/quicktest v1.14.4/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0=
343343
github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
344-
github.com/fsnotify/fsnotify v1.7.0 h1:8JEhPFa5W2WU7YfeZzPNqzMP6Lwt7L2715Ggo0nosvA=
345-
github.com/fsnotify/fsnotify v1.7.0/go.mod h1:40Bi/Hjc2AVfZrqy+aj+yEI+/bRxZnMJyTJwOpGvigM=
344+
github.com/fsnotify/fsnotify v1.8.0 h1:dAwr6QBTBZIkG8roQaJjGof0pp0EeF+tNV7YBP3F/8M=
345+
github.com/fsnotify/fsnotify v1.8.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
346346
github.com/fsouza/go-dockerclient v1.12.0 h1:S2f2crEUbBNCFiF06kR/GvioEB8EMsb3Td/bpawD+aU=
347347
github.com/fsouza/go-dockerclient v1.12.0/go.mod h1:YWUtjg8japrqD/80L98nTtCoxQFp5B5wrSsnyeB5lFo=
348348
github.com/fxamacker/cbor/v2 v2.7.0 h1:iM5WgngdRBanHcxugY4JySA0nk1wZorNOpTgCMedv5E=
@@ -868,6 +868,10 @@ github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20250416174521-4eb003743b54/go.mod
868868
github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=
869869
github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
870870
github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=
871+
github.com/operator-framework/api v0.27.0 h1:OrVaGKZJvbZo58HTv2guz7aURkhVKYhFqZ/6VpifiXI=
872+
github.com/operator-framework/api v0.27.0/go.mod h1:lg2Xx+S8NQWGYlEOvFwQvH46E5EK5IrAIL7HWfAhciM=
873+
github.com/operator-framework/operator-lifecycle-manager v0.30.1-0.20250114164243-1b6752ec65fa h1:VzZn+vxGFprQPnaLVDgU5Wfu+2UHsQJh/xLwJw8rXkA=
874+
github.com/operator-framework/operator-lifecycle-manager v0.30.1-0.20250114164243-1b6752ec65fa/go.mod h1:kzt/wadHjn76OoJeuu7BFzJFRh780BSMYuWaSxk9HGA=
871875
github.com/orisano/pixelmatch v0.0.0-20220722002657-fb0b55479cde/go.mod h1:nZgzbfBr3hhjoZnS66nKrHmduYNpc34ny7RK4z5/HM0=
872876
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250118001652-a8b9c3c31417 h1:7k+dokKFfpICbkpX5TvvpFbKTFsl/6YQd46EpY2JNhc=
873877
github.com/ovn-org/ovn-kubernetes/go-controller v0.0.0-20250118001652-a8b9c3c31417/go.mod h1:9LxDV3rAHlGHAYtVrT62y/fqfIxc5RrDiYi9RVeD0gg=
@@ -1139,8 +1143,8 @@ golang.org/x/exp v0.0.0-20191227195350-da58074b4299/go.mod h1:2RIsYlXP63K8oxa1u0
11391143
golang.org/x/exp v0.0.0-20200119233911-0405dc783f0a/go.mod h1:2RIsYlXP63K8oxa1u096TMicItID8zy7Y6sNkU49FU4=
11401144
golang.org/x/exp v0.0.0-20200207192155-f17229e696bd/go.mod h1:J/WKrq2StrnmMY6+EHIKF9dgMWnmCNThgcyBT1FY9mM=
11411145
golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6/go.mod h1:3jZMyOhIsHpP37uCMkUooju7aAi5cS1Q23tOzKc+0MU=
1142-
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 h1:2dVuKD2vS7b0QIHQbpyTISPd0LeHDbnYEryqj5Q1ug8=
1143-
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56/go.mod h1:M4RDyNAINzryxdtnbRXRL/OHtkFuWGRjvuhBJpk2IlY=
1146+
golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c h1:7dEasQXItcW1xKJ2+gg5VOiBnqWrJc+rq0DPKyvvdbY=
1147+
golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c/go.mod h1:NQtJDoLvd6faHhE7m4T/1IY708gDefGGjR/iUW8yQQ8=
11441148
golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
11451149
golang.org/x/image v0.0.0-20190802002840-cff245a6509b/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
11461150
golang.org/x/image v0.11.0 h1:ds2RoQvBvYTiJkwpSFDwCcDFNX7DqjL2WsUgTNk0Ooo=
@@ -1592,8 +1596,8 @@ sigs.k8s.io/cloud-provider-azure/pkg/azclient v0.0.29 h1:qiifAaaBqV3d/EcN9dKJaJI
15921596
sigs.k8s.io/cloud-provider-azure/pkg/azclient v0.0.29/go.mod h1:ZFAt0qF1kR+w8nBVJK56s6CFvLrlosN1i2c+Sxb7LBk=
15931597
sigs.k8s.io/cloud-provider-azure/pkg/azclient/configloader v0.0.16 h1:Fm/Yjv4nXjUtJ90uXKSKwPwaTWYuDFMhDNNOd77PlOg=
15941598
sigs.k8s.io/cloud-provider-azure/pkg/azclient/configloader v0.0.16/go.mod h1:+kl90flu4+WCP6HBGVYbKVQR+5ztDzUNrWJz8rsnvRU=
1595-
sigs.k8s.io/controller-runtime v0.19.0 h1:nWVM7aq+Il2ABxwiCizrVDSlmDcshi9llbaFbC0ji/Q=
1596-
sigs.k8s.io/controller-runtime v0.19.0/go.mod h1:iRmWllt8IlaLjvTTDLhRBXIEtkCK6hwVBJJsYS9Ajf4=
1599+
sigs.k8s.io/controller-runtime v0.19.4 h1:SUmheabttt0nx8uJtoII4oIP27BVVvAKFvdvGFwV/Qo=
1600+
sigs.k8s.io/controller-runtime v0.19.4/go.mod h1:iRmWllt8IlaLjvTTDLhRBXIEtkCK6hwVBJJsYS9Ajf4=
15971601
sigs.k8s.io/gateway-api v1.2.1 h1:fZZ/+RyRb+Y5tGkwxFKuYuSRQHu9dZtbjenblleOLHM=
15981602
sigs.k8s.io/gateway-api v1.2.1/go.mod h1:EpNfEXNjiYfUJypf0eZ0P5iXA9ekSGWaS1WgPaM42X0=
15991603
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=

test/extended/cpu_partitioning/pods.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ var (
5454
"cloud-ingress-operator": {"openshift-cloud-ingress-operator"},
5555
"managed-velero-operator": {"openshift-velero"},
5656
"velero": {"openshift-velero"},
57+
58+
"gateway": {"openshift-ingress"},
5759
}
5860

5961
excludedBestEffortDaemonSets = map[string][]string{
@@ -107,6 +109,13 @@ var _ = g.Describe("[sig-node][apigroup:config.openshift.io] CPU Partitioning cl
107109
o.Expect(err).NotTo(o.HaveOccurred())
108110

109111
for _, deployment := range deployments.Items {
112+
if deployment.Namespace == "openshift-ingress" && strings.HasPrefix(deployment.Name, "gateway-") {
113+
// The gateway deployment's name contains a hash, which
114+
// must be removed in order to be able to define an
115+
// exception. Remove this if block when the
116+
// corresponding exception is removed.
117+
deployment.Name = "gateway"
118+
}
110119
// If we find a deployment that is to be excluded from resource checks, we skip looking for their pods.
111120
if isExcluded(excludedBestEffortDeployments, deployment.Namespace, deployment.Name) {
112121
framework.Logf("skipping resource check on deployment (%s/%s) due to presence in BestEffort exclude list", deployment.Namespace, deployment.Name)

test/extended/pods/priorityclasses.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ var excludedPriorityClassPods = map[string][]string{
3737
"openshift-operators": {
3838
"servicemesh-operator3-",
3939
},
40+
41+
// Istio does not provide an option to set priority class on gateway
42+
// pods. https://issues.redhat.com/browse/OCPBUGS-54652 tracks setting
43+
// the annotation so that we can remove this exclusion.
44+
"openshift-ingress": {
45+
"gateway-",
46+
},
4047
}
4148

4249
var _ = Describe("[sig-arch] Managed cluster should", func() {

0 commit comments

Comments
 (0)