Skip to content

Commit 18eadc6

Browse files
committed
TRT-2373: OTA-1626: Add JUnitTestCase for success as well
Otherwise, it will screw up the aggregated job [1] when there is a failure for the same case. ```text Message: Passed 0 times, failed 1 times, skipped 0 times: we require at least 6 attempts to have a chance at success name: '[Monitor:cluster-version-checker][bz-Networking] clusteroperator/network must complete version change under 30 minutes' testsuitename: openshift-tests-upgrade summary: 'Passed 0 times, failed 1 times, skipped 0 times: we require at least 6 attempts to have a chance at success' passes: [] failures: - jobrunid: "1981587413155188736" humanurl: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade/1981587413155188736 gcsartifacturl: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade/1981587413155188736/artifacts skips: [] ``` [1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-azure-ovn-upgrade-4.21-micro-release-openshift-release-analysis-aggregator/1981691223231959040
1 parent b66a7e4 commit 18eadc6

File tree

1 file changed

+9
-2
lines changed
  • pkg/monitortests/clusterversionoperator/clusterversionchecker

1 file changed

+9
-2
lines changed

pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func (w *monitor) noFailingUnknownCondition(intervals monitorapi.Intervals) []*j
156156

157157
ret := []*junitapi.JUnitTestCase{noFailures}
158158

159-
for _, coName := range sets.List(violations) {
159+
for _, coName := range platformidentification.KnownOperators.List() {
160160
bzComponent := platformidentification.GetBugzillaComponentForOperator(coName)
161161
if bzComponent == "Unknown" {
162162
bzComponent = coName
@@ -166,9 +166,16 @@ func (w *monitor) noFailingUnknownCondition(intervals monitorapi.Intervals) []*j
166166
if coName == "machine-config" {
167167
m = 3 * m
168168
}
169+
name := fmt.Sprintf("[bz-%v] clusteroperator/%v must complete version change under %d minutes", bzComponent, coName, m)
170+
if !violations.Has(coName) {
171+
ret = append(ret, &junitapi.JUnitTestCase{
172+
Name: name,
173+
})
174+
continue
175+
}
169176
output := fmt.Sprintf("Cluster Operator %s has not completed version change after %d minutes", coName, m)
170177
ret = append(ret, &junitapi.JUnitTestCase{
171-
Name: fmt.Sprintf("[bz-%v] clusteroperator/%v must complete version change under %d minutes", bzComponent, coName, m),
178+
Name: name,
172179
Duration: duration,
173180
FailureOutput: &junitapi.FailureOutput{
174181
Output: output,

0 commit comments

Comments
 (0)