Skip to content

Commit 2c391f3

Browse files
Merge pull request #29326 from alebedev87/http2-router-reenable-aws
OCPBUGS-26601: Re-enable AWS for router HTTP/2 test
2 parents a08c0e0 + d72c325 commit 2c391f3

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

test/extended/router/h2spec.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package router
33
import (
44
"context"
55
"fmt"
6+
"net"
67
"os"
78
"sort"
89
"strconv"
@@ -470,7 +471,7 @@ BFNBRELPe53ZdLKWpf2Sr96vRPRNw
470471
return
471472
}
472473

473-
testSuites, err := runConformanceTests(oc, host, "h2spec", 5*time.Minute)
474+
testSuites, err := runConformanceTests(oc, host, "h2spec", 10*time.Minute)
474475
o.Expect(err).NotTo(o.HaveOccurred())
475476
o.Expect(testSuites).ShouldNot(o.BeEmpty())
476477

@@ -546,7 +547,14 @@ func failingTests(testSuites []*h2spec.JUnitTestSuite) []h2specFailingTest {
546547
func runConformanceTests(oc *exutil.CLI, host, podName string, timeout time.Duration) ([]*h2spec.JUnitTestSuite, error) {
547548
var testSuites []*h2spec.JUnitTestSuite
548549

549-
if err := wait.Poll(time.Second, timeout, func() (bool, error) {
550+
if err := wait.Poll(2*time.Second, timeout, func() (bool, error) {
551+
// Error message will read as:
552+
// <date>: INFO: lookup <host>: no such host, retrying...
553+
if _, err := net.LookupHost(host); err != nil {
554+
e2e.Logf("%v, retrying...", err)
555+
return false, nil
556+
}
557+
550558
g.By("Running the h2spec CLI test")
551559

552560
// this is the output file in the pod
@@ -613,7 +621,7 @@ func runConformanceTestsAndLogAggregateFailures(oc *exutil.CLI, host, podName st
613621
failuresByTestCaseID := map[string]int{}
614622

615623
for i := 1; i <= iterations; i++ {
616-
testResults, err := runConformanceTests(oc, host, podName, 5*time.Minute)
624+
testResults, err := runConformanceTests(oc, host, podName, 10*time.Minute)
617625
if err != nil {
618626
e2e.Logf(err.Error())
619627
continue

test/extended/router/http2.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -592,11 +592,8 @@ func resolveHost(oc *exutil.CLI, interval, timeout time.Duration, host string) (
592592
// clients.
593593
func platformHasHTTP2LoadBalancerService(platformType configv1.PlatformType) bool {
594594
switch platformType {
595-
case configv1.AzurePlatformType, configv1.GCPPlatformType:
595+
case configv1.AWSPlatformType, configv1.AzurePlatformType, configv1.GCPPlatformType:
596596
return true
597-
case configv1.AWSPlatformType:
598-
e2e.Logf("AWS support waiting on https://bugzilla.redhat.com/show_bug.cgi?id=1912413")
599-
fallthrough
600597
default:
601598
return false
602599
}

0 commit comments

Comments
 (0)