Skip to content

Commit 30400d6

Browse files
Merge pull request #30466 from neisw/k8s-annotation-changes
TRT-2403: Removed k8s filtering due to annotation change
2 parents 94655c9 + 107635b commit 30400d6

File tree

1 file changed

+10
-31
lines changed

1 file changed

+10
-31
lines changed

pkg/test/ginkgo/cmd_runsuite.go

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -443,20 +443,12 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
443443
return err
444444
}
445445

446-
kubeTests, openshiftTests := splitTests(primaryTests, func(t *testCase) bool {
447-
return strings.Contains(t.name, "[Suite:k8s]")
448-
})
449-
450-
storageTests, kubeTests := splitTests(kubeTests, func(t *testCase) bool {
446+
storageTests, openshiftTests := splitTests(primaryTests, func(t *testCase) bool {
451447
return strings.Contains(t.name, "[sig-storage]")
452448
})
453449

454-
networkK8sTests, kubeTests := splitTests(kubeTests, func(t *testCase) bool {
455-
return strings.Contains(t.name, "[sig-network]")
456-
})
457-
458-
hpaTests, kubeTests := splitTests(kubeTests, func(t *testCase) bool {
459-
return strings.Contains(t.name, "[Feature:HPA]")
450+
nodeTests, openshiftTests := splitTests(openshiftTests, func(t *testCase) bool {
451+
return strings.Contains(t.name, "[sig-node]")
460452
})
461453

462454
networkTests, openshiftTests := splitTests(openshiftTests, func(t *testCase) bool {
@@ -472,38 +464,32 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
472464
})
473465

474466
logrus.Infof("Found %d openshift tests", len(openshiftTests))
475-
logrus.Infof("Found %d kube tests", len(kubeTests))
476467
logrus.Infof("Found %d storage tests", len(storageTests))
477-
logrus.Infof("Found %d network k8s tests", len(networkK8sTests))
478-
logrus.Infof("Found %d HPA tests", len(hpaTests))
468+
logrus.Infof("Found %d node tests", len(nodeTests))
479469
logrus.Infof("Found %d network tests", len(networkTests))
480470
logrus.Infof("Found %d builds tests", len(buildsTests))
481471
logrus.Infof("Found %d must-gather tests", len(mustGatherTests))
482472

483473
// If user specifies a count, duplicate the kube and openshift tests that many times.
484474
expectedTestCount := len(early) + len(late)
485475
if count != -1 {
486-
originalKube := kubeTests
487476
originalOpenshift := openshiftTests
488477
originalStorage := storageTests
489-
originalNetworkK8s := networkK8sTests
490-
originalHpa := hpaTests
478+
originalNode := nodeTests
491479
originalNetwork := networkTests
492480
originalBuilds := buildsTests
493481
originalMustGather := mustGatherTests
494482

495483
for i := 1; i < count; i++ {
496-
kubeTests = append(kubeTests, copyTests(originalKube)...)
497484
openshiftTests = append(openshiftTests, copyTests(originalOpenshift)...)
498485
storageTests = append(storageTests, copyTests(originalStorage)...)
499-
networkK8sTests = append(networkK8sTests, copyTests(originalNetworkK8s)...)
500-
hpaTests = append(hpaTests, copyTests(originalHpa)...)
486+
nodeTests = append(nodeTests, copyTests(originalNode)...)
501487
networkTests = append(networkTests, copyTests(originalNetwork)...)
502488
buildsTests = append(buildsTests, copyTests(originalBuilds)...)
503489
mustGatherTests = append(mustGatherTests, copyTests(originalMustGather)...)
504490
}
505491
}
506-
expectedTestCount += len(openshiftTests) + len(kubeTests) + len(storageTests) + len(networkK8sTests) + len(hpaTests) + len(networkTests) + len(buildsTests) + len(mustGatherTests)
492+
expectedTestCount += len(openshiftTests) + len(storageTests) + len(nodeTests) + len(networkTests) + len(buildsTests) + len(mustGatherTests)
507493

508494
abortFn := neverAbort
509495
testCtx := ctx
@@ -524,22 +510,15 @@ func (o *GinkgoRunSuiteOptions) Run(suite *TestSuite, clusterConfig *clusterdisc
524510
// Run kube, storage, openshift, and must-gather tests. If user specified a count of -1,
525511
// we loop indefinitely.
526512
for i := 0; (i < 1 || count == -1) && testCtx.Err() == nil; i++ {
527-
kubeTestsCopy := copyTests(kubeTests)
528-
q.Execute(testCtx, kubeTestsCopy, parallelism, testOutputConfig, abortFn)
529-
tests = append(tests, kubeTestsCopy...)
530513

531514
// I thought about randomizing the order of the kube, storage, and openshift tests, but storage dominates our e2e runs, so it doesn't help much.
532515
storageTestsCopy := copyTests(storageTests)
533516
q.Execute(testCtx, storageTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // storage tests only run at half the parallelism, so we can avoid cloud provider quota problems.
534517
tests = append(tests, storageTestsCopy...)
535518

536-
networkK8sTestsCopy := copyTests(networkK8sTests)
537-
q.Execute(testCtx, networkK8sTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // run network tests separately.
538-
tests = append(tests, networkK8sTestsCopy...)
539-
540-
hpaTestsCopy := copyTests(hpaTests)
541-
q.Execute(testCtx, hpaTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // run HPA tests separately.
542-
tests = append(tests, hpaTestsCopy...)
519+
nodeTestsCopy := copyTests(nodeTests)
520+
q.Execute(testCtx, nodeTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // run node tests separately at half the parallelism, so we can avoid high cpu problems.
521+
tests = append(tests, nodeTestsCopy...)
543522

544523
networkTestsCopy := copyTests(networkTests)
545524
q.Execute(testCtx, networkTestsCopy, max(1, parallelism/2), testOutputConfig, abortFn) // run network tests separately.

0 commit comments

Comments
 (0)